DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Ali Alnubani <alialnu@nvidia.com>,
	NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
	Aaron Conole <aconole@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args
Date: Wed, 21 Apr 2021 13:58:24 +0000
Message-ID: <DM6PR11MB27962257F240918DE54A0EB1EB479@DM6PR11MB2796.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MWHPR12MB1472E652BD96C655CA1D0420DA479@MWHPR12MB1472.namprd12.prod.outlook.com>



> -----Original Message-----
> From: Ali Alnubani <alialnu@nvidia.com>
> Sent: Wednesday, April 21, 2021 8:50 AM
> To: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Dumitrescu,
> Cristian <cristian.dumitrescu@intel.com>; Aaron Conole
> <aconole@redhat.com>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of
> action args
> 
> Hi,
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> > Sent: Tuesday, April 20, 2021 10:58 PM
> > To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of
> > action args
> >
> > 12/04/2021 01:23, Cristian Dumitrescu:
> > > Each table entry is made up of match fields and action data, with the
> > > latter made up of the action ID and the action arguments. The approach
> > > of having the user specify explicitly the endianness of the action
> > > arguments is difficult to be picked up by P4 compilers, as the P4
> > > compiler is generally unaware about this aspect.
> > >
> > > This commit introduces the auto-detection of the endianness of the
> > > action arguments by examining the endianness of the their destination:
> > > network byte order (NBO) when they get copied to headers and host
> byte
> > > order (HBO) when they get copied to packet meta-data or mailboxes.
> > >
> > > The endianness specification of each action argument as part of the
> > > rule specification, e.g. H(...) and N(...) is removed from the rule
> > > file and auto-detected based on their destination. The DMA instruction
> > > scope is made internal, so mov instructions need to be used. The
> > > pattern of transferring complete headers from table entry action args
> > > to headers is detected, and the associated set of mov instructions
> > > plus header validate is internally detected and replaced with the
> > > internal-only DMA instruction to preserve performance.
> > >
> > > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >
> > Series applied, thanks
> >
> >
> 
> I believe this patchset is causing the build failures in
> https://bugs.dpdk.org/show_bug.cgi?id=683.
> 
> Regards,
> Ali

Hi Ali,

I checked this issue and here are my findings:

1. The compiler warnings are NOT caused by this patch, all of them are triggered by older code.
2. Why were they not triggered before? Either this is the first time CentOS 7 is run or the compiler has a mind of its own (my vote goes to the former).
3. These are all 100% fake issues that are probably triggered by the old GCC version from CentOS 7.

I just sent a patch now (you are copied on it) with some harmless local variable initializations in the hope it will stop these warnings on CentOS 7. As I don't have access to a CentOS 7 machine, can you please confirm whether the warnings are fixed?

As the warnings are triggered selectively for just more occurrences of a common pattern as opposed to all occurrences, I am trying to fix all occurrences of this pattern in order to prevent the same warnings showing up again.

Regards,
Cristian

  parent reply	other threads:[~2021-04-21 13:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11 23:23 [dpdk-dev] [PATCH 1/2] pipeline: modularize the instruction optimizer Cristian Dumitrescu
2021-04-11 23:23 ` [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args Cristian Dumitrescu
2021-04-20  0:48   ` Thomas Monjalon
2021-04-20 10:04     ` Dumitrescu, Cristian
2021-04-20 10:06       ` Thomas Monjalon
2021-04-20 10:20         ` Dumitrescu, Cristian
2021-04-20 14:48           ` Aaron Conole
2021-04-20 19:57   ` Thomas Monjalon
2021-04-21  7:49     ` Ali Alnubani
2021-04-21 12:57       ` Aaron Conole
2021-04-21 13:03         ` Ali Alnubani
2021-04-21 13:21           ` Aaron Conole
2021-04-21 13:58       ` Dumitrescu, Cristian [this message]
2021-04-21 14:24         ` Ali Alnubani
2021-04-21 15:10           ` Dumitrescu, Cristian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB27962257F240918DE54A0EB1EB479@DM6PR11MB2796.namprd11.prod.outlook.com \
    --to=cristian.dumitrescu@intel.com \
    --cc=aconole@redhat.com \
    --cc=alialnu@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git