From: "Huang, Wei" <wei.huang@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"Xu, Rosen" <rosen.xu@intel.com>,
"Zhang, Tianfei" <tianfei.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ray Kinsella <mdr@ashroe.eu>
Subject: RE: [PATCH] doc: announce some raw/ifpga API removal
Date: Fri, 1 Jul 2022 07:16:31 +0000 [thread overview]
Message-ID: <DM6PR11MB3530E8CC09407C702A8B03B5EFBD9@DM6PR11MB3530.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8xMG5LFRHT1k_yscoAF7fnoNOW_qayECshjXuE3rYm0FA@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Friday, July 1, 2022 15:01
> To: Huang, Wei <wei.huang@intel.com>; Xu, Rosen <rosen.xu@intel.com>;
> Zhang, Tianfei <tianfei.zhang@intel.com>
> Cc: dev@dpdk.org; Ray Kinsella <mdr@ashroe.eu>
> Subject: Re: [PATCH] doc: announce some raw/ifpga API removal
>
> On Fri, Jul 1, 2022 at 8:25 AM Huang, Wei <wei.huang@intel.com> wrote:
> > > >
> > > > rte_pmd_ifpga_get_pci_bus() documentation is vague and it is
> > > > unclear what could be done with it.
> > > > On the other hand, EAL provides a standard API to retrieve a bus
> > > > object by name.
> > > >
> > Agree, this API is used in an external application, I can use
> rte_get_bus_by_name() to replace it.
>
> What is the PCI bus used for, in this application?
>
In this application, target PCI device is Intel FPGA, it supports some special operation like removing it from PCI bus and rescanning it back from PCI bus,
So there are two things need to be done directly on rte_pci_bus:
1. Rescan PCI bus
pci_bus->bus.scan()
2. Get pci_dev by specified PCI address, and remove it
TAILQ_FOREACH(pci_dev, &pci_bus->device_list, next) {
if (!rte_pci_addr_cmp(&pci_dev->addr, &addr))
return pci_dev;
}
....
pci_drv = pci_dev->driver;
pci_drv->remove(pci_dev);
>
> > I will submit a patch to remove rte_pmd_ifpga_get_pci_bus() after DPDK22.07
> is released.
>
> I sent a patch a few days ago:
> https://patches.dpdk.org/project/dpdk/patch/20220628144643.1213026-3-
> david.marchand@redhat.com/
>
>
> --
> David Marchand
next prev parent reply other threads:[~2022-07-01 7:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-30 9:41 David Marchand
2022-07-01 6:15 ` Xu, Rosen
2022-07-01 6:25 ` Huang, Wei
2022-07-01 7:00 ` David Marchand
2022-07-01 7:16 ` Huang, Wei [this message]
2022-07-01 7:21 ` David Marchand
2022-07-01 8:02 ` Huang, Wei
2022-07-01 8:09 ` David Marchand
2022-07-01 8:14 ` David Marchand
2022-07-01 8:32 ` Huang, Wei
2022-07-01 8:35 ` David Marchand
2022-07-07 9:29 ` David Marchand
2022-07-07 9:34 ` Huang, Wei
2022-07-12 14:24 ` Thomas Monjalon
2022-07-12 15:33 ` Maxime Coquelin
2022-07-16 16:56 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3530E8CC09407C702A8B03B5EFBD9@DM6PR11MB3530.namprd11.prod.outlook.com \
--to=wei.huang@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=rosen.xu@intel.com \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).