Re: [dpdk-dev] [dpdk-stable] [PATCH v12 3/4] raw/ifpga: add fpga helper function

["Huang, Wei" <wei.huang@intel.com>]

Hi,

-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com> 
Sent: Thursday, January 28, 2021 21:30
To: Huang, Wei <wei.huang@intel.com>; dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>
Subject: Re: [dpdk-stable] [PATCH v12 3/4] raw/ifpga: add fpga helper function

On 1/26/2021 6:45 AM, Wei Huang wrote:
> Below helper functions are used to implement OPAE application.
> 1. ifpga_rawdev_lock() and ifpga_rawdev_unlock() protect FPGA access 
> in multiproces.

Why driver needs to expose the lock APIs to the application?

Can't application use its own locking mechanism for multiprocess, and driver can use its own locking for its needs.
Driver exposing locking internals to applications doesn't look right, but I don't know the full usecase.
I agree, these two lock APIs will be used only in rte_pmd_ifpga.c in next patch, application cannot see them.

> 2. ifpga_rawdev_get_rsu_stat() and ifpga_rawdev_set_rsu_stat() record 
> current RSU status and progress.
> 3. ifpga_rawdev_get_phy_info() get information of connected retimer.
> 4. ifpga_rawdev_partial_reconfigure() do partial reconfiguration.
> 5. ifpga_rawdev_cleanup() free software resources allocated for driver.
> 
> Signed-off-by: Wei Huang <wei.huang@intel.com>
> Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
> Acked-by: Rosen Xu <rosen.xu@intel.com>

<...>