DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Huang, Wei" <wei.huang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>, "Xu, Rosen" <rosen.xu@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	"Zhang, Tianfei" <tianfei.zhang@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v12 3/4] raw/ifpga: add fpga helper function
Date: Fri, 29 Jan 2021 07:42:22 +0000
Message-ID: <DM6PR11MB3530F3A3092713301E7EF4A0EFB99@DM6PR11MB3530.namprd11.prod.outlook.com> (raw)
In-Reply-To: <48942425-fab3-9357-5ff3-6c06b80f8062@intel.com>

Hi,

-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com> 
Sent: Thursday, January 28, 2021 21:30
To: Huang, Wei <wei.huang@intel.com>; dev@dpdk.org; Xu, Rosen <rosen.xu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
Cc: stable@dpdk.org; Zhang, Tianfei <tianfei.zhang@intel.com>
Subject: Re: [dpdk-stable] [PATCH v12 3/4] raw/ifpga: add fpga helper function

On 1/26/2021 6:45 AM, Wei Huang wrote:
> Below helper functions are used to implement OPAE application.
> 1. ifpga_rawdev_lock() and ifpga_rawdev_unlock() protect FPGA access 
> in multiproces.

Why driver needs to expose the lock APIs to the application?

Can't application use its own locking mechanism for multiprocess, and driver can use its own locking for its needs.
Driver exposing locking internals to applications doesn't look right, but I don't know the full usecase.
I agree, these two lock APIs will be used only in rte_pmd_ifpga.c in next patch, application cannot see them.

> 2. ifpga_rawdev_get_rsu_stat() and ifpga_rawdev_set_rsu_stat() record 
> current RSU status and progress.
> 3. ifpga_rawdev_get_phy_info() get information of connected retimer.
> 4. ifpga_rawdev_partial_reconfigure() do partial reconfiguration.
> 5. ifpga_rawdev_cleanup() free software resources allocated for driver.
> 
> Signed-off-by: Wei Huang <wei.huang@intel.com>
> Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
> Acked-by: Rosen Xu <rosen.xu@intel.com>

<...>

  reply	other threads:[~2021-01-29  7:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26  6:45 [dpdk-dev] [PATCH v12 0/4] raw/ifpga: add extra OPAE APIs Wei Huang
2021-01-26  6:45 ` [dpdk-dev] [PATCH v12 1/4] raw/ifpga: add fpga rsu function Wei Huang
2021-01-28 13:24   ` Ferruh Yigit
2021-01-29  7:38     ` Huang, Wei
2021-01-29  8:59       ` Ferruh Yigit
2021-01-26  6:45 ` [dpdk-dev] [PATCH v12 2/4] raw/ifpga: add fpga property get function Wei Huang
2021-01-26  6:45 ` [dpdk-dev] [PATCH v12 3/4] raw/ifpga: add fpga helper function Wei Huang
2021-01-28 13:30   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2021-01-29  7:42     ` Huang, Wei [this message]
2021-01-26  6:45 ` [dpdk-dev] [PATCH v12 4/4] examples/ifpga: add example for ifpga opae API Wei Huang
2021-01-28 13:34   ` Ferruh Yigit
2021-01-29  7:44     ` Huang, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB3530F3A3092713301E7EF4A0EFB99@DM6PR11MB3530.namprd11.prod.outlook.com \
    --to=wei.huang@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=rosen.xu@intel.com \
    --cc=stable@dpdk.org \
    --cc=tianfei.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git