From: Raslan Darawsheh <rasland@nvidia.com>
To: Jack Min <jackmin@nvidia.com>, Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Jack Min <jackmin@nvidia.com>, Ori Kam <orika@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix redundant flow after RSS expansion
Date: Sun, 11 Apr 2021 09:04:38 +0000 [thread overview]
Message-ID: <DM6PR12MB27480AAE6094C3A17A334A13CF719@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <d081a6fa197cfd508778f2ff0cc9665241a09f3e.1617111457.git.jackmin@nvidia.com>
Hi,
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xiaoyu Min
> Sent: Tuesday, March 30, 2021 4:41 PM
> To: Matan Azrad <matan@nvidia.com>; Shahaf Shuler
> <shahafs@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Jack Min
> <jackmin@nvidia.com>; Ori Kam <orika@nvidia.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix redundant flow after RSS
> expansion
>
> When RSS expand, if there is no expansion happened but completion
> happened
> because user only input next protocol field instead of item
> i.e, ether type == 0x8100 instead of VLAN, an extra flow is created with
> missing item in order to filter traffic strictly.
>
> However, after [1] and [2] the rte_flow_item_eth itself is enough to
> filter out VLAN traffic, the VLAN item is not needed.
>
> This redundant flow will cause faiure in some scenarios on group 0 due
> to they are the same FTE.
>
> Fixes: fc2dd8dd492f ("ethdev: fix expand RSS flows")
> Cc: stable@dpdk.org
>
> [1]:
> commit 09315fc83861 ("ethdev: add VLAN attributes to ethernet and
> VLAN items")
>
> [2]:
> commit 86b59a1af671 ("net/mlx5: support VLAN matching fields")
>
> Signed-off-by: Xiaoyu Min <jackmin@nvidia.com>
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2021-04-11 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 13:40 Xiaoyu Min
2021-04-08 9:23 ` Matan Azrad
2021-04-11 9:04 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB27480AAE6094C3A17A334A13CF719@DM6PR12MB2748.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=jackmin@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).