From: Raslan Darawsheh <rasland@nvidia.com>
To: Gregory Etelson <getelson@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Matan Azrad <matan@nvidia.com>,
"Slava Ovsiienko" <viacheslavo@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix restore info in non-tunnel traffic.
Date: Thu, 19 Nov 2020 10:53:13 +0000 [thread overview]
Message-ID: <DM6PR12MB27483951A8EB958BD6CEB0EBCFE00@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201118182359.4883-1-getelson@nvidia.com>
Hi,
> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Wednesday, November 18, 2020 8:24 PM
> To: Gregory Etelson <getelson@nvidia.com>
> Cc: dev@dpdk.org; Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Shahaf
> Shuler <shahafs@nvidia.com>
> Subject: [PATCH] net/mlx5: fix restore info in non-tunnel traffic.
>
> Tunnel offload API provides applications with ability to restore
> packet outer headers after partial offload. Exact feature execution
> depends on hardware abilities and PMD implementation. Hardware that is
> supported by MLX5 PMD places a mark on a packet after partial offload.
> PMD decodes that mark and provides application with required
> information.
> Application can call the restore API for packets that are part of
> offloaded tunnel and not. It's up to a PMD to provide correct
> information.
> Current MLX5 tunnel offload implementation does not allow applications
> to use flow MARK actions. It is restricted to tunnel offload use only.
> This fault was triggered by application that did not activate tunnel
> offload and called the restore API with a marked packet. The PMD tried
> to decode the mark value and crashed. The patch decodes mark value
> only if tunnel offload is active.
>
> Fixes: 4ec6360de37d ("net/mlx5: implement tunnel offload")
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
> drivers/net/mlx5/mlx5_flow.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-11-19 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 18:23 Gregory Etelson
2020-11-19 10:53 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB27483951A8EB958BD6CEB0EBCFE00@DM6PR12MB2748.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).