Re: [dpdk-dev] [PATCH v3] net/mlx5: fix header reformat action hash key

[Raslan Darawsheh <rasland@nvidia.com>]

Hi,

> -----Original Message-----
> From: Suanming Mou <suanmingm@nvidia.com>
> Sent: Wednesday, November 18, 2020 4:20 AM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>
> Subject: [PATCH v3] net/mlx5: fix header reformat action hash key
> 
> Currently, header reformat action uses the hash list 32-bit key generated
> in header reformat register function directly. The key will not be
> recalculated in the hash list function.
> 
> As the 64-bit key is composed of the 32-bit attributes and 32-bit reformat
> buffer csum, the hash list function only gets 32-bit key directly will take
> the attribute part only, csum part will be ignored. For different header
> reformat actions, the attributes can be the same, while the buffer will
> be different. Only take the attribute part causes lots of the conflicts.
> 
> This commits adds the attribute part and the significant different csum
> part for the key.
> 
> Fixes: f961fd490fd4 ("net/mlx5: make header reformat action thread safe")
> 
> Signed-off-by: Suanming Mou <suanmingm@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
> 
> v3:
>  - add the missing ack.
> 
> v2:
>  - update key generate.
> 
> ---
>  drivers/net/mlx5/mlx5_flow.h    | 12 ------------
>  drivers/net/mlx5/mlx5_flow_dv.c | 31 ++++++++++++++++++++++++-------
>  2 files changed, 24 insertions(+), 19 deletions(-)
> 

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh