DPDK patches and discussions
 help / color / mirror / Atom feed
From: Raslan Darawsheh <rasland@nvidia.com>
To: Alexander Kozyrev <akozyrev@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Slava Ovsiienko <viacheslavo@nvidia.com>, Matan Azrad <matan@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix memory allocation debug stats
Date: Wed, 28 Oct 2020 20:44:15 +0000
Message-ID: <DM6PR12MB2748F816D1FC26504783BAE3CF170@DM6PR12MB2748.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20201028182100.12312-1-akozyrev@nvidia.com>

Hi,


> -----Original Message-----
> From: Alexander Kozyrev <akozyrev@nvidia.com>
> Sent: Wednesday, October 28, 2020 8:21 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>
> Subject: [PATCH] common/mlx5: fix memory allocation debug stats
> 
> Fix compilation issue for memory allocation stats in case of the
> RTE_LIBRTE_MLX5_DEBUG is enabled. The mlx5_sys_mem is static and
> its members should be accessed via member operator, not a pointer.
> 
> Fixes: 1f34e138f8 ("common/mlx5: use C11 atomics for memory allocation")
> 
> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
> ---
>  drivers/common/mlx5/mlx5_malloc.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/common/mlx5/mlx5_malloc.c
> b/drivers/common/mlx5/mlx5_malloc.c
> index f64c15fceb..5a3267f730 100644
> --- a/drivers/common/mlx5/mlx5_malloc.c
> +++ b/drivers/common/mlx5/mlx5_malloc.c
> @@ -187,7 +187,7 @@ mlx5_malloc(uint32_t flags, size_t size, unsigned int
> align, int socket)
>  		mlx5_mem_update_msl(addr);
>  #ifdef RTE_LIBRTE_MLX5_DEBUG
>  		if (addr)
> -			__atomic_add_fetch(&mlx5_sys_mem->malloc_rte,
> 1,
> +			__atomic_add_fetch(&mlx5_sys_mem.malloc_rte, 1,
>  					   __ATOMIC_RELAXED);
>  #endif
>  		return addr;
> @@ -201,7 +201,7 @@ mlx5_malloc(uint32_t flags, size_t size, unsigned int
> align, int socket)
>  		addr = malloc(size);
>  #ifdef RTE_LIBRTE_MLX5_DEBUG
>  	if (addr)
> -		__atomic_add_fetch(&mlx5_sys_mem->malloc_sys, 1,
> +		__atomic_add_fetch(&mlx5_sys_mem.malloc_sys, 1,
>  				   __ATOMIC_RELAXED);
>  #endif
>  	return addr;
> @@ -235,7 +235,7 @@ mlx5_realloc(void *addr, uint32_t flags, size_t size,
> unsigned int align,
>  		mlx5_mem_update_msl(new_addr);
>  #ifdef RTE_LIBRTE_MLX5_DEBUG
>  		if (new_addr)
> -			__atomic_add_fetch(&mlx5_sys_mem->realloc_rte,
> 1,
> +			__atomic_add_fetch(&mlx5_sys_mem.realloc_rte,
> 1,
>  					   __ATOMIC_RELAXED);
>  #endif
>  		return new_addr;
> @@ -248,7 +248,7 @@ mlx5_realloc(void *addr, uint32_t flags, size_t size,
> unsigned int align,
>  	new_addr = realloc(addr, size);
>  #ifdef RTE_LIBRTE_MLX5_DEBUG
>  	if (new_addr)
> -		__atomic_add_fetch(&mlx5_sys_mem->realloc_sys, 1,
> +		__atomic_add_fetch(&mlx5_sys_mem.realloc_sys, 1,
>  				   __ATOMIC_RELAXED);
>  #endif
>  	return new_addr;
> @@ -261,13 +261,13 @@ mlx5_free(void *addr)
>  		return;
>  	if (!mlx5_mem_is_rte(addr)) {
>  #ifdef RTE_LIBRTE_MLX5_DEBUG
> -		__atomic_add_fetch(&mlx5_sys_mem->free_sys, 1,
> +		__atomic_add_fetch(&mlx5_sys_mem.free_sys, 1,
>  				   __ATOMIC_RELAXED);
>  #endif
>  		free(addr);
>  	} else {
>  #ifdef RTE_LIBRTE_MLX5_DEBUG
> -		__atomic_add_fetch(&mlx5_sys_mem->free_rte, 1,
> +		__atomic_add_fetch(&mlx5_sys_mem.free_rte, 1,
>  				   __ATOMIC_RELAXED);
>  #endif
>  		rte_free(addr);
> --
> 2.24.1

Patch squashed into relevant commit in next-net-mlx,

Kindest regards,
Raslan Darawsheh 

      reply	other threads:[~2020-10-28 20:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 18:21 Alexander Kozyrev
2020-10-28 20:44 ` Raslan Darawsheh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR12MB2748F816D1FC26504783BAE3CF170@DM6PR12MB2748.namprd12.prod.outlook.com \
    --to=rasland@nvidia.com \
    --cc=akozyrev@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git