From: Elena Agostini <eagostini@nvidia.com>
To: David Marchand <david.marchand@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Levend Sayar <levendsayar@gmail.com>,
Aaron Conole <aconole@redhat.com>,
"romein@astron.nl" <romein@astron.nl>
Subject: Re: [PATCH] gpu/cuda: fix getenv related build error
Date: Thu, 5 Oct 2023 12:42:48 +0000 [thread overview]
Message-ID: <DM6PR12MB4107442F7CCE3354096D3FF6CDCAA@DM6PR12MB4107.namprd12.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8yttRiv8CGZy7oCOm3o3OcEXvUofdhN3u1fy6hfuUr93Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1090 bytes --]
Sounds good to me
Thanks
EA
From: David Marchand <david.marchand@redhat.com>
Date: Friday, 29 September 2023 at 17:00
To: Elena Agostini <eagostini@nvidia.com>
Cc: dev@dpdk.org <dev@dpdk.org>, Levend Sayar <levendsayar@gmail.com>, Aaron Conole <aconole@redhat.com>, romein@astron.nl <romein@astron.nl>
Subject: Re: [PATCH] gpu/cuda: fix getenv related build error
External email: Use caution opening links or attachments
On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar <levendsayar@gmail.com> wrote:
>
> If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1.
> This causes gdrcopy.c build to give an error;
> because compiler can not find signature of getenv.
> stdlib.h is included for the definition of getenv function.
>
There was a bug report for this issue:
Bugzilla ID: 1133
> Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameters")
It is probably worth backporting:
Cc: stable@dpdk.org
>
> Signed-off-by: Levend Sayar <levendsayar@gmail.com>
Elena, this is a quick one, review please.
--
David Marchand
[-- Attachment #2: Type: text/html, Size: 3697 bytes --]
next prev parent reply other threads:[~2023-10-05 12:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 16:25 Levend Sayar
2023-09-29 15:00 ` David Marchand
2023-10-05 12:42 ` Elena Agostini [this message]
2023-10-06 10:07 ` David Marchand
2023-10-06 19:45 ` Levend Sayar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR12MB4107442F7CCE3354096D3FF6CDCAA@DM6PR12MB4107.namprd12.prod.outlook.com \
--to=eagostini@nvidia.com \
--cc=aconole@redhat.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=levendsayar@gmail.com \
--cc=romein@astron.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).