From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] checkpatch script
Date: Tue, 25 Nov 2014 14:48:49 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8972685C3EF@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1958676.MmbbGzbMYp@xps13>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Tuesday, November 25, 2014 2:29 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] checkpatch script
>
> Hi Pablo,
>
> 2014-11-25 13:11, De Lara Guarch, Pablo:
> > Hi Thomas,
> >
> > As we have seen the issues we have had on previous patches due to
> > checkpatch,
>
> No we have no issues because of checkpatch ;)
> It helps us to see some obvious errors.
I agree. With issues, I meant just confusion between using one version of checkpatch or another
(mind that you are using script from 3.18-rc6, the very latest one), so it was good that you mentioned the version before :)
>
> > would it be possible to include the up-to-date script in the
> > repo? I have realized that people either do not check their patches or check
> > them with an old version that do not catch some errors that the latest one
> > does, so I think this is a problem.
>
> The real problem is to clearly define all the coding rules and adapt
> checkpatch to our needs.
Agree 100%.
>
> > Plus, I think it would be a good idea to mention it in dpdk.org/dev, as this
> > is clearly a requirement for merging patches.
>
> Please, let's close DPDK 1.8 first.
> Then we'll have to write some documents and tools to make them approved
> after necessary discussions/debates.
OK. We will discuss it for 2.0. Thanks Thomas!
>
> --
> Thomas
prev parent reply other threads:[~2014-11-25 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-25 13:11 De Lara Guarch, Pablo
2014-11-25 14:28 ` Thomas Monjalon
2014-11-25 14:48 ` De Lara Guarch, Pablo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8972685C3EF@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).