From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
"Griffin, John" <john.griffin@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 3/3] qat: fixes premature addition of AES_CMAC in session creation
Date: Fri, 11 Mar 2016 00:24:30 +0000 [thread overview]
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8973C8C8537@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <2207806.zJzxy8f5VI@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Friday, March 11, 2016 12:17 AM
> To: Griffin, John
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: Re: [dpdk-dev] [PATCH 3/3] qat: fixes premature addition of
> AES_CMAC in session creation
>
> 2016-03-08 16:22, John Griffin:
> > Remove support for AES CMAC support for which was added to
> > the code in error. AES CMAC will be added in a subsequent release
> > when testing completes.
> [...]
> > case RTE_CRYPTO_AUTH_AES_GCM:
> > - case RTE_CRYPTO_AUTH_AES_GMAC:
>
> CMAC or GMAC?
It is AES_GMAC, I commented that title was wrong.
>
> > session->qat_hash_alg =
> ICP_QAT_HW_AUTH_ALGO_GALOIS_128;
> > break;
> > case RTE_CRYPTO_AUTH_SNOW3G_UIA2:
> > @@ -312,6 +311,7 @@ qat_crypto_sym_configure_session_auth(struct
> rte_cryptodev *dev,
> > case RTE_CRYPTO_AUTH_MD5:
> > case RTE_CRYPTO_AUTH_MD5_HMAC:
> > case RTE_CRYPTO_AUTH_AES_CCM:
> > + case RTE_CRYPTO_AUTH_AES_GMAC:
>
> So it is added? What should we have later?
next prev parent reply other threads:[~2016-03-11 0:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 16:22 [dpdk-dev] [PATCH 0/3] AES GCM, AES CMAC fixes and addition of GCM tests for QAT John Griffin
2016-03-08 16:22 ` [dpdk-dev] [PATCH 1/3] qat: fix AES GCM decryption John Griffin
2016-03-08 16:22 ` [dpdk-dev] [PATCH 2/3] app/test: add AES GCM tests for QAT John Griffin
2016-03-08 16:22 ` [dpdk-dev] [PATCH 3/3] qat: fixes premature addition of AES_CMAC in session creation John Griffin
2016-03-11 0:16 ` Thomas Monjalon
2016-03-11 0:24 ` De Lara Guarch, Pablo [this message]
2016-03-11 11:01 ` John Griffin
2016-03-10 17:28 ` [dpdk-dev] [PATCH 0/3] AES GCM, AES CMAC fixes and addition of GCM tests for QAT De Lara Guarch, Pablo
2016-03-11 0:33 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E115CCD9D858EF4F90C690B0DCB4D8973C8C8537@IRSMSX108.ger.corp.intel.com \
--to=pablo.de.lara.guarch@intel.com \
--cc=dev@dpdk.org \
--cc=john.griffin@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).