* [dpdk-dev] [PATCH 0/3] HMAC supported key size fixes
@ 2017-07-25 5:24 Pablo de Lara
2017-07-25 5:24 ` [dpdk-dev] [PATCH 1/3] crypto/aesni_mb: fix HMAC supported key sizes Pablo de Lara
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: Pablo de Lara @ 2017-07-25 5:24 UTC (permalink / raw)
To: zbigniew.bodek, jerin.jacob, akhil.goyal, hemant.agrawal,
fiona.trahe, deepak.k.jain, john.griffin, declan.doherty
Cc: dev, Pablo de Lara
For HMAC algorithms (SHAx/MD5), the capabilities were not
correct, as they were just a fixed value (block size).
Instead, the authentication key size for these algorithms
can go between 1 and the block size.
Note that these patches are fixing AESNI-MB, OpenSSL and QAT PMDs,
but DPAA2 and ARMv8 crypto PMDs might need these fixes too.
Pablo de Lara (3):
crypto/aesni_mb: fix HMAC supported key sizes
crypto/openssl: fix HMAC supported key sizes
crypto/qat: fix HMAC supported key sizes
drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 24 ++++++++++++------------
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 24 ++++++++++++------------
drivers/crypto/qat/qat_crypto_capabilities.h | 24 ++++++++++++------------
3 files changed, 36 insertions(+), 36 deletions(-)
--
2.9.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH 1/3] crypto/aesni_mb: fix HMAC supported key sizes
2017-07-25 5:24 [dpdk-dev] [PATCH 0/3] HMAC supported key size fixes Pablo de Lara
@ 2017-07-25 5:24 ` Pablo de Lara
2017-07-27 10:22 ` Declan Doherty
2017-07-25 5:24 ` [dpdk-dev] [PATCH 2/3] crypto/openssl: " Pablo de Lara
` (3 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Pablo de Lara @ 2017-07-25 5:24 UTC (permalink / raw)
To: zbigniew.bodek, jerin.jacob, akhil.goyal, hemant.agrawal,
fiona.trahe, deepak.k.jain, john.griffin, declan.doherty
Cc: dev, Pablo de Lara, stable
For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
key sizes are not a fixed value, but a range between
1 and the block size.
Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery")
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
index 06d8dfe..692b354 100644
--- a/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
+++ b/drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c
@@ -48,9 +48,9 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_MD5_HMAC,
.block_size = 64,
.key_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 12,
@@ -69,9 +69,9 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA1_HMAC,
.block_size = 64,
.key_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 12,
@@ -90,9 +90,9 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
.block_size = 64,
.key_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 14,
@@ -111,9 +111,9 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA256_HMAC,
.block_size = 64,
.key_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 16,
@@ -132,9 +132,9 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA384_HMAC,
.block_size = 128,
.key_size = {
- .min = 128,
+ .min = 1,
.max = 128,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 24,
@@ -153,9 +153,9 @@ static const struct rte_cryptodev_capabilities aesni_mb_pmd_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA512_HMAC,
.block_size = 128,
.key_size = {
- .min = 128,
+ .min = 1,
.max = 128,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 32,
--
2.9.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH 2/3] crypto/openssl: fix HMAC supported key sizes
2017-07-25 5:24 [dpdk-dev] [PATCH 0/3] HMAC supported key size fixes Pablo de Lara
2017-07-25 5:24 ` [dpdk-dev] [PATCH 1/3] crypto/aesni_mb: fix HMAC supported key sizes Pablo de Lara
@ 2017-07-25 5:24 ` Pablo de Lara
2017-07-27 10:21 ` Declan Doherty
2017-07-25 5:24 ` [dpdk-dev] [PATCH 3/3] crypto/qat: " Pablo de Lara
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: Pablo de Lara @ 2017-07-25 5:24 UTC (permalink / raw)
To: zbigniew.bodek, jerin.jacob, akhil.goyal, hemant.agrawal,
fiona.trahe, deepak.k.jain, john.griffin, declan.doherty
Cc: dev, Pablo de Lara, stable
For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
key sizes are not a fixed value, but a range between
1 and the block size.
Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/crypto/openssl/rte_openssl_pmd_ops.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd_ops.c b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
index b78542d..8cdd0b2 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd_ops.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd_ops.c
@@ -48,9 +48,9 @@ static const struct rte_cryptodev_capabilities openssl_pmd_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_MD5_HMAC,
.block_size = 64,
.key_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 16,
@@ -90,9 +90,9 @@ static const struct rte_cryptodev_capabilities openssl_pmd_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA1_HMAC,
.block_size = 64,
.key_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 20,
@@ -132,9 +132,9 @@ static const struct rte_cryptodev_capabilities openssl_pmd_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
.block_size = 64,
.key_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 28,
@@ -174,9 +174,9 @@ static const struct rte_cryptodev_capabilities openssl_pmd_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA256_HMAC,
.block_size = 64,
.key_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 32,
@@ -216,9 +216,9 @@ static const struct rte_cryptodev_capabilities openssl_pmd_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA384_HMAC,
.block_size = 128,
.key_size = {
- .min = 128,
+ .min = 1,
.max = 128,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 48,
@@ -258,9 +258,9 @@ static const struct rte_cryptodev_capabilities openssl_pmd_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA512_HMAC,
.block_size = 128,
.key_size = {
- .min = 128,
+ .min = 1,
.max = 128,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 64,
--
2.9.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH 3/3] crypto/qat: fix HMAC supported key sizes
2017-07-25 5:24 [dpdk-dev] [PATCH 0/3] HMAC supported key size fixes Pablo de Lara
2017-07-25 5:24 ` [dpdk-dev] [PATCH 1/3] crypto/aesni_mb: fix HMAC supported key sizes Pablo de Lara
2017-07-25 5:24 ` [dpdk-dev] [PATCH 2/3] crypto/openssl: " Pablo de Lara
@ 2017-07-25 5:24 ` Pablo de Lara
2017-07-27 9:54 ` Trahe, Fiona
2017-07-27 11:54 ` [dpdk-dev] [PATCH] crypto/dpaa2_sec: " Akhil Goyal
2017-07-27 14:40 ` [dpdk-dev] [PATCH 0/3] HMAC supported key size fixes De Lara Guarch, Pablo
4 siblings, 1 reply; 11+ messages in thread
From: Pablo de Lara @ 2017-07-25 5:24 UTC (permalink / raw)
To: zbigniew.bodek, jerin.jacob, akhil.goyal, hemant.agrawal,
fiona.trahe, deepak.k.jain, john.griffin, declan.doherty
Cc: dev, Pablo de Lara, stable
For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
key sizes are not a fixed value, but a range between
1 and the block size.
Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery")
Cc: stable@dpdk.org
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
drivers/crypto/qat/qat_crypto_capabilities.h | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/crypto/qat/qat_crypto_capabilities.h b/drivers/crypto/qat/qat_crypto_capabilities.h
index 567e1ac..07da911 100644
--- a/drivers/crypto/qat/qat_crypto_capabilities.h
+++ b/drivers/crypto/qat/qat_crypto_capabilities.h
@@ -43,9 +43,9 @@
.algo = RTE_CRYPTO_AUTH_SHA1_HMAC, \
.block_size = 64, \
.key_size = { \
- .min = 64, \
+ .min = 1, \
.max = 64, \
- .increment = 0 \
+ .increment = 1 \
}, \
.digest_size = { \
.min = 20, \
@@ -64,9 +64,9 @@
.algo = RTE_CRYPTO_AUTH_SHA224_HMAC, \
.block_size = 64, \
.key_size = { \
- .min = 64, \
+ .min = 1, \
.max = 64, \
- .increment = 0 \
+ .increment = 1 \
}, \
.digest_size = { \
.min = 28, \
@@ -85,9 +85,9 @@
.algo = RTE_CRYPTO_AUTH_SHA256_HMAC, \
.block_size = 64, \
.key_size = { \
- .min = 64, \
+ .min = 1, \
.max = 64, \
- .increment = 0 \
+ .increment = 1 \
}, \
.digest_size = { \
.min = 32, \
@@ -106,9 +106,9 @@
.algo = RTE_CRYPTO_AUTH_SHA384_HMAC, \
.block_size = 64, \
.key_size = { \
- .min = 128, \
+ .min = 1, \
.max = 128, \
- .increment = 0 \
+ .increment = 1 \
}, \
.digest_size = { \
.min = 48, \
@@ -127,9 +127,9 @@
.algo = RTE_CRYPTO_AUTH_SHA512_HMAC, \
.block_size = 128, \
.key_size = { \
- .min = 128, \
+ .min = 1, \
.max = 128, \
- .increment = 0 \
+ .increment = 1 \
}, \
.digest_size = { \
.min = 64, \
@@ -148,9 +148,9 @@
.algo = RTE_CRYPTO_AUTH_MD5_HMAC, \
.block_size = 64, \
.key_size = { \
- .min = 8, \
+ .min = 1, \
.max = 64, \
- .increment = 8 \
+ .increment = 1 \
}, \
.digest_size = { \
.min = 16, \
--
2.9.4
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 3/3] crypto/qat: fix HMAC supported key sizes
2017-07-25 5:24 ` [dpdk-dev] [PATCH 3/3] crypto/qat: " Pablo de Lara
@ 2017-07-27 9:54 ` Trahe, Fiona
0 siblings, 0 replies; 11+ messages in thread
From: Trahe, Fiona @ 2017-07-27 9:54 UTC (permalink / raw)
To: De Lara Guarch, Pablo, zbigniew.bodek, jerin.jacob, akhil.goyal,
hemant.agrawal, Jain, Deepak K, Griffin, John, Doherty, Declan
Cc: dev, stable
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, July 25, 2017 6:25 AM
> To: zbigniew.bodek@caviumnetworks.com; jerin.jacob@caviumnetworks.com; akhil.goyal@nxp.com;
> hemant.agrawal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>; Griffin, John <john.griffin@intel.com>; Doherty, Declan
> <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; stable@dpdk.org
> Subject: [PATCH 3/3] crypto/qat: fix HMAC supported key sizes
>
> For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
> key sizes are not a fixed value, but a range between
> 1 and the block size.
>
> Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 2/3] crypto/openssl: fix HMAC supported key sizes
2017-07-25 5:24 ` [dpdk-dev] [PATCH 2/3] crypto/openssl: " Pablo de Lara
@ 2017-07-27 10:21 ` Declan Doherty
0 siblings, 0 replies; 11+ messages in thread
From: Declan Doherty @ 2017-07-27 10:21 UTC (permalink / raw)
To: Pablo de Lara, zbigniew.bodek, jerin.jacob, akhil.goyal,
hemant.agrawal, fiona.trahe, deepak.k.jain, john.griffin
Cc: dev, stable
On 25/07/2017 6:24 AM, Pablo de Lara wrote:
> For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
> key sizes are not a fixed value, but a range between
> 1 and the block size.
>
> Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
...
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 1/3] crypto/aesni_mb: fix HMAC supported key sizes
2017-07-25 5:24 ` [dpdk-dev] [PATCH 1/3] crypto/aesni_mb: fix HMAC supported key sizes Pablo de Lara
@ 2017-07-27 10:22 ` Declan Doherty
0 siblings, 0 replies; 11+ messages in thread
From: Declan Doherty @ 2017-07-27 10:22 UTC (permalink / raw)
To: Pablo de Lara, zbigniew.bodek, jerin.jacob, akhil.goyal,
hemant.agrawal, fiona.trahe, deepak.k.jain, john.griffin
Cc: dev, stable
On 25/07/2017 6:24 AM, Pablo de Lara wrote:
> For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
> key sizes are not a fixed value, but a range between
> 1 and the block size.
>
> Fixes: 26c2e4ad5ad4 ("cryptodev: add capabilities discovery")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
...
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix HMAC supported key sizes
2017-07-25 5:24 [dpdk-dev] [PATCH 0/3] HMAC supported key size fixes Pablo de Lara
` (2 preceding siblings ...)
2017-07-25 5:24 ` [dpdk-dev] [PATCH 3/3] crypto/qat: " Pablo de Lara
@ 2017-07-27 11:54 ` Akhil Goyal
2017-07-27 13:57 ` Hemant Agrawal
2017-07-27 14:40 ` [dpdk-dev] [PATCH 0/3] HMAC supported key size fixes De Lara Guarch, Pablo
4 siblings, 1 reply; 11+ messages in thread
From: Akhil Goyal @ 2017-07-27 11:54 UTC (permalink / raw)
To: dev; +Cc: pablo.de.lara.guarch, hemant.agrawal, Akhil Goyal, stable
For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
key sizes are not a fixed value, but a range between
1 and the block size.
Fixes: 623326dded3a ("crypto/dpaa2_sec: introduce poll mode driver")
Cc: stable@dpdk.org
Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
index e104f71..3849a05 100644
--- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
+++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
@@ -200,9 +200,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_MD5_HMAC,
.block_size = 64,
.key_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 16,
@@ -221,9 +221,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA1_HMAC,
.block_size = 64,
.key_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 20,
@@ -242,9 +242,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
.block_size = 64,
.key_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 28,
@@ -263,9 +263,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA256_HMAC,
.block_size = 64,
.key_size = {
- .min = 64,
+ .min = 1,
.max = 64,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 32,
@@ -284,9 +284,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA384_HMAC,
.block_size = 128,
.key_size = {
- .min = 128,
+ .min = 1,
.max = 128,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 48,
@@ -305,9 +305,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
.algo = RTE_CRYPTO_AUTH_SHA512_HMAC,
.block_size = 128,
.key_size = {
- .min = 128,
+ .min = 1,
.max = 128,
- .increment = 0
+ .increment = 1
},
.digest_size = {
.min = 64,
--
2.9.3
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix HMAC supported key sizes
2017-07-27 11:54 ` [dpdk-dev] [PATCH] crypto/dpaa2_sec: " Akhil Goyal
@ 2017-07-27 13:57 ` Hemant Agrawal
2017-07-27 14:25 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 11+ messages in thread
From: Hemant Agrawal @ 2017-07-27 13:57 UTC (permalink / raw)
To: Akhil Goyal, dev; +Cc: pablo.de.lara.guarch, stable
On 7/27/2017 5:24 PM, Akhil Goyal wrote:
> For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported
> key sizes are not a fixed value, but a range between
> 1 and the block size.
>
> Fixes: 623326dded3a ("crypto/dpaa2_sec: introduce poll mode driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
> drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> index e104f71..3849a05 100644
> --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h
> @@ -200,9 +200,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
> .algo = RTE_CRYPTO_AUTH_MD5_HMAC,
> .block_size = 64,
> .key_size = {
> - .min = 64,
> + .min = 1,
> .max = 64,
> - .increment = 0
> + .increment = 1
> },
> .digest_size = {
> .min = 16,
> @@ -221,9 +221,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
> .algo = RTE_CRYPTO_AUTH_SHA1_HMAC,
> .block_size = 64,
> .key_size = {
> - .min = 64,
> + .min = 1,
> .max = 64,
> - .increment = 0
> + .increment = 1
> },
> .digest_size = {
> .min = 20,
> @@ -242,9 +242,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
> .algo = RTE_CRYPTO_AUTH_SHA224_HMAC,
> .block_size = 64,
> .key_size = {
> - .min = 64,
> + .min = 1,
> .max = 64,
> - .increment = 0
> + .increment = 1
> },
> .digest_size = {
> .min = 28,
> @@ -263,9 +263,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
> .algo = RTE_CRYPTO_AUTH_SHA256_HMAC,
> .block_size = 64,
> .key_size = {
> - .min = 64,
> + .min = 1,
> .max = 64,
> - .increment = 0
> + .increment = 1
> },
> .digest_size = {
> .min = 32,
> @@ -284,9 +284,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
> .algo = RTE_CRYPTO_AUTH_SHA384_HMAC,
> .block_size = 128,
> .key_size = {
> - .min = 128,
> + .min = 1,
> .max = 128,
> - .increment = 0
> + .increment = 1
> },
> .digest_size = {
> .min = 48,
> @@ -305,9 +305,9 @@ static const struct rte_cryptodev_capabilities dpaa2_sec_capabilities[] = {
> .algo = RTE_CRYPTO_AUTH_SHA512_HMAC,
> .block_size = 128,
> .key_size = {
> - .min = 128,
> + .min = 1,
> .max = 128,
> - .increment = 0
> + .increment = 1
> },
> .digest_size = {
> .min = 64,
>
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH] crypto/dpaa2_sec: fix HMAC supported key sizes
2017-07-27 13:57 ` Hemant Agrawal
@ 2017-07-27 14:25 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 11+ messages in thread
From: De Lara Guarch, Pablo @ 2017-07-27 14:25 UTC (permalink / raw)
To: Hemant Agrawal, Akhil Goyal, dev; +Cc: stable
> -----Original Message-----
> From: Hemant Agrawal [mailto:hemant.agrawal@nxp.com]
> Sent: Thursday, July 27, 2017 2:58 PM
> To: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org
> Subject: Re: [PATCH] crypto/dpaa2_sec: fix HMAC supported key sizes
>
> On 7/27/2017 5:24 PM, Akhil Goyal wrote:
> > For HMAC algorithms (MD5-HMAC, SHAx-HMAC), the supported key sizes
> are
> > not a fixed value, but a range between
> > 1 and the block size.
> >
> > Fixes: 623326dded3a ("crypto/dpaa2_sec: introduce poll mode driver")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
...
> >
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
Applied to dpdk-next-crypto.
Thanks,
Pablo
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH 0/3] HMAC supported key size fixes
2017-07-25 5:24 [dpdk-dev] [PATCH 0/3] HMAC supported key size fixes Pablo de Lara
` (3 preceding siblings ...)
2017-07-27 11:54 ` [dpdk-dev] [PATCH] crypto/dpaa2_sec: " Akhil Goyal
@ 2017-07-27 14:40 ` De Lara Guarch, Pablo
4 siblings, 0 replies; 11+ messages in thread
From: De Lara Guarch, Pablo @ 2017-07-27 14:40 UTC (permalink / raw)
To: zbigniew.bodek, jerin.jacob, akhil.goyal, hemant.agrawal, Trahe,
Fiona, Jain, Deepak K, Griffin, John, Doherty, Declan
Cc: dev
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Tuesday, July 25, 2017 6:25 AM
> To: zbigniew.bodek@caviumnetworks.com;
> jerin.jacob@caviumnetworks.com; akhil.goyal@nxp.com;
> hemant.agrawal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Jain,
> Deepak K <deepak.k.jain@intel.com>; Griffin, John
> <john.griffin@intel.com>; Doherty, Declan <declan.doherty@intel.com>
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>
> Subject: [PATCH 0/3] HMAC supported key size fixes
>
> For HMAC algorithms (SHAx/MD5), the capabilities were not correct, as
> they were just a fixed value (block size).
> Instead, the authentication key size for these algorithms can go between 1
> and the block size.
>
> Note that these patches are fixing AESNI-MB, OpenSSL and QAT PMDs, but
> DPAA2 and ARMv8 crypto PMDs might need these fixes too.
>
> Pablo de Lara (3):
> crypto/aesni_mb: fix HMAC supported key sizes
> crypto/openssl: fix HMAC supported key sizes
> crypto/qat: fix HMAC supported key sizes
>
> drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 24 ++++++++++++--
> ----------
> drivers/crypto/openssl/rte_openssl_pmd_ops.c | 24 ++++++++++++-------
> -----
> drivers/crypto/qat/qat_crypto_capabilities.h | 24 ++++++++++++-----------
> -
> 3 files changed, 36 insertions(+), 36 deletions(-)
>
> --
> 2.9.4
Applied to dpdk-next-crypto.
Pablo
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2017-07-27 14:40 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-25 5:24 [dpdk-dev] [PATCH 0/3] HMAC supported key size fixes Pablo de Lara
2017-07-25 5:24 ` [dpdk-dev] [PATCH 1/3] crypto/aesni_mb: fix HMAC supported key sizes Pablo de Lara
2017-07-27 10:22 ` Declan Doherty
2017-07-25 5:24 ` [dpdk-dev] [PATCH 2/3] crypto/openssl: " Pablo de Lara
2017-07-27 10:21 ` Declan Doherty
2017-07-25 5:24 ` [dpdk-dev] [PATCH 3/3] crypto/qat: " Pablo de Lara
2017-07-27 9:54 ` Trahe, Fiona
2017-07-27 11:54 ` [dpdk-dev] [PATCH] crypto/dpaa2_sec: " Akhil Goyal
2017-07-27 13:57 ` Hemant Agrawal
2017-07-27 14:25 ` De Lara Guarch, Pablo
2017-07-27 14:40 ` [dpdk-dev] [PATCH 0/3] HMAC supported key size fixes De Lara Guarch, Pablo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).