DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] lib/librte_cryptodev: Fix a typo: rte_cyptodev_names -> rte_cryptodev_names
@ 2017-11-10  7:56 Pavel Shirshov
  2017-11-10  8:30 ` De Lara Guarch, Pablo
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Shirshov @ 2017-11-10  7:56 UTC (permalink / raw)
  To: dev

Signed-off-by: Pavel Shirshov <pavel.shirshov@gmail.com>
---
 lib/librte_cryptodev/rte_cryptodev.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
index dade554..5b6a254 100644
--- a/lib/librte_cryptodev/rte_cryptodev.h
+++ b/lib/librte_cryptodev/rte_cryptodev.h
@@ -50,7 +50,7 @@ extern "C" {
 #include "rte_dev.h"
 #include <rte_common.h>
 
-extern const char **rte_cyptodev_names;
+extern const char **rte_cryptodev_names;
 
 /* Logging Macros */
 
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] lib/librte_cryptodev: Fix a typo: rte_cyptodev_names -> rte_cryptodev_names
  2017-11-10  7:56 [dpdk-dev] [PATCH] lib/librte_cryptodev: Fix a typo: rte_cyptodev_names -> rte_cryptodev_names Pavel Shirshov
@ 2017-11-10  8:30 ` De Lara Guarch, Pablo
  0 siblings, 0 replies; 2+ messages in thread
From: De Lara Guarch, Pablo @ 2017-11-10  8:30 UTC (permalink / raw)
  To: Pavel Shirshov, dev

Hi Pavel,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pavel Shirshov
> Sent: Friday, November 10, 2017 7:56 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] lib/librte_cryptodev: Fix a typo:
> rte_cyptodev_names -> rte_cryptodev_names
> 

Actually, this variable is not used anywhere, so it can be deleted.

By the way, for future times.
In the commit title, do not use "lib/librte...", but directly the library name.
Also, start with lowercase, and try to be as short as possible, but still meaningful.
For this case, it is not necessary to describe the typo in the title.

So, this would be: "cryptodev: fix typo"

Thanks,
Pablo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-10  8:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-10  7:56 [dpdk-dev] [PATCH] lib/librte_cryptodev: Fix a typo: rte_cyptodev_names -> rte_cryptodev_names Pavel Shirshov
2017-11-10  8:30 ` De Lara Guarch, Pablo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).