DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "yliu@fridaylinux.org" <yliu@fridaylinux.org>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/virtio: fix rxq intr config fails using vfio-pci
Date: Thu, 9 Nov 2017 01:28:18 +0000	[thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8B003721@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <a40967ab-e278-32a7-dd4e-bea9beb36731@intel.com>

Hi Jianfeng,

Thanks for detailed reviews and comments. Next version will come soon according to your suggestions.

Thanks
Zhiyong

> -----Original Message-----
> From: Tan, Jianfeng
> Sent: Wednesday, November 8, 2017 9:53 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org
> Cc: yliu@fridaylinux.org; maxime.coquelin@redhat.com
> Subject: Re: [PATCH v2] net/virtio: fix rxq intr config fails using vfio-pci
> 
> 
> Hi Zhiyong,
> 
> 
> On 11/8/2017 7:03 PM, Zhiyong Yang wrote:
> > When running l3fwd-power to test virtio rxq interrupt using vfio pci
> > noiommu mode, startup fails. In the function virtio_read_caps, the
> > code if (flags & PCI_MSIX_ENABLE) intends to double check if vfio msix
> > is enabled or not. However, it is not enable at that stage. So
> > use_msix is assigned to "0", not "1", which causes the failure of
> > configuring rxq intr in l3fwd-power.
> > This patch adds the function vtpci_msix_detect to detect the status of
> > msix when interrupt changes happen.
> > In the meanwhile, virtio_intr_enable/disable are introduced to wrap
> > rte_intr_enable/disable to enhance the ability to detect msix. Only
> > support and enable msix can assign "1" to use_msix.
> 
> Should be "2". Better to use macro here.
> 
> >
> > Fixes: cb482cb3a305 ("net/virtio: fix MAC address read")
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> > ---

  reply	other threads:[~2017-11-09  1:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-31  9:44 [dpdk-dev] [PATCH] net/virtio: fix use_msix get the wrong value Zhiyong Yang
2017-11-01 15:40 ` Yuanhan Liu
2017-11-02  1:46   ` Yang, Zhiyong
2017-11-02  3:36 ` Tan, Jianfeng
2017-11-08 11:03 ` [dpdk-dev] [PATCH v2] net/virtio: fix rxq intr config fails using vfio-pci Zhiyong Yang
2017-11-08 13:52   ` Tan, Jianfeng
2017-11-09  1:28     ` Yang, Zhiyong [this message]
2017-11-09  2:11     ` Yang, Zhiyong
2017-11-09  3:31       ` Tan, Jianfeng
2017-11-09  3:18   ` [dpdk-dev] [PATCH v3] " Zhiyong Yang
2017-11-09  3:47     ` Tan, Jianfeng
2017-11-09  4:01       ` Yang, Zhiyong
2017-11-09  4:40         ` Tan, Jianfeng
2017-11-09  4:46     ` [dpdk-dev] [PATCH v4] " Zhiyong Yang
2017-11-09  6:51       ` Tan, Jianfeng
2017-11-09  8:18       ` Maxime Coquelin
2017-11-09  8:55       ` [dpdk-dev] [PATCH v5] " Zhiyong Yang
2017-11-09  9:08         ` Maxime Coquelin
2017-11-09  9:16           ` Yang, Zhiyong
2017-11-09  9:21         ` [dpdk-dev] [PATCH v6] " Zhiyong Yang
2017-11-11 14:34           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A8B003721@BGSMSX101.gar.corp.intel.com \
    --to=zhiyong.yang@intel.com \
    --cc=dev@dpdk.org \
    --cc=jianfeng.tan@intel.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=yliu@fridaylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).