From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
To: "Kovacevic, Marko" <marko.kovacevic@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: fix link bonding pmd typo in prog guide
Date: Fri, 12 Jan 2018 10:56:08 +0000 [thread overview]
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A8B024159@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <6DC05C7C5F25994B81B3F2F214251F66331A92@IRSMSX104.ger.corp.intel.com>
Thanks Marko,
Fix the issues according to your comments.
V2 has been sent out.
Thanks
Zhiyong
> -----Original Message-----
> From: Kovacevic, Marko
> Sent: Friday, January 12, 2018 5:37 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org
> Cc: Mcnamara, John <john.mcnamara@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] doc: fix link bonding pmd typo in prog guide
>
> > fix one typo and a grammatical mistake.
> >
> > Fixes: b0152b1b40fe("doc: update bonding")
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
>
> First thing the git check log spit this error out so can you please just make
> these changes
>
> Running git check log on HEAD~1: 32787
> ======================================
> Wrong headline lowercase:
> doc: fix link bonding pmd typo in prog guide Wrong tag:
> ^^^^
> Upper case PMD
>
> Fixes: b0152b1b40fe("doc: update bonding") Wrong 'Fixes' reference:
> Fixes: b0152b1b40fe("doc: update bonding")
> ^^
> Insert a space..... Fixes: b0152b1b40fe ("doc: update bonding")
>
> Is it candidate for Cc: stable@dpdk.org backport?
> If it is Cc: the stable mailing list in the commit message body
>
> I don't think this is really an error but put a space between Fixes And Signed -
> off-by
>
> > Fixes: b0152b1b40fe("doc: update bonding")
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
>
>
> <...>
>
> >
> > The Link Bonding PMD library(librte_pmd_bond) supports bonding of
> > groups of ``rte_eth_dev`` ports of the same speed and duplex to
> > provide -similar the capabilities to that found in Linux bonding
> > driver to allow the
> ^^^^^^^^^^^^^^^^^^^^^^^^^^
> "to provide the similar capabilities" sounds better to me
>
> > +the capabilities similar to that found in Linux bonding driver to
> > +allow the
> > aggregation of multiple (slave) NICs into a single logical interface
> > between a server and a switch. The new bonded PMD will then process
> > these interfaces based on the mode of operation specified to provide
> > support for features such
>
> Once this has been changed you can include my Ack in the next version of
> the patch.
>
> Acked-by: Marko Kovacevic <marko.kovacevic@intel.com>
next prev parent reply other threads:[~2018-01-12 10:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-29 6:32 Zhiyong Yang
2018-01-12 9:37 ` Kovacevic, Marko
2018-01-12 10:56 ` Yang, Zhiyong [this message]
2018-01-15 11:21 ` Kovacevic, Marko
2018-01-19 1:59 ` Yang, Zhiyong
2018-01-12 10:40 ` [dpdk-dev] [PATCH v2] doc: fix link bonding PMD " Zhiyong Yang
2018-01-15 11:23 ` Kovacevic, Marko
2018-01-19 2:21 ` [dpdk-dev] [PATCH v3] " Zhiyong Yang
2018-01-19 19:43 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E182254E98A5DA4EB1E657AC7CB9BD2A8B024159@BGSMSX101.gar.corp.intel.com \
--to=zhiyong.yang@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).