DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dharmik Thakkar <Dharmik.Thakkar@arm.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level
Date: Tue, 26 Feb 2019 23:05:22 +0000	[thread overview]
Message-ID: <E6B6DAA1-E8C8-487F-9E36-10C881897E2A@arm.com> (raw)
In-Reply-To: <20190220150823.69a3cb3e@shemminger-XPS-13-9360>



> On Feb 20, 2019, at 5:08 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> On Wed, 20 Feb 2019 17:00:20 -0600
> Dharmik Thakkar <dharmik.thakkar@arm.com> wrote:
> 
>> Currently, in test code, for printing extra information,
>> compilation time options are used. This approach does not compile the
>> code always. Macro needs to be set for the code to compile.
>> 
>> This patchset replaces compilation time option with log level based
>> approach, thus enabling compilation of code always. Log levels can be
>> set using eal parameters.
>> 
>> Dharmik Thakkar (3):
>>  test/hash: replace macro with log-level approach
>>  test/efd: enable unit test compilation always
>>  test/timer: enable unit test compilation always
>> 
>> test/test/test_efd.c            | 24 ++++++++----------------
>> test/test/test_hash.c           |  3 +--
>> test/test/test_timer_racecond.c | 23 ++++++++++-------------
>> 3 files changed, 19 insertions(+), 31 deletions(-)
>> 
> 
> Maybe the tests should use their own dynamic logging (i.e. --log-level=test.hash:debug)
Updated. Thank you!

  reply	other threads:[~2019-02-26 23:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 20:31 [dpdk-dev] [PATCH " Dharmik Thakkar
2018-11-29 20:31 ` [dpdk-dev] [PATCH 1/3] test/hash: replace macro with log-level approach Dharmik Thakkar
2018-11-29 20:31 ` [dpdk-dev] [PATCH 2/3] test/efd: enable unit test compilation always Dharmik Thakkar
2018-11-29 20:31 ` [dpdk-dev] [PATCH 3/3] test/timer: " Dharmik Thakkar
2019-01-11 16:30 ` [dpdk-dev] [PATCH 0/3] Replace compilation time options with log level Ferruh Yigit
2019-02-20 22:47 ` [dpdk-dev] [PATCH v2 " Dharmik Thakkar
2019-02-20 22:47   ` [dpdk-dev] [PATCH v2 1/3] test/hash: replace macro with log-level approach Dharmik Thakkar
2019-02-20 22:47   ` [dpdk-dev] [PATCH v2 2/3] test/efd: enable unit test compilation always Dharmik Thakkar
2019-02-20 22:47   ` [dpdk-dev] [PATCH v2 3/3] test/timer: " Dharmik Thakkar
2019-02-20 23:00   ` [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level Dharmik Thakkar
2019-02-20 23:00     ` [dpdk-dev] [PATCH v3 1/3] test/hash: replace macro with log-level approach Dharmik Thakkar
2019-02-20 23:00     ` [dpdk-dev] [PATCH v3 2/3] test/efd: enable unit test compilation always Dharmik Thakkar
2019-02-20 23:00     ` [dpdk-dev] [PATCH v3 3/3] test/timer: " Dharmik Thakkar
2019-02-20 23:08     ` [dpdk-dev] [PATCH v3 0/3] Replace compilation time options with log level Stephen Hemminger
2019-02-26 23:05       ` Dharmik Thakkar [this message]
2019-02-26 23:02     ` [dpdk-dev] [PATCH v4 " Dharmik Thakkar
2019-02-26 23:02       ` [dpdk-dev] [PATCH v4 1/3] test/hash: replace macro with log-level approach Dharmik Thakkar
2019-02-26 23:02       ` [dpdk-dev] [PATCH v4 2/3] test/efd: enable unit test compilation always Dharmik Thakkar
2019-02-26 23:02       ` [dpdk-dev] [PATCH v4 3/3] test/timer: " Dharmik Thakkar
2019-03-28 18:26       ` [dpdk-dev] [PATCH v4 0/3] Replace compilation time options with log level Thomas Monjalon
2019-03-28 18:26         ` Thomas Monjalon
2019-03-28 18:35         ` Thomas Monjalon
2019-03-28 18:35           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E6B6DAA1-E8C8-487F-9E36-10C881897E2A@arm.com \
    --to=dharmik.thakkar@arm.com \
    --cc=dev@dpdk.org \
    --cc=nd@arm.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).