DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Stephen Hemminger <shemming@brocade.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/4] e1000: remove crc size from all byte counters
Date: Mon, 16 Nov 2015 17:03:59 +0000	[thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA61283812A@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20151116085440.3dca3ce0@samsung9>

> From: Stephen Hemminger [mailto:shemming@brocade.com]
> Harry van Haaren <harry.van.haaren@intel.com> wrote:
> <snip>
> > +	stats->tor -= (stats->tpr - old_tpr) * 4;
> 
> Why not use ETHER_CRC_LEN rather than magic # 4?

That would work too. Will respin tomorrow to fix and to give time
for other comments.

Thanks, -Harry

  reply	other threads:[~2015-11-16 17:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-16 10:35 [dpdk-dev] [PATCH 0/4] Remove CRC from " Harry van Haaren
2015-11-16 10:35 ` [dpdk-dev] [PATCH 1/4] e1000: remove crc size from all " Harry van Haaren
2015-11-16 16:54   ` Stephen Hemminger
2015-11-16 17:03     ` Van Haaren, Harry [this message]
2015-11-16 10:35 ` [dpdk-dev] [PATCH 2/4] ixgbe: " Harry van Haaren
2015-11-16 10:35 ` [dpdk-dev] [PATCH 3/4] i40e: fix rx/tx size mismatch, remove crc bytes Harry van Haaren
2015-11-16 10:35 ` [dpdk-dev] [PATCH 4/4] fm10k: remove crc size from all byte counters Harry van Haaren
2015-11-17  1:23   ` Qiu, Michael
2015-11-18 10:48 ` [dpdk-dev] [PATCH v2 0/3] Remove CRC from " Harry van Haaren
2015-11-18 10:48   ` [dpdk-dev] [PATCH v2 1/3] e1000: remove crc size from all " Harry van Haaren
2015-11-18 10:48   ` [dpdk-dev] [PATCH v2 2/3] ixgbe: " Harry van Haaren
2015-11-18 10:48   ` [dpdk-dev] [PATCH v2 3/3] i40e: fix rx/tx size mismatch, remove crc bytes Harry van Haaren
2015-11-20 12:04   ` [dpdk-dev] [PATCH v2 0/3] Remove CRC from byte counters Ananyev, Konstantin
2015-11-23 21:51     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E923DB57A917B54B9182A2E928D00FA61283812A@IRSMSX102.ger.corp.intel.com \
    --to=harry.van.haaren@intel.com \
    --cc=dev@dpdk.org \
    --cc=shemming@brocade.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).