From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "shemming@brocade.com" <shemming@brocade.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/3] Remove CRC from byte counters
Date: Fri, 20 Nov 2015 12:04:07 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836ACA81F@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1447843689-32315-1-git-send-email-harry.van.haaren@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren
> Sent: Wednesday, November 18, 2015 10:48 AM
> To: dev@dpdk.org
> Cc: shemming@brocade.com
> Subject: [dpdk-dev] [PATCH v2 0/3] Remove CRC from byte counters
>
> This patchset removes CRC bytes from byte statistics in the following
> PMDs: igb, ixgbe, i40e.
>
> This brings the reported byte statistics in-line with other NICs,
> providing consistency.
>
> Removing the CRC from byte counters in i40e resolves a bug, see
> i40e commit message for details.
>
> v2:
> -Done Stephen Hemmingers suggestion of ETHER_CRC_LEN replacing magic #4
> -Removed fm10k patch, thanks Michael Qiu for reporting - my testpmd usage
> for packet sizes on fm10k was creating an offset of 4 bytes in testing.
> -Reworded some comments
>
>
> Harry van Haaren (3):
> e1000: remove crc size from all byte counters
> ixgbe: remove crc size from all byte counters
> i40e: fix rx/tx size mismatch, remove crc bytes
>
> drivers/net/e1000/igb_ethdev.c | 19 ++++++++++++--
> drivers/net/i40e/i40e_ethdev.c | 13 ++++++++--
> drivers/net/ixgbe/ixgbe_ethdev.c | 55 +++++++++++++++++++++++++++++++---------
> 3 files changed, 71 insertions(+), 16 deletions(-)
>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> --
> 1.9.1
next prev parent reply other threads:[~2015-11-20 12:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 10:35 [dpdk-dev] [PATCH 0/4] " Harry van Haaren
2015-11-16 10:35 ` [dpdk-dev] [PATCH 1/4] e1000: remove crc size from all " Harry van Haaren
2015-11-16 16:54 ` Stephen Hemminger
2015-11-16 17:03 ` Van Haaren, Harry
2015-11-16 10:35 ` [dpdk-dev] [PATCH 2/4] ixgbe: " Harry van Haaren
2015-11-16 10:35 ` [dpdk-dev] [PATCH 3/4] i40e: fix rx/tx size mismatch, remove crc bytes Harry van Haaren
2015-11-16 10:35 ` [dpdk-dev] [PATCH 4/4] fm10k: remove crc size from all byte counters Harry van Haaren
2015-11-17 1:23 ` Qiu, Michael
2015-11-18 10:48 ` [dpdk-dev] [PATCH v2 0/3] Remove CRC from " Harry van Haaren
2015-11-18 10:48 ` [dpdk-dev] [PATCH v2 1/3] e1000: remove crc size from all " Harry van Haaren
2015-11-18 10:48 ` [dpdk-dev] [PATCH v2 2/3] ixgbe: " Harry van Haaren
2015-11-18 10:48 ` [dpdk-dev] [PATCH v2 3/3] i40e: fix rx/tx size mismatch, remove crc bytes Harry van Haaren
2015-11-20 12:04 ` Ananyev, Konstantin [this message]
2015-11-23 21:51 ` [dpdk-dev] [PATCH v2 0/3] Remove CRC from byte counters Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836ACA81F@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=shemming@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).