From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] service: fix service lcore stop function
Date: Wed, 6 Sep 2017 08:53:30 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA640C753A9@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <20170906071541.1922-1-gprathyusha@caviumnetworks.com>
> From: Guduri Prathyusha [mailto:gprathyusha@caviumnetworks.com]
> Sent: Wednesday, September 6, 2017 8:16 AM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Guduri Prathyusha <gprathyusha@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH v2] service: fix service lcore stop function
>
> lcore_states store the state of the lcore. Fixing the invalid
> dereference of lcore_states with service number
>
> Unit test case service_lcore_start_stop fails with the above fix.
> Service core was stopped without stopping the service.
>
> This commit fixes the test by adding negative and positive cases of
> stopping the service lcore before and after stopping the service
> respectively
>
> Fixes: 21698354c832 ("service: introduce service cores concept")
> Fixes: f038a81e1c56 ("service: add unit tests")
>
> Signed-off-by: Guduri Prathyusha <gprathyusha@caviumnetworks.com>
Thanks for fixing and rebase / update to v2. Please mark the v1 of this patchset as "Superseded" in patchwork.
Reviewed-by: Harry van Haaren <harry.van.haaren@intel.com>
> This patch is based on [1]
To be totally clear, this patch depends on the service cores (v2) patchset,
as linked at [1].
> v2 changes:
> - Combined Patch 1/2 and 2/2 of v1
> - Rebased to the future service core patches [1]
>
> [1] http://dpdk.org/dev/patchwork/patch/27684/
next prev parent reply other threads:[~2017-09-06 8:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 7:15 Guduri Prathyusha
2017-09-06 8:53 ` Van Haaren, Harry [this message]
2017-09-06 9:01 ` Guduri Prathyusha
2017-09-15 13:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA640C753A9@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=gprathyusha@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).