DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: zero local variable
Date: Thu, 26 Mar 2015 01:03:08 +0000	[thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E70A830F9B@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1427319492-943-1-git-send-email-jingjing.wu@intel.com>



> -----Original Message-----
> From: Wu, Jingjing
> Sent: Thursday, March 26, 2015 5:38 AM
> To: dev@dpdk.org
> Cc: Wu, Jingjing; Zhang, Helin; Cao, Min
> Subject: [PATCH] i40e: zero local variable
> 
> This patch sets the local variable ctxt to zero to avoid uncertain data causes
> error when creating a vsi for flow director.
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

> ---
>  lib/librte_pmd_i40e/i40e_ethdev.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c
> b/lib/librte_pmd_i40e/i40e_ethdev.c
> index cf6685e..80fc432 100644
> --- a/lib/librte_pmd_i40e/i40e_ethdev.c
> +++ b/lib/librte_pmd_i40e/i40e_ethdev.c
> @@ -3120,6 +3120,7 @@ i40e_vsi_setup(struct i40e_pf *pf,
>  		ctxt.info.valid_sections |=
>  			rte_cpu_to_le_16(I40E_AQ_VSI_PROP_SCHED_VALID);
>  	} else if (type == I40E_VSI_FDIR) {
> +		memset(&ctxt, 0, sizeof(ctxt));
>  		vsi->uplink_seid = uplink_vsi->uplink_seid;
>  		ctxt.pf_num = hw->pf_id;
>  		ctxt.vf_num = 0;
> @@ -3143,7 +3144,7 @@ i40e_vsi_setup(struct i40e_pf *pf,
> 
>  	if (vsi->type != I40E_VSI_MAIN) {
>  		ret = i40e_aq_add_vsi(hw, &ctxt, NULL);
> -		if (ret) {
> +		if (ret != I40E_SUCCESS) {
>  			PMD_DRV_LOG(ERR, "add vsi failed, aq_err=%d",
>  				    hw->aq.asq_last_status);
>  			goto fail_msix_alloc;
> --
> 1.9.3

  reply	other threads:[~2015-03-26  1:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25 21:38 Jingjing Wu
2015-03-26  1:03 ` Zhang, Helin [this message]
2015-03-27 10:34   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E70A830F9B@SHSMSX104.ccr.corp.intel.com \
    --to=helin.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).