[dpdk-dev] Support for Intel 82579LM (8086:1502)

[dpdk-dev] Support for Intel 82579LM (8086:1502)

[Mor, Omri]

Hello,

I have a computer I’m using for testing DPDK that has an Intel 82579LM.
Currently this NIC isn’t supported in DPDK, but I believe it is similar to others that are (such as the 82574L, which I am using successfully on another computer).
How much work would be required in getting this up and running—what functionality is missing?
I’m currently using it with AF_PACKET (and will try pcap soon), but would be interested in seeing its performance under DPDK ‘native’.

Thank you,
Omri Mor

[dpdk-dev] [PATCH] net/e1000: add pci ids for 82579LM

[Markus Theil]

This patch adds the PCI IDs for Intel 82579LM.

Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
---
 drivers/net/e1000/em_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c
index 6ebfa6d4c..85607c322 100644
--- a/drivers/net/e1000/em_ethdev.c
+++ b/drivers/net/e1000/em_ethdev.c
@@ -161,6 +161,7 @@ static const struct rte_pci_id pci_id_em_map[] = {
 	{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_82574L) },
 	{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_82574LA) },
 	{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_82583V) },
+	{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_PCH2_LV_LM) },
 	{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_PCH_LPT_I217_LM) },
 	{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_PCH_LPT_I217_V) },
 	{ RTE_PCI_DEVICE(E1000_INTEL_VENDOR_ID, E1000_DEV_ID_PCH_LPTLP_I218_LM) },
@@ -286,6 +287,7 @@ eth_em_dev_is_ich8(struct e1000_hw *hw)
 	DEBUGFUNC("eth_em_dev_is_ich8");
 
 	switch (hw->device_id) {
+	case E1000_DEV_ID_PCH2_LV_LM:
 	case E1000_DEV_ID_PCH_LPT_I217_LM:
 	case E1000_DEV_ID_PCH_LPT_I217_V:
 	case E1000_DEV_ID_PCH_LPTLP_I218_LM:
-- 
2.14.2

Re: [dpdk-dev] Support for Intel 82579LM (8086:1502)

[Markus Theil]

Hi,

I wrote a little patch for you. You can apply it to the current
dpdk-master branch and test it.
My Thinkpad T430 has such a NIC and shows some rx packets and the link
status change with the patch,
when using testpmd. Maybe 82579LM was not supported for a reason, so
simply try out if it works for your purpose :)

Markus


On 12.10.2017 22:47, Mor, Omri wrote:
> Hello,
>
> I have a computer I’m using for testing DPDK that has an Intel 82579LM.
> Currently this NIC isn’t supported in DPDK, but I believe it is similar to others that are (such as the 82574L, which I am using successfully on another computer).
> How much work would be required in getting this up and running—what functionality is missing?
> I’m currently using it with AF_PACKET (and will try pcap soon), but would be interested in seeing its performance under DPDK ‘native’.
>
> Thank you,
> Omri Mor

Re: [dpdk-dev] Support for Intel 82579LM (8086:1502)

[Mor, Omri]

Hi Markus,

Thanks for the patch!
I thought that it might only need the support ‘switch’ flipped on, but wasn’t sure.
It seems to work, though I get the following message when testing using `testpmd`:
	EAL: Error enabling MSI-X interrupts for fd 26
I’ve also seen a couple of lost packets, which I wonder if are due to the above.
So I guess it’s missing /something/ to be entirely supported, but with this it does work (at least partially).

Thanks!
Omri
> On Oct 13, 2017, at 11:38, Markus Theil <markus.theil@tu-ilmenau.de> wrote:
> 
> Hi,
> 
> I wrote a little patch for you. You can apply it to the current
> dpdk-master branch and test it.
> My Thinkpad T430 has such a NIC and shows some rx packets and the link
> status change with the patch,
> when using testpmd. Maybe 82579LM was not supported for a reason, so
> simply try out if it works for your purpose :)
> 
> Markus
> 
> 
> On 12.10.2017 22:47, Mor, Omri wrote:
>> Hello,
>> 
>> I have a computer I’m using for testing DPDK that has an Intel 82579LM.
>> Currently this NIC isn’t supported in DPDK, but I believe it is similar to others that are (such as the 82574L, which I am using successfully on another computer).
>> How much work would be required in getting this up and running—what functionality is missing?
>> I’m currently using it with AF_PACKET (and will try pcap soon), but would be interested in seeing its performance under DPDK ‘native’.
>> 
>> Thank you,
>> Omri Mor
> 

Re: [dpdk-dev] net/e1000: add pci ids for 82579LM

[Wenzhuo Lu]

> Date: Fri, 13 Oct 2017 18:32:18 +0200
>
> This patch adds the PCI IDs for Intel 82579LM.
>
>Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
Thanks for the patch.

Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

Re: [dpdk-dev] net/e1000: add pci ids for 82579LM

[Zhang, Helin]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu
> Sent: Thursday, January 11, 2018 3:12 PM
> To: markus.theil@tu-ilmenau.de; dev@dpdk.org
> Subject: Re: [dpdk-dev] net/e1000: add pci ids for 82579LM
> 
> > Date: Fri, 13 Oct 2017 18:32:18 +0200
> >
> > This patch adds the PCI IDs for Intel 82579LM.
> >
> >Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
> Thanks for the patch.
> 
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied to dpdk-next-net-intel with minor commit log changes, thanks!

/Helin