From: "Zhang, Helin" <helin.zhang@intel.com>
To: "Varghese, Vipin" <vipin.varghese@intel.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/e1000 igb: fix compile issue with log register
Date: Tue, 22 May 2018 02:03:50 +0000 [thread overview]
Message-ID: <F35DEAC7BCE34641BA9FAC6BCA4A12E71AED5271@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D1F7BA4@BGSMSX101.gar.corp.intel.com>
> -----Original Message-----
> From: Varghese, Vipin
> Sent: Monday, May 21, 2018 6:10 PM
> To: Van Haaren, Harry; dev@dpdk.org
> Cc: Lu, Wenzhuo; Zhang, Helin
> Subject: RE: [PATCH] net/e1000 igb: fix compile issue with log register
>
>
> > -----Original Message-----
> > From: Van Haaren, Harry
> > Sent: Monday, May 21, 2018 3:02 PM
> > To: dev@dpdk.org
> > Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Varghese, Vipin
> > <vipin.varghese@intel.com>; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhang,
> > Helin <helin.zhang@intel.com>
> > Subject: [PATCH] net/e1000 igb: fix compile issue with log register
> >
> > This commit fixes a compilation error if EM_PMD is not defined, bug
> > IGB_PMD is. The root cause of the issue was that log init variables
> > are declared as extern in a header file, while the definition of the variables
> was in e1000_ethdev.c.
> > Hence, the definitions were not available if the e1000 PMD is disabled.
> >
> > To fix this, a new file is added e1000_logs.c, which matches the
> > e1000_logs.h header. The log variables are always compiled in, but the
> > PMD logs are only registered if a PMD is enabled in the configuration.
> > Extra checks are added in order to avoid duplicate registering.
> >
> > Fixes: ed5bbb767c3e ("net/e1000: implement dynamic logging")
> >
> > Reported-by: Vipin Varghese <vipin.varghese@intel.com>
> > Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> Acked-by: Vipin Varghese <vipin.varghese@intel.com>
Applied to dpdk-next-net-intel, thanks!
/Helin
prev parent reply other threads:[~2018-05-22 2:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 9:31 Harry van Haaren
2018-05-21 10:10 ` Varghese, Vipin
2018-05-22 2:03 ` Zhang, Helin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F35DEAC7BCE34641BA9FAC6BCA4A12E71AED5271@SHSMSX103.ccr.corp.intel.com \
--to=helin.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=vipin.varghese@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).