DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Ouyang, Changchun" <changchun.ouyang@intel.com>
To: "Fu, Weiyi (NSN - CN/Hangzhou)" <weiyi.fu@nsn.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] In DPDK 1.7.1, the link status of the interface using virtio driver is always down.
Date: Mon, 15 Dec 2014 03:25:15 +0000	[thread overview]
Message-ID: <F52918179C57134FAEC9EA62FA2F962511946BBE@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <2680B515A539A446ACBEC0EBBDEC3DF80E9388D2@SGSIMBX001.nsn-intra.net>

Hi Weiyi,
Thanks for updating.

> -----Original Message-----
> From: Fu, Weiyi (NSN - CN/Hangzhou) [mailto:weiyi.fu@nsn.com]
> Sent: Monday, December 15, 2014 10:56 AM
> To: Fu, Weiyi (NSN - CN/Hangzhou); Ouyang, Changchun; dev@dpdk.org
> Cc: mmvijay@gmail.com
> Subject: RE: [dpdk-dev] In DPDK 1.7.1, the link status of the interface using
> virtio driver is always down.
> 
> Hi,
> With follow changes, the link is UP and interface can receive and send traffic.
> Thanks a lot:)
> 
> diff --git a/lib/librte_pmd_virtio/virtio_ethdev.c
> b/lib/librte_pmd_virtio/virtio_ethdev.c
> index 3344ffb..43d1c19 100644
> --- a/lib/librte_pmd_virtio/virtio_ethdev.c
> +++ b/lib/librte_pmd_virtio/virtio_ethdev.c
> @@ -784,6 +784,7 @@ eth_virtio_dev_init(__rte_unused struct eth_driver
> *eth_drv,
>         }
>  #endif
>         hw->use_msix = virtio_has_msix(&pci_dev->addr);
> +       hw->use_msix  = 1;

Use constant is not a good fix, maybe you can have a solid fix for this,
Check how it can find the msix information on your environment, and then
You may change some codes inside function virtio_has_msix to let it also
Work in your environment even without " hw->use_msix  = 1".

Thanks
Changchun

  reply	other threads:[~2014-12-15  3:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-11  7:57 Fu, Weiyi (NSN - CN/Hangzhou)
2014-12-11  8:11 ` Ouyang, Changchun
2014-12-11  8:42   ` Fu, Weiyi (NSN - CN/Hangzhou)
2014-12-11 11:41   ` Fu, Weiyi (NSN - CN/Hangzhou)
2014-12-11 13:41     ` Vijayakumar Muthuvel Manickam
2014-12-12  1:00     ` Ouyang, Changchun
2014-12-12  1:57       ` Fu, Weiyi (NSN - CN/Hangzhou)
2014-12-15  2:55       ` Fu, Weiyi (NSN - CN/Hangzhou)
2014-12-15  3:25         ` Ouyang, Changchun [this message]
2014-12-15  7:00           ` Fu, Weiyi (NSN - CN/Hangzhou)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F52918179C57134FAEC9EA62FA2F962511946BBE@shsmsx102.ccr.corp.intel.com \
    --to=changchun.ouyang@intel.com \
    --cc=dev@dpdk.org \
    --cc=weiyi.fu@nsn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).