From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Wang, Haiyue" <haiyue.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH v2] common/iavf: mark internal symbols
Date: Mon, 17 Aug 2020 03:08:11 +0000 [thread overview]
Message-ID: <MN2PR11MB380782F306D92B18A08CA41BF75F0@MN2PR11MB3807.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200814163055.326072-1-haiyue.wang@intel.com>
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Saturday, August 15, 2020 12:31 AM
> To: dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; Yang, Qiming
> <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Ray
> Kinsella <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>
> Subject: [PATCH v2] common/iavf: mark internal symbols
>
> According to ABI policy, the internal functions should have the new tag
> __rte_internal and linked into INTERNAL sessions.
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> v2: update the commit title
> ---
> drivers/common/iavf/iavf_prototype.h | 6 ++++++
> drivers/common/iavf/rte_common_iavf_version.map | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/common/iavf/iavf_prototype.h
> b/drivers/common/iavf/iavf_prototype.h
> index 31ce2af49..f34e77db0 100644
> --- a/drivers/common/iavf/iavf_prototype.h
> +++ b/drivers/common/iavf/iavf_prototype.h
> @@ -17,7 +17,9 @@
> */
>
> /* adminq functions */
> +__rte_internal
> enum iavf_status iavf_init_adminq(struct iavf_hw *hw);
> +__rte_internal
> enum iavf_status iavf_shutdown_adminq(struct iavf_hw *hw); enum
> iavf_status iavf_init_asq(struct iavf_hw *hw); enum iavf_status
> iavf_init_arq(struct iavf_hw *hw); @@ -30,6 +32,7 @@ void
> iavf_free_adminq_asq(struct iavf_hw *hw); void iavf_free_adminq_arq(struct
> iavf_hw *hw); enum iavf_status iavf_validate_mac_addr(u8 *mac_addr);
> void iavf_adminq_init_ring_data(struct iavf_hw *hw);
> +__rte_internal
> enum iavf_status iavf_clean_arq_element(struct iavf_hw *hw,
> struct iavf_arq_event_info *e,
> u16 *events_pending);
> @@ -61,6 +64,7 @@ enum iavf_status iavf_aq_set_rss_key(struct iavf_hw *hw,
> const char *iavf_aq_str(struct iavf_hw *hw, enum iavf_admin_queue_err
> aq_err); const char *iavf_stat_str(struct iavf_hw *hw, enum iavf_status
> stat_err);
>
> +__rte_internal
> enum iavf_status iavf_set_mac_type(struct iavf_hw *hw);
>
> extern struct iavf_rx_ptype_decoded iavf_ptype_lookup[]; @@ -76,9 +80,11
> @@ void iavf_acquire_spinlock(struct iavf_spinlock *sp); void
> iavf_release_spinlock(struct iavf_spinlock *sp); void
> iavf_destroy_spinlock(struct iavf_spinlock *sp);
>
> +__rte_internal
> void iavf_vf_parse_hw_config(struct iavf_hw *hw,
> struct virtchnl_vf_resource *msg); enum iavf_status
> iavf_vf_reset(struct iavf_hw *hw);
> +__rte_internal
> enum iavf_status iavf_aq_send_msg_to_pf(struct iavf_hw *hw,
> enum virtchnl_ops v_opcode,
> enum iavf_status v_retval,
> diff --git a/drivers/common/iavf/rte_common_iavf_version.map
> b/drivers/common/iavf/rte_common_iavf_version.map
> index 44142499e..e0f117197 100644
> --- a/drivers/common/iavf/rte_common_iavf_version.map
> +++ b/drivers/common/iavf/rte_common_iavf_version.map
> @@ -1,4 +1,4 @@
> -DPDK_21 {
> +INTERNAL {
> global:
>
> iavf_aq_send_msg_to_pf;
> --
> 2.28.0
Acked-by: Beilei Xing <beilei.xing@intel.com>
next prev parent reply other threads:[~2020-08-17 3:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 16:23 [dpdk-dev] [PATCH v1] common/iavf: mark the global functions internal Haiyue Wang
2020-08-14 16:30 ` [dpdk-dev] [PATCH v2] common/iavf: mark internal symbols Haiyue Wang
2020-08-17 3:08 ` Xing, Beilei [this message]
2020-08-18 15:48 ` Ferruh Yigit
2020-08-31 4:14 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB380782F306D92B18A08CA41BF75F0@MN2PR11MB3807.namprd11.prod.outlook.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).