* [dpdk-dev] [PATCH v1 0/2] update docs for vhost async API
@ 2020-07-22 10:57 patrick.fu
2020-07-22 10:57 ` [dpdk-dev] [PATCH v1 1/2] doc: update guides for vhost async APIs patrick.fu
` (2 more replies)
0 siblings, 3 replies; 15+ messages in thread
From: patrick.fu @ 2020-07-22 10:57 UTC (permalink / raw)
To: dev, maxime.coquelin, chenbo.xia; +Cc: Patrick Fu
From: Patrick Fu <patrick.fu@intel.com>
update documentations for vhost async API
Patrick Fu (2):
doc: update guides for vhost async APIs
doc: update release notes for vhost async APIs
doc/guides/prog_guide/vhost_lib.rst | 86 +++++++++++++++++++++++---
doc/guides/rel_notes/release_20_08.rst | 5 ++
2 files changed, 82 insertions(+), 9 deletions(-)
--
2.18.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v1 1/2] doc: update guides for vhost async APIs
2020-07-22 10:57 [dpdk-dev] [PATCH v1 0/2] update docs for vhost async API patrick.fu
@ 2020-07-22 10:57 ` patrick.fu
2020-07-22 11:21 ` Xia, Chenbo
2020-07-22 10:57 ` [dpdk-dev] [PATCH v1 2/2] doc: update release notes " patrick.fu
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 0/2] update docs " patrick.fu
2 siblings, 1 reply; 15+ messages in thread
From: patrick.fu @ 2020-07-22 10:57 UTC (permalink / raw)
To: dev, maxime.coquelin, chenbo.xia; +Cc: Patrick Fu
From: Patrick Fu <patrick.fu@intel.com>
Update vhost guides to document vhost async APIs
Signed-off-by: Patrick Fu <patrick.fu@intel.com>
---
doc/guides/prog_guide/vhost_lib.rst | 86 ++++++++++++++++++++++++++---
1 file changed, 77 insertions(+), 9 deletions(-)
diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst
index db921f922..cce8b6ae7 100644
--- a/doc/guides/prog_guide/vhost_lib.rst
+++ b/doc/guides/prog_guide/vhost_lib.rst
@@ -147,6 +147,21 @@ The following is an overview of some key Vhost API functions:
It is disabled by default.
+ - ``RTE_VHOST_USER_ASYNC_COPY``
+
+ Asynchronous data path will be enabled when this flag is set. Async data
+ path allows applications to register async copy devices (typically
+ hardware DMA channels) to the vhost queues. Vhost leverages the copy
+ device registered to offload CPU from memory copy operations. A set of
+ async data path APIs are defined for DPDK applications to make use of
+ the async capability. Only packets enqueued/dequeued by async APIs are
+ processed through the async data path.
+
+ Currently this feature is only implemented on split ring enqueue data
+ path.
+
+ It is disabled by default.
+
* ``rte_vhost_driver_set_features(path, features)``
This function sets the feature bits the vhost-user driver supports. The
@@ -235,6 +250,59 @@ The following is an overview of some key Vhost API functions:
Enable or disable zero copy feature of the vhost crypto backend.
+* ``rte_vhost_async_channel_register(vid, queue_id, features, ops)``
+
+ Register a vhost queue with async copy device channel.
+ Following device ``features`` must be specified together with the
+ registration:
+
+ * ``async_inorder``
+
+ Async copy device can guarantee the ordering of copy completion
+ sequence. Copies are completed in the same order with that at
+ the submission time.
+
+ Currently, only ``async_inorder`` capable device is supported by vhost.
+
+ * ``async_threshold``
+
+ The copy length (in bytes) below which CPU copy will be used even if
+ applications call async vhost APIs to enqueue/dequeue data.
+
+ Typical value is 512~1024 depending on the async device capability.
+
+ Applications must provide following ``ops`` callbacks for vhost lib to
+ work with the async copye devices:
+
+ * ``transfer_data(vid, queue_id, descs, opaque_data, count)``
+
+ vhost invokes this function to submit copy data to the async devices.
+ For non-async_inorder capable devices, ``opaque_data`` could be used
+ for identifying the completed packets.
+
+ * ``check_completed_copies(vid, queue_id, opaque_data, max_packets)``
+
+ vhost invokes this function to get the copy data completed by async
+ devices.
+
+* ``rte_vhost_async_channel_unregister(vid, queue_id)``
+
+ Unregister the async copy device from a vhost queue.
+
+* ``rte_vhost_submit_enqueue_burst(vid, queue_id, pkts, count)``
+
+ Submit an enqueue request to transmit ``count`` packets from host to guest
+ by async data path. Enqueue is not guaranteed to finish upon the return of
+ this API call.
+
+ Applications must not free the packets submitted for enqueue until the
+ packets are completed.
+
+* ``rte_vhost_poll_enqueue_completed(vid, queue_id, pkts, count)``
+
+ Poll enqueue completion status from async data path. Completed packets
+ are returned to applications through ``pkts``.
+
Vhost-user Implementations
--------------------------
@@ -294,16 +362,16 @@ Guest memory requirement
* Memory pre-allocation
- For non-zerocopy, guest memory pre-allocation is not a must. This can help
- save of memory. If users really want the guest memory to be pre-allocated
- (e.g., for performance reason), we can add option ``-mem-prealloc`` when
- starting QEMU. Or, we can lock all memory at vhost side which will force
- memory to be allocated when mmap at vhost side; option --mlockall in
- ovs-dpdk is an example in hand.
+ For non-zerocopy non-async data path, guest memory pre-allocation is not a
+ must. This can help save of memory. If users really want the guest memory
+ to be pre-allocated (e.g., for performance reason), we can add option
+ ``-mem-prealloc`` when starting QEMU. Or, we can lock all memory at vhost
+ side which will force memory to be allocated when mmap at vhost side;
+ option --mlockall in ovs-dpdk is an example in hand.
- For zerocopy, we force the VM memory to be pre-allocated at vhost lib when
- mapping the guest memory; and also we need to lock the memory to prevent
- pages being swapped out to disk.
+ For async data path or zerocopy, we force the VM memory to be pre-allocated
+ at vhost lib when mapping the guest memory; and also we need to lock the
+ memory to prevent pages being swapped out to disk.
* Memory sharing
--
2.18.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v1 2/2] doc: update release notes for vhost async APIs
2020-07-22 10:57 [dpdk-dev] [PATCH v1 0/2] update docs for vhost async API patrick.fu
2020-07-22 10:57 ` [dpdk-dev] [PATCH v1 1/2] doc: update guides for vhost async APIs patrick.fu
@ 2020-07-22 10:57 ` patrick.fu
2020-07-22 11:25 ` Xia, Chenbo
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 0/2] update docs " patrick.fu
2 siblings, 1 reply; 15+ messages in thread
From: patrick.fu @ 2020-07-22 10:57 UTC (permalink / raw)
To: dev, maxime.coquelin, chenbo.xia; +Cc: Patrick Fu
From: Patrick Fu <patrick.fu@intel.com>
Update 20.08 release notes to include vhost async APIs
Signed-off-by: Patrick Fu <patrick.fu@intel.com>
---
doc/guides/rel_notes/release_20_08.rst | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
index f19b74872..47ed488ed 100644
--- a/doc/guides/rel_notes/release_20_08.rst
+++ b/doc/guides/rel_notes/release_20_08.rst
@@ -225,6 +225,11 @@ New Features
See the :doc:`../sample_app_ug/l2_forward_real_virtual` for more
details of this parameter usage.
+* **Added vhost async data path APIs.**
+
+ 4 new APIs has been added to enable vhost async data path. With the new
+ data path, applications can register vhost with copy devices, such as DMA
+ engines, to offload memory copy operations.
Removed Items
-------------
--
2.18.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v1 1/2] doc: update guides for vhost async APIs
2020-07-22 10:57 ` [dpdk-dev] [PATCH v1 1/2] doc: update guides for vhost async APIs patrick.fu
@ 2020-07-22 11:21 ` Xia, Chenbo
2020-07-22 15:06 ` Fu, Patrick
0 siblings, 1 reply; 15+ messages in thread
From: Xia, Chenbo @ 2020-07-22 11:21 UTC (permalink / raw)
To: Fu, Patrick, dev, maxime.coquelin
Hi Patrick,
> -----Original Message-----
> From: Fu, Patrick <patrick.fu@intel.com>
> Sent: Wednesday, July 22, 2020 6:58 PM
> To: dev@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo
> <chenbo.xia@intel.com>
> Cc: Fu, Patrick <patrick.fu@intel.com>
> Subject: [PATCH v1 1/2] doc: update guides for vhost async APIs
>
> From: Patrick Fu <patrick.fu@intel.com>
>
> Update vhost guides to document vhost async APIs
>
> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> ---
> doc/guides/prog_guide/vhost_lib.rst | 86 ++++++++++++++++++++++++++---
> 1 file changed, 77 insertions(+), 9 deletions(-)
>
> diff --git a/doc/guides/prog_guide/vhost_lib.rst
> b/doc/guides/prog_guide/vhost_lib.rst
> index db921f922..cce8b6ae7 100644
> --- a/doc/guides/prog_guide/vhost_lib.rst
> +++ b/doc/guides/prog_guide/vhost_lib.rst
> @@ -147,6 +147,21 @@ The following is an overview of some key Vhost API
> functions:
>
> It is disabled by default.
>
> + - ``RTE_VHOST_USER_ASYNC_COPY``
> +
> + Asynchronous data path will be enabled when this flag is set. Async data
> + path allows applications to register async copy devices (typically
> + hardware DMA channels) to the vhost queues. Vhost leverages the copy
> + device registered to offload CPU from memory copy operations. A set of
You mean 'free' CPU from memory copy?
> + async data path APIs are defined for DPDK applications to make use of
> + the async capability. Only packets enqueued/dequeued by async APIs are
> + processed through the async data path.
> +
> + Currently this feature is only implemented on split ring enqueue data
> + path.
> +
> + It is disabled by default.
> +
> * ``rte_vhost_driver_set_features(path, features)``
>
> This function sets the feature bits the vhost-user driver supports. The @@ -
> 235,6 +250,59 @@ The following is an overview of some key Vhost API
> functions:
>
> Enable or disable zero copy feature of the vhost crypto backend.
>
> +* ``rte_vhost_async_channel_register(vid, queue_id, features, ops)``
> +
> + Register a vhost queue with async copy device channel.
> + Following device ``features`` must be specified together with the
> + registration:
> +
> + * ``async_inorder``
> +
> + Async copy device can guarantee the ordering of copy completion
> + sequence. Copies are completed in the same order with that at
> + the submission time.
> +
> + Currently, only ``async_inorder`` capable device is supported by vhost.
> +
> + * ``async_threshold``
> +
> + The copy length (in bytes) below which CPU copy will be used even if
> + applications call async vhost APIs to enqueue/dequeue data.
> +
> + Typical value is 512~1024 depending on the async device capability.
> +
> + Applications must provide following ``ops`` callbacks for vhost lib
> + to work with the async copye devices:
s/copye/copy
> +
> + * ``transfer_data(vid, queue_id, descs, opaque_data, count)``
> +
> + vhost invokes this function to submit copy data to the async devices.
> + For non-async_inorder capable devices, ``opaque_data`` could be used
> + for identifying the completed packets.
> +
> + * ``check_completed_copies(vid, queue_id, opaque_data, max_packets)``
> +
> + vhost invokes this function to get the copy data completed by async
> + devices.
> +
> +* ``rte_vhost_async_channel_unregister(vid, queue_id)``
> +
> + Unregister the async copy device from a vhost queue.
'Copy device channel' may be more accurate?
> +
> +* ``rte_vhost_submit_enqueue_burst(vid, queue_id, pkts, count)``
> +
> + Submit an enqueue request to transmit ``count`` packets from host to
> + guest by async data path. Enqueue is not guaranteed to finish upon
> + the return of this API call.
> +
> + Applications must not free the packets submitted for enqueue until
> + the packets are completed.
> +
> +* ``rte_vhost_poll_enqueue_completed(vid, queue_id, pkts, count)``
> +
> + Poll enqueue completion status from async data path. Completed
> + packets are returned to applications through ``pkts``.
> +
> Vhost-user Implementations
> --------------------------
>
> @@ -294,16 +362,16 @@ Guest memory requirement
>
> * Memory pre-allocation
>
> - For non-zerocopy, guest memory pre-allocation is not a must. This can help
> - save of memory. If users really want the guest memory to be pre-allocated
> - (e.g., for performance reason), we can add option ``-mem-prealloc`` when
> - starting QEMU. Or, we can lock all memory at vhost side which will force
> - memory to be allocated when mmap at vhost side; option --mlockall in
> - ovs-dpdk is an example in hand.
> + For non-zerocopy non-async data path, guest memory pre-allocation is
> + not a must. This can help save of memory. If users really want the
> + guest memory to be pre-allocated (e.g., for performance reason), we
> + can add option ``-mem-prealloc`` when starting QEMU. Or, we can lock
> + all memory at vhost side which will force memory to be allocated when
> + mmap at vhost side; option --mlockall in ovs-dpdk is an example in hand.
>
> - For zerocopy, we force the VM memory to be pre-allocated at vhost lib when
> - mapping the guest memory; and also we need to lock the memory to prevent
> - pages being swapped out to disk.
> + For async data path or zerocopy, we force the VM memory to be
'For async or zerocopy data path' may be better?
Thanks!
Chenbo
> + pre-allocated at vhost lib when mapping the guest memory; and also we
> + need to lock the memory to prevent pages being swapped out to disk.
>
> * Memory sharing
>
> --
> 2.18.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v1 2/2] doc: update release notes for vhost async APIs
2020-07-22 10:57 ` [dpdk-dev] [PATCH v1 2/2] doc: update release notes " patrick.fu
@ 2020-07-22 11:25 ` Xia, Chenbo
2020-07-22 15:07 ` Fu, Patrick
0 siblings, 1 reply; 15+ messages in thread
From: Xia, Chenbo @ 2020-07-22 11:25 UTC (permalink / raw)
To: Fu, Patrick, dev, maxime.coquelin
Hi Patrick,
> -----Original Message-----
> From: Fu, Patrick <patrick.fu@intel.com>
> Sent: Wednesday, July 22, 2020 6:58 PM
> To: dev@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo
> <chenbo.xia@intel.com>
> Cc: Fu, Patrick <patrick.fu@intel.com>
> Subject: [PATCH v1 2/2] doc: update release notes for vhost async APIs
>
> From: Patrick Fu <patrick.fu@intel.com>
>
> Update 20.08 release notes to include vhost async APIs
>
> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> ---
> doc/guides/rel_notes/release_20_08.rst | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/release_20_08.rst
> b/doc/guides/rel_notes/release_20_08.rst
> index f19b74872..47ed488ed 100644
> --- a/doc/guides/rel_notes/release_20_08.rst
> +++ b/doc/guides/rel_notes/release_20_08.rst
> @@ -225,6 +225,11 @@ New Features
> See the :doc:`../sample_app_ug/l2_forward_real_virtual` for more
> details of this parameter usage.
>
> +* **Added vhost async data path APIs.**
> +
> + 4 new APIs has been added to enable vhost async data path. With the
s/has/have
Should we mention you only added enqueue support?
Thanks,
Chenbo
> + new data path, applications can register vhost with copy devices,
> + such as DMA engines, to offload memory copy operations.
>
> Removed Items
> -------------
> --
> 2.18.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2 0/2] update docs for vhost async APIs
2020-07-22 10:57 [dpdk-dev] [PATCH v1 0/2] update docs for vhost async API patrick.fu
2020-07-22 10:57 ` [dpdk-dev] [PATCH v1 1/2] doc: update guides for vhost async APIs patrick.fu
2020-07-22 10:57 ` [dpdk-dev] [PATCH v1 2/2] doc: update release notes " patrick.fu
@ 2020-07-22 15:01 ` patrick.fu
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 1/2] doc: update guides " patrick.fu
` (2 more replies)
2 siblings, 3 replies; 15+ messages in thread
From: patrick.fu @ 2020-07-22 15:01 UTC (permalink / raw)
To: dev, maxime.coquelin, chenbo.xia; +Cc: Patrick Fu
From: Patrick Fu <patrick.fu@intel.com>
update docs for vhost async APIs
v2:
- fix typos in vhost_lib.rst
- minor rewording in vhost_lib.rst
- add more detailed API notes in release notes
- rebase the patch to 20.08 rc2
Patrick Fu (2):
doc: update guides for vhost async APIs
doc: update release notes for vhost async APIs
doc/guides/prog_guide/vhost_lib.rst | 86 +++++++++++++++++++++++---
doc/guides/rel_notes/release_20_08.rst | 6 ++
2 files changed, 83 insertions(+), 9 deletions(-)
--
2.18.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2 1/2] doc: update guides for vhost async APIs
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 0/2] update docs " patrick.fu
@ 2020-07-22 15:01 ` patrick.fu
2020-07-25 6:58 ` Xia, Chenbo
2020-07-28 9:01 ` Maxime Coquelin
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 2/2] doc: update release notes " patrick.fu
2020-07-28 15:26 ` [dpdk-dev] [PATCH v2 0/2] update docs " Maxime Coquelin
2 siblings, 2 replies; 15+ messages in thread
From: patrick.fu @ 2020-07-22 15:01 UTC (permalink / raw)
To: dev, maxime.coquelin, chenbo.xia; +Cc: Patrick Fu
From: Patrick Fu <patrick.fu@intel.com>
Update vhost guides to document vhost async APIs
Signed-off-by: Patrick Fu <patrick.fu@intel.com>
---
doc/guides/prog_guide/vhost_lib.rst | 86 ++++++++++++++++++++++++++---
1 file changed, 77 insertions(+), 9 deletions(-)
diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst
index db921f922..b892eec67 100644
--- a/doc/guides/prog_guide/vhost_lib.rst
+++ b/doc/guides/prog_guide/vhost_lib.rst
@@ -147,6 +147,21 @@ The following is an overview of some key Vhost API functions:
It is disabled by default.
+ - ``RTE_VHOST_USER_ASYNC_COPY``
+
+ Asynchronous data path will be enabled when this flag is set. Async data
+ path allows applications to register async copy devices (typically
+ hardware DMA channels) to the vhost queues. Vhost leverages the copy
+ device registered to free CPU from memory copy operations. A set of
+ async data path APIs are defined for DPDK applications to make use of
+ the async capability. Only packets enqueued/dequeued by async APIs are
+ processed through the async data path.
+
+ Currently this feature is only implemented on split ring enqueue data
+ path.
+
+ It is disabled by default.
+
* ``rte_vhost_driver_set_features(path, features)``
This function sets the feature bits the vhost-user driver supports. The
@@ -235,6 +250,59 @@ The following is an overview of some key Vhost API functions:
Enable or disable zero copy feature of the vhost crypto backend.
+* ``rte_vhost_async_channel_register(vid, queue_id, features, ops)``
+
+ Register a vhost queue with async copy device channel.
+ Following device ``features`` must be specified together with the
+ registration:
+
+ * ``async_inorder``
+
+ Async copy device can guarantee the ordering of copy completion
+ sequence. Copies are completed in the same order with that at
+ the submission time.
+
+ Currently, only ``async_inorder`` capable device is supported by vhost.
+
+ * ``async_threshold``
+
+ The copy length (in bytes) below which CPU copy will be used even if
+ applications call async vhost APIs to enqueue/dequeue data.
+
+ Typical value is 512~1024 depending on the async device capability.
+
+ Applications must provide following ``ops`` callbacks for vhost lib to
+ work with the async copy devices:
+
+ * ``transfer_data(vid, queue_id, descs, opaque_data, count)``
+
+ vhost invokes this function to submit copy data to the async devices.
+ For non-async_inorder capable devices, ``opaque_data`` could be used
+ for identifying the completed packets.
+
+ * ``check_completed_copies(vid, queue_id, opaque_data, max_packets)``
+
+ vhost invokes this function to get the copy data completed by async
+ devices.
+
+* ``rte_vhost_async_channel_unregister(vid, queue_id)``
+
+ Unregister the async copy device channel from a vhost queue.
+
+* ``rte_vhost_submit_enqueue_burst(vid, queue_id, pkts, count)``
+
+ Submit an enqueue request to transmit ``count`` packets from host to guest
+ by async data path. Enqueue is not guaranteed to finish upon the return of
+ this API call.
+
+ Applications must not free the packets submitted for enqueue until the
+ packets are completed.
+
+* ``rte_vhost_poll_enqueue_completed(vid, queue_id, pkts, count)``
+
+ Poll enqueue completion status from async data path. Completed packets
+ are returned to applications through ``pkts``.
+
Vhost-user Implementations
--------------------------
@@ -294,16 +362,16 @@ Guest memory requirement
* Memory pre-allocation
- For non-zerocopy, guest memory pre-allocation is not a must. This can help
- save of memory. If users really want the guest memory to be pre-allocated
- (e.g., for performance reason), we can add option ``-mem-prealloc`` when
- starting QEMU. Or, we can lock all memory at vhost side which will force
- memory to be allocated when mmap at vhost side; option --mlockall in
- ovs-dpdk is an example in hand.
+ For non-zerocopy non-async data path, guest memory pre-allocation is not a
+ must. This can help save of memory. If users really want the guest memory
+ to be pre-allocated (e.g., for performance reason), we can add option
+ ``-mem-prealloc`` when starting QEMU. Or, we can lock all memory at vhost
+ side which will force memory to be allocated when mmap at vhost side;
+ option --mlockall in ovs-dpdk is an example in hand.
- For zerocopy, we force the VM memory to be pre-allocated at vhost lib when
- mapping the guest memory; and also we need to lock the memory to prevent
- pages being swapped out to disk.
+ For async and zerocopy data path, we force the VM memory to be
+ pre-allocated at vhost lib when mapping the guest memory; and also we need
+ to lock the memory to prevent pages being swapped out to disk.
* Memory sharing
--
2.18.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* [dpdk-dev] [PATCH v2 2/2] doc: update release notes for vhost async APIs
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 0/2] update docs " patrick.fu
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 1/2] doc: update guides " patrick.fu
@ 2020-07-22 15:01 ` patrick.fu
2020-07-25 6:59 ` Xia, Chenbo
2020-07-28 9:06 ` Maxime Coquelin
2020-07-28 15:26 ` [dpdk-dev] [PATCH v2 0/2] update docs " Maxime Coquelin
2 siblings, 2 replies; 15+ messages in thread
From: patrick.fu @ 2020-07-22 15:01 UTC (permalink / raw)
To: dev, maxime.coquelin, chenbo.xia; +Cc: Patrick Fu
From: Patrick Fu <patrick.fu@intel.com>
Update 20.08 release notes to include vhost async APIs
Signed-off-by: Patrick Fu <patrick.fu@intel.com>
---
doc/guides/rel_notes/release_20_08.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
index d65f77250..dc8936056 100644
--- a/doc/guides/rel_notes/release_20_08.rst
+++ b/doc/guides/rel_notes/release_20_08.rst
@@ -243,6 +243,12 @@ New Features
of ingress packets to specific NIC queues.
See the :doc:`../sample_app_ug/ipsec_secgw` for more details.
+* **Added vhost async data path APIs.**
+
+ 4 new APIs have been added to enable vhost async data path, including:
+
+ * Async device channel register/unregister APIs
+ * Async packets enqueue/completion APIs (only split ring was implemented)
Removed Items
-------------
--
2.18.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v1 1/2] doc: update guides for vhost async APIs
2020-07-22 11:21 ` Xia, Chenbo
@ 2020-07-22 15:06 ` Fu, Patrick
0 siblings, 0 replies; 15+ messages in thread
From: Fu, Patrick @ 2020-07-22 15:06 UTC (permalink / raw)
To: Xia, Chenbo, dev, maxime.coquelin
Thanks for comments. v2 patch sent with all the changes suggested.
Thanks,
Patrick
> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia@intel.com>
> Sent: Wednesday, July 22, 2020 7:21 PM
> To: Fu, Patrick <patrick.fu@intel.com>; dev@dpdk.org;
> maxime.coquelin@redhat.com
> Subject: RE: [PATCH v1 1/2] doc: update guides for vhost async APIs
>
> Hi Patrick,
>
> > -----Original Message-----
> > From: Fu, Patrick <patrick.fu@intel.com>
> > Sent: Wednesday, July 22, 2020 6:58 PM
> > To: dev@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo
> > <chenbo.xia@intel.com>
> > Cc: Fu, Patrick <patrick.fu@intel.com>
> > Subject: [PATCH v1 1/2] doc: update guides for vhost async APIs
> >
> > From: Patrick Fu <patrick.fu@intel.com>
> >
> > Update vhost guides to document vhost async APIs
> >
> > Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> > ---
> > doc/guides/prog_guide/vhost_lib.rst | 86
> > ++++++++++++++++++++++++++---
> > 1 file changed, 77 insertions(+), 9 deletions(-)
> >
> > diff --git a/doc/guides/prog_guide/vhost_lib.rst
> > b/doc/guides/prog_guide/vhost_lib.rst
> > index db921f922..cce8b6ae7 100644
> > --- a/doc/guides/prog_guide/vhost_lib.rst
> > +++ b/doc/guides/prog_guide/vhost_lib.rst
> > @@ -147,6 +147,21 @@ The following is an overview of some key Vhost
> > API
> > functions:
> >
> > It is disabled by default.
> >
> > + - ``RTE_VHOST_USER_ASYNC_COPY``
> > +
> > + Asynchronous data path will be enabled when this flag is set. Async
> data
> > + path allows applications to register async copy devices (typically
> > + hardware DMA channels) to the vhost queues. Vhost leverages the copy
> > + device registered to offload CPU from memory copy operations. A
> > + set of
>
> You mean 'free' CPU from memory copy?
>
> > + async data path APIs are defined for DPDK applications to make use of
> > + the async capability. Only packets enqueued/dequeued by async APIs
> are
> > + processed through the async data path.
> > +
> > + Currently this feature is only implemented on split ring enqueue data
> > + path.
> > +
> > + It is disabled by default.
> > +
> > * ``rte_vhost_driver_set_features(path, features)``
> >
> > This function sets the feature bits the vhost-user driver supports.
> > The @@ -
> > 235,6 +250,59 @@ The following is an overview of some key Vhost API
> > functions:
> >
> > Enable or disable zero copy feature of the vhost crypto backend.
> >
> > +* ``rte_vhost_async_channel_register(vid, queue_id, features, ops)``
> > +
> > + Register a vhost queue with async copy device channel.
> > + Following device ``features`` must be specified together with the
> > + registration:
> > +
> > + * ``async_inorder``
> > +
> > + Async copy device can guarantee the ordering of copy completion
> > + sequence. Copies are completed in the same order with that at
> > + the submission time.
> > +
> > + Currently, only ``async_inorder`` capable device is supported by vhost.
> > +
> > + * ``async_threshold``
> > +
> > + The copy length (in bytes) below which CPU copy will be used even if
> > + applications call async vhost APIs to enqueue/dequeue data.
> > +
> > + Typical value is 512~1024 depending on the async device capability.
> > +
> > + Applications must provide following ``ops`` callbacks for vhost lib
> > + to work with the async copye devices:
>
> s/copye/copy
>
> > +
> > + * ``transfer_data(vid, queue_id, descs, opaque_data, count)``
> > +
> > + vhost invokes this function to submit copy data to the async devices.
> > + For non-async_inorder capable devices, ``opaque_data`` could be used
> > + for identifying the completed packets.
> > +
> > + * ``check_completed_copies(vid, queue_id, opaque_data,
> > + max_packets)``
> > +
> > + vhost invokes this function to get the copy data completed by async
> > + devices.
> > +
> > +* ``rte_vhost_async_channel_unregister(vid, queue_id)``
> > +
> > + Unregister the async copy device from a vhost queue.
>
> 'Copy device channel' may be more accurate?
>
> > +
> > +* ``rte_vhost_submit_enqueue_burst(vid, queue_id, pkts, count)``
> > +
> > + Submit an enqueue request to transmit ``count`` packets from host
> > + to guest by async data path. Enqueue is not guaranteed to finish
> > + upon the return of this API call.
> > +
> > + Applications must not free the packets submitted for enqueue until
> > + the packets are completed.
> > +
> > +* ``rte_vhost_poll_enqueue_completed(vid, queue_id, pkts, count)``
> > +
> > + Poll enqueue completion status from async data path. Completed
> > + packets are returned to applications through ``pkts``.
> > +
> > Vhost-user Implementations
> > --------------------------
> >
> > @@ -294,16 +362,16 @@ Guest memory requirement
> >
> > * Memory pre-allocation
> >
> > - For non-zerocopy, guest memory pre-allocation is not a must. This
> > can help
> > - save of memory. If users really want the guest memory to be
> > pre-allocated
> > - (e.g., for performance reason), we can add option ``-mem-prealloc``
> > when
> > - starting QEMU. Or, we can lock all memory at vhost side which will
> > force
> > - memory to be allocated when mmap at vhost side; option --mlockall
> > in
> > - ovs-dpdk is an example in hand.
> > + For non-zerocopy non-async data path, guest memory pre-allocation
> > + is not a must. This can help save of memory. If users really want
> > + the guest memory to be pre-allocated (e.g., for performance
> > + reason), we can add option ``-mem-prealloc`` when starting QEMU.
> > + Or, we can lock all memory at vhost side which will force memory to
> > + be allocated when mmap at vhost side; option --mlockall in ovs-dpdk is
> an example in hand.
> >
> > - For zerocopy, we force the VM memory to be pre-allocated at vhost
> > lib when
> > - mapping the guest memory; and also we need to lock the memory to
> > prevent
> > - pages being swapped out to disk.
> > + For async data path or zerocopy, we force the VM memory to be
>
> 'For async or zerocopy data path' may be better?
>
> Thanks!
> Chenbo
>
> > + pre-allocated at vhost lib when mapping the guest memory; and also
> > + we need to lock the memory to prevent pages being swapped out to disk.
> >
> > * Memory sharing
> >
> > --
> > 2.18.4
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v1 2/2] doc: update release notes for vhost async APIs
2020-07-22 11:25 ` Xia, Chenbo
@ 2020-07-22 15:07 ` Fu, Patrick
0 siblings, 0 replies; 15+ messages in thread
From: Fu, Patrick @ 2020-07-22 15:07 UTC (permalink / raw)
To: Xia, Chenbo, dev, maxime.coquelin
Hi,
> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia@intel.com>
> Sent: Wednesday, July 22, 2020 7:25 PM
> To: Fu, Patrick <patrick.fu@intel.com>; dev@dpdk.org;
> maxime.coquelin@redhat.com
> Subject: RE: [PATCH v1 2/2] doc: update release notes for vhost async APIs
>
> Hi Patrick,
>
> > -----Original Message-----
> > From: Fu, Patrick <patrick.fu@intel.com>
> > Sent: Wednesday, July 22, 2020 6:58 PM
> > To: dev@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo
> > <chenbo.xia@intel.com>
> > Cc: Fu, Patrick <patrick.fu@intel.com>
> > Subject: [PATCH v1 2/2] doc: update release notes for vhost async APIs
> >
> > From: Patrick Fu <patrick.fu@intel.com>
> >
> > Update 20.08 release notes to include vhost async APIs
> >
> > Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> > ---
> > doc/guides/rel_notes/release_20_08.rst | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/release_20_08.rst
> > b/doc/guides/rel_notes/release_20_08.rst
> > index f19b74872..47ed488ed 100644
> > --- a/doc/guides/rel_notes/release_20_08.rst
> > +++ b/doc/guides/rel_notes/release_20_08.rst
> > @@ -225,6 +225,11 @@ New Features
> > See the :doc:`../sample_app_ug/l2_forward_real_virtual` for more
> > details of this parameter usage.
> >
> > +* **Added vhost async data path APIs.**
> > +
> > + 4 new APIs has been added to enable vhost async data path. With the
>
> s/has/have
>
> Should we mention you only added enqueue support?
I included more details in v2 patch for the release notes.
Thanks,
Patrick
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] doc: update guides for vhost async APIs
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 1/2] doc: update guides " patrick.fu
@ 2020-07-25 6:58 ` Xia, Chenbo
2020-07-28 9:01 ` Maxime Coquelin
1 sibling, 0 replies; 15+ messages in thread
From: Xia, Chenbo @ 2020-07-25 6:58 UTC (permalink / raw)
To: Fu, Patrick, dev, maxime.coquelin
> -----Original Message-----
> From: Fu, Patrick <patrick.fu@intel.com>
> Sent: Wednesday, July 22, 2020 11:02 PM
> To: dev@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo
> <chenbo.xia@intel.com>
> Cc: Fu, Patrick <patrick.fu@intel.com>
> Subject: [PATCH v2 1/2] doc: update guides for vhost async APIs
>
> From: Patrick Fu <patrick.fu@intel.com>
>
> Update vhost guides to document vhost async APIs
>
> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> ---
> doc/guides/prog_guide/vhost_lib.rst | 86 ++++++++++++++++++++++++++---
> 1 file changed, 77 insertions(+), 9 deletions(-)
>
> diff --git a/doc/guides/prog_guide/vhost_lib.rst
> b/doc/guides/prog_guide/vhost_lib.rst
> index db921f922..b892eec67 100644
> --- a/doc/guides/prog_guide/vhost_lib.rst
> +++ b/doc/guides/prog_guide/vhost_lib.rst
> @@ -147,6 +147,21 @@ The following is an overview of some key Vhost API
> functions:
>
> It is disabled by default.
>
> + - ``RTE_VHOST_USER_ASYNC_COPY``
> +
> + Asynchronous data path will be enabled when this flag is set. Async data
> + path allows applications to register async copy devices (typically
> + hardware DMA channels) to the vhost queues. Vhost leverages the copy
> + device registered to free CPU from memory copy operations. A set of
> + async data path APIs are defined for DPDK applications to make use of
> + the async capability. Only packets enqueued/dequeued by async APIs are
> + processed through the async data path.
> +
> + Currently this feature is only implemented on split ring enqueue data
> + path.
> +
> + It is disabled by default.
> +
> * ``rte_vhost_driver_set_features(path, features)``
>
> This function sets the feature bits the vhost-user driver supports. The @@ -
> 235,6 +250,59 @@ The following is an overview of some key Vhost API
> functions:
>
> Enable or disable zero copy feature of the vhost crypto backend.
>
> +* ``rte_vhost_async_channel_register(vid, queue_id, features, ops)``
> +
> + Register a vhost queue with async copy device channel.
> + Following device ``features`` must be specified together with the
> + registration:
> +
> + * ``async_inorder``
> +
> + Async copy device can guarantee the ordering of copy completion
> + sequence. Copies are completed in the same order with that at
> + the submission time.
> +
> + Currently, only ``async_inorder`` capable device is supported by vhost.
> +
> + * ``async_threshold``
> +
> + The copy length (in bytes) below which CPU copy will be used even if
> + applications call async vhost APIs to enqueue/dequeue data.
> +
> + Typical value is 512~1024 depending on the async device capability.
> +
> + Applications must provide following ``ops`` callbacks for vhost lib
> + to work with the async copy devices:
> +
> + * ``transfer_data(vid, queue_id, descs, opaque_data, count)``
> +
> + vhost invokes this function to submit copy data to the async devices.
> + For non-async_inorder capable devices, ``opaque_data`` could be used
> + for identifying the completed packets.
> +
> + * ``check_completed_copies(vid, queue_id, opaque_data, max_packets)``
> +
> + vhost invokes this function to get the copy data completed by async
> + devices.
> +
> +* ``rte_vhost_async_channel_unregister(vid, queue_id)``
> +
> + Unregister the async copy device channel from a vhost queue.
> +
> +* ``rte_vhost_submit_enqueue_burst(vid, queue_id, pkts, count)``
> +
> + Submit an enqueue request to transmit ``count`` packets from host to
> + guest by async data path. Enqueue is not guaranteed to finish upon
> + the return of this API call.
> +
> + Applications must not free the packets submitted for enqueue until
> + the packets are completed.
> +
> +* ``rte_vhost_poll_enqueue_completed(vid, queue_id, pkts, count)``
> +
> + Poll enqueue completion status from async data path. Completed
> + packets are returned to applications through ``pkts``.
> +
> Vhost-user Implementations
> --------------------------
>
> @@ -294,16 +362,16 @@ Guest memory requirement
>
> * Memory pre-allocation
>
> - For non-zerocopy, guest memory pre-allocation is not a must. This can help
> - save of memory. If users really want the guest memory to be pre-allocated
> - (e.g., for performance reason), we can add option ``-mem-prealloc`` when
> - starting QEMU. Or, we can lock all memory at vhost side which will force
> - memory to be allocated when mmap at vhost side; option --mlockall in
> - ovs-dpdk is an example in hand.
> + For non-zerocopy non-async data path, guest memory pre-allocation is
> + not a must. This can help save of memory. If users really want the
> + guest memory to be pre-allocated (e.g., for performance reason), we
> + can add option ``-mem-prealloc`` when starting QEMU. Or, we can lock
> + all memory at vhost side which will force memory to be allocated when
> + mmap at vhost side; option --mlockall in ovs-dpdk is an example in hand.
>
> - For zerocopy, we force the VM memory to be pre-allocated at vhost lib when
> - mapping the guest memory; and also we need to lock the memory to prevent
> - pages being swapped out to disk.
> + For async and zerocopy data path, we force the VM memory to be
> + pre-allocated at vhost lib when mapping the guest memory; and also we
> + need to lock the memory to prevent pages being swapped out to disk.
>
> * Memory sharing
>
> --
> 2.18.4
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 2/2] doc: update release notes for vhost async APIs
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 2/2] doc: update release notes " patrick.fu
@ 2020-07-25 6:59 ` Xia, Chenbo
2020-07-28 9:06 ` Maxime Coquelin
1 sibling, 0 replies; 15+ messages in thread
From: Xia, Chenbo @ 2020-07-25 6:59 UTC (permalink / raw)
To: Fu, Patrick, dev, maxime.coquelin
> -----Original Message-----
> From: Fu, Patrick <patrick.fu@intel.com>
> Sent: Wednesday, July 22, 2020 11:02 PM
> To: dev@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo
> <chenbo.xia@intel.com>
> Cc: Fu, Patrick <patrick.fu@intel.com>
> Subject: [PATCH v2 2/2] doc: update release notes for vhost async APIs
>
> From: Patrick Fu <patrick.fu@intel.com>
>
> Update 20.08 release notes to include vhost async APIs
>
> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> ---
> doc/guides/rel_notes/release_20_08.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/release_20_08.rst
> b/doc/guides/rel_notes/release_20_08.rst
> index d65f77250..dc8936056 100644
> --- a/doc/guides/rel_notes/release_20_08.rst
> +++ b/doc/guides/rel_notes/release_20_08.rst
> @@ -243,6 +243,12 @@ New Features
> of ingress packets to specific NIC queues.
> See the :doc:`../sample_app_ug/ipsec_secgw` for more details.
>
> +* **Added vhost async data path APIs.**
> +
> + 4 new APIs have been added to enable vhost async data path, including:
> +
> + * Async device channel register/unregister APIs
> + * Async packets enqueue/completion APIs (only split ring was implemented)
>
> Removed Items
> -------------
> --
> 2.18.4
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 1/2] doc: update guides for vhost async APIs
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 1/2] doc: update guides " patrick.fu
2020-07-25 6:58 ` Xia, Chenbo
@ 2020-07-28 9:01 ` Maxime Coquelin
1 sibling, 0 replies; 15+ messages in thread
From: Maxime Coquelin @ 2020-07-28 9:01 UTC (permalink / raw)
To: patrick.fu, dev, chenbo.xia
On 7/22/20 5:01 PM, patrick.fu@intel.com wrote:
> From: Patrick Fu <patrick.fu@intel.com>
>
> Update vhost guides to document vhost async APIs
>
> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> ---
> doc/guides/prog_guide/vhost_lib.rst | 86 ++++++++++++++++++++++++++---
> 1 file changed, 77 insertions(+), 9 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 2/2] doc: update release notes for vhost async APIs
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 2/2] doc: update release notes " patrick.fu
2020-07-25 6:59 ` Xia, Chenbo
@ 2020-07-28 9:06 ` Maxime Coquelin
1 sibling, 0 replies; 15+ messages in thread
From: Maxime Coquelin @ 2020-07-28 9:06 UTC (permalink / raw)
To: patrick.fu, dev, chenbo.xia
On 7/22/20 5:01 PM, patrick.fu@intel.com wrote:
> From: Patrick Fu <patrick.fu@intel.com>
>
> Update 20.08 release notes to include vhost async APIs
>
> Signed-off-by: Patrick Fu <patrick.fu@intel.com>
> ---
> doc/guides/rel_notes/release_20_08.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst
> index d65f77250..dc8936056 100644
> --- a/doc/guides/rel_notes/release_20_08.rst
> +++ b/doc/guides/rel_notes/release_20_08.rst
> @@ -243,6 +243,12 @@ New Features
> of ingress packets to specific NIC queues.
> See the :doc:`../sample_app_ug/ipsec_secgw` for more details.
>
> +* **Added vhost async data path APIs.**
> +
> + 4 new APIs have been added to enable vhost async data path, including:
> +
> + * Async device channel register/unregister APIs
> + * Async packets enqueue/completion APIs (only split ring was implemented)
>
> Removed Items
> -------------
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [dpdk-dev] [PATCH v2 0/2] update docs for vhost async APIs
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 0/2] update docs " patrick.fu
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 1/2] doc: update guides " patrick.fu
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 2/2] doc: update release notes " patrick.fu
@ 2020-07-28 15:26 ` Maxime Coquelin
2 siblings, 0 replies; 15+ messages in thread
From: Maxime Coquelin @ 2020-07-28 15:26 UTC (permalink / raw)
To: patrick.fu, dev, chenbo.xia
On 7/22/20 5:01 PM, patrick.fu@intel.com wrote:
> From: Patrick Fu <patrick.fu@intel.com>
>
> update docs for vhost async APIs
>
> v2:
> - fix typos in vhost_lib.rst
> - minor rewording in vhost_lib.rst
> - add more detailed API notes in release notes
> - rebase the patch to 20.08 rc2
>
>
> Patrick Fu (2):
> doc: update guides for vhost async APIs
> doc: update release notes for vhost async APIs
>
> doc/guides/prog_guide/vhost_lib.rst | 86 +++++++++++++++++++++++---
> doc/guides/rel_notes/release_20_08.rst | 6 ++
> 2 files changed, 83 insertions(+), 9 deletions(-)
>
Applied to dpdk-next-virtio/master
Thanks!
Maxime
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2020-07-28 15:26 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-22 10:57 [dpdk-dev] [PATCH v1 0/2] update docs for vhost async API patrick.fu
2020-07-22 10:57 ` [dpdk-dev] [PATCH v1 1/2] doc: update guides for vhost async APIs patrick.fu
2020-07-22 11:21 ` Xia, Chenbo
2020-07-22 15:06 ` Fu, Patrick
2020-07-22 10:57 ` [dpdk-dev] [PATCH v1 2/2] doc: update release notes " patrick.fu
2020-07-22 11:25 ` Xia, Chenbo
2020-07-22 15:07 ` Fu, Patrick
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 0/2] update docs " patrick.fu
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 1/2] doc: update guides " patrick.fu
2020-07-25 6:58 ` Xia, Chenbo
2020-07-28 9:01 ` Maxime Coquelin
2020-07-22 15:01 ` [dpdk-dev] [PATCH v2 2/2] doc: update release notes " patrick.fu
2020-07-25 6:59 ` Xia, Chenbo
2020-07-28 9:06 ` Maxime Coquelin
2020-07-28 15:26 ` [dpdk-dev] [PATCH v2 0/2] update docs " Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).