DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Adrian Moreno <amorenoz@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Ye, Xiaolong" <xiaolong.ye@intel.com>,
	"shahafs@mellanox.com" <shahafs@mellanox.com>,
	"matan@mellanox.com" <matan@mellanox.com>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	"Wang, Xiao W" <xiao.w.wang@intel.com>,
	"viacheslavo@mellanox.com" <viacheslavo@mellanox.com>
Cc: "jasowang@redhat.com" <jasowang@redhat.com>,
	"lulu@redhat.com" <lulu@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v3 2/8] vhost: refactor Virtio ready check
Date: Tue, 7 Jul 2020 03:21:32 +0000
Message-ID: <MN2PR11MB40635CDE7641F63E2999A7729C660@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200706112452.1474533-3-amorenoz@redhat.com>


> -----Original Message-----
> From: Adrian Moreno <amorenoz@redhat.com>
> Sent: Monday, July 6, 2020 7:25 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Ye, Xiaolong
> <xiaolong.ye@intel.com>; shahafs@mellanox.com; matan@mellanox.com;
> maxime.coquelin@redhat.com; Wang, Xiao W <xiao.w.wang@intel.com>;
> viacheslavo@mellanox.com
> Cc: jasowang@redhat.com; lulu@redhat.com
> Subject: [PATCH v3 2/8] vhost: refactor Virtio ready check
> 
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> This patch is a small refactoring, as preliminary work for adding support to Virtio
> status support.
> 
> No functionnal change here.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  lib/librte_vhost/vhost.c      |  1 +
>  lib/librte_vhost/vhost_user.c | 33 +++++++++++++++++++++------------
>  2 files changed, 22 insertions(+), 12 deletions(-)
> 
> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c index
> 0d822d6a3..aa1424261 100644
> --- a/lib/librte_vhost/vhost.c
> +++ b/lib/librte_vhost/vhost.c
> @@ -710,6 +710,7 @@ vhost_enable_dequeue_zero_copy(int vid)
>  		return;
> 
>  	dev->dequeue_zero_copy = 1;
> +	VHOST_LOG_CONFIG(INFO, "dequeue zero copy is enabled\n");
>  }
> 
>  void
> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index
> 5750dde6d..ff8b1752b 100644
> --- a/lib/librte_vhost/vhost_user.c
> +++ b/lib/librte_vhost/vhost_user.c
> @@ -1337,6 +1337,9 @@ virtio_is_ready(struct virtio_net *dev)
>  	struct vhost_virtqueue *vq;
>  	uint32_t i;
> 
> +	if (dev->flags & VIRTIO_DEV_READY)
> +		return 1;
> +
>  	if (dev->nr_vring < VIRTIO_DEV_NUM_VQS_TO_BE_READY)
>  		return 0;
> 
> @@ -1347,6 +1350,8 @@ virtio_is_ready(struct virtio_net *dev)
>  			return 0;
>  	}
> 
> +	dev->flags |= VIRTIO_DEV_READY;
> +
>  	if (!(dev->flags & VIRTIO_DEV_RUNNING))
>  		VHOST_LOG_CONFIG(INFO,
>  			"virtio is now ready for processing.\n"); @@ -2825,28
> +2830,32 @@ vhost_user_msg_handler(int vid, int fd)
>  	}
> 
> 
> -	if (!(dev->flags & VIRTIO_DEV_READY) && virtio_is_ready(dev)) {
> -		dev->flags |= VIRTIO_DEV_READY;
> +	if (!virtio_is_ready(dev))
> +		goto out;
> 
> -		if (!(dev->flags & VIRTIO_DEV_RUNNING)) {
> -			if (dev->dequeue_zero_copy) {
> -				VHOST_LOG_CONFIG(INFO,
> -						"dequeue zero copy is
> enabled\n");
> -			}
> +	/*
> +	 * Virtio is now ready. If not done already, it is time
> +	 * to notify the application it can process the rings and
> +	 * configure the vDPA device if present.
> +	 */
> 
> -			if (dev->notify_ops->new_device(dev->vid) == 0)
> -				dev->flags |= VIRTIO_DEV_RUNNING;
> -		}
> +	if (!(dev->flags & VIRTIO_DEV_RUNNING)) {
> +		if (dev->notify_ops->new_device(dev->vid) == 0)
> +			dev->flags |= VIRTIO_DEV_RUNNING;
>  	}
> 
>  	vdpa_dev = dev->vdpa_dev;
> -	if (vdpa_dev && virtio_is_ready(dev) &&
> -	    !(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) {
> +	if (!vdpa_dev)
> +		goto out;
> +
> +	if (!(dev->flags & VIRTIO_DEV_VDPA_CONFIGURED)) {
>  		if (vdpa_dev->ops->dev_conf)
>  			vdpa_dev->ops->dev_conf(dev->vid);
> +
>  		dev->flags |= VIRTIO_DEV_VDPA_CONFIGURED;
>  	}
> 
> +out:
>  	return 0;
>  }
> 
> --
> 2.26.2

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

  reply	other threads:[~2020-07-07  3:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06 11:24 [dpdk-dev] [PATCH (v20.08) v3 0/8] vhost: improve Vhost/vDPA device init Adrian Moreno
2020-07-06 11:24 ` [dpdk-dev] [PATCH v3 1/8] vhost: fix virtio ready flag check Adrian Moreno
2020-07-07  3:21   ` Xia, Chenbo
2020-07-08 14:22     ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-07-06 11:24 ` [dpdk-dev] [PATCH v3 2/8] vhost: refactor Virtio ready check Adrian Moreno
2020-07-07  3:21   ` Xia, Chenbo [this message]
2020-07-06 11:24 ` [dpdk-dev] [PATCH v3 3/8] vhost: make some vDPA callbacks mandatory Adrian Moreno
2020-07-07  3:21   ` Xia, Chenbo
2020-07-06 11:24 ` [dpdk-dev] [PATCH v3 4/8] vhost: check vDPA configuration succeed Adrian Moreno
2020-07-07  3:22   ` Xia, Chenbo
2020-07-08 13:20   ` Ferruh Yigit
2020-07-06 11:24 ` [dpdk-dev] [PATCH v3 5/8] vhost: add support for virtio status Adrian Moreno
2020-07-07  3:22   ` Xia, Chenbo
2020-07-06 11:24 ` [dpdk-dev] [PATCH v3 6/8] vhost: add support for virtio get status message Adrian Moreno
2020-07-07  3:22   ` Xia, Chenbo
2020-07-06 11:24 ` [dpdk-dev] [PATCH v3 7/8] vdpa/ifc: enable status protocol feature Adrian Moreno
2020-07-07  3:22   ` Xia, Chenbo
2020-07-06 11:24 ` [dpdk-dev] [PATCH v3 8/8] vdpa/mlx5: " Adrian Moreno
2020-07-07  3:23   ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN2PR11MB40635CDE7641F63E2999A7729C660@MN2PR11MB4063.namprd11.prod.outlook.com \
    --to=chenbo.xia@intel.com \
    --cc=amorenoz@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jasowang@redhat.com \
    --cc=lulu@redhat.com \
    --cc=matan@mellanox.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=shahafs@mellanox.com \
    --cc=viacheslavo@mellanox.com \
    --cc=xiao.w.wang@intel.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git