Re: [dpdk-dev] [PATCH v3 1/8] vhost: fix virtio ready flag check

["Xia, Chenbo" <chenbo.xia@intel.com>]

> -----Original Message-----
> From: Adrian Moreno <amorenoz@redhat.com>
> Sent: Monday, July 6, 2020 7:25 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Ye, Xiaolong
> <xiaolong.ye@intel.com>; shahafs@mellanox.com; matan@mellanox.com;
> maxime.coquelin@redhat.com; Wang, Xiao W <xiao.w.wang@intel.com>;
> viacheslavo@mellanox.com
> Cc: jasowang@redhat.com; lulu@redhat.com; stable@dpdk.org
> Subject: [PATCH v3 1/8] vhost: fix virtio ready flag check
> 
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Before checking whether the device is ready is done a check on whether the
> RUNNING flag is set. Then the READY flag is set if virtio_is_ready() returns true.
> 
> While it seems to not cause any issue, it makes more sense to check whether the
> READY flag is set and not the RUNNING one.
> 
> Fixes: c0674b1bc898 ("vhost: move the device ready check at proper place")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  lib/librte_vhost/vhost_user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index
> 6039a8fdb..5750dde6d 100644
> --- a/lib/librte_vhost/vhost_user.c
> +++ b/lib/librte_vhost/vhost_user.c
> @@ -2825,7 +2825,7 @@ vhost_user_msg_handler(int vid, int fd)
>  	}
> 
> 
> -	if (!(dev->flags & VIRTIO_DEV_RUNNING) && virtio_is_ready(dev)) {
> +	if (!(dev->flags & VIRTIO_DEV_READY) && virtio_is_ready(dev)) {
>  		dev->flags |= VIRTIO_DEV_READY;
> 
>  		if (!(dev->flags & VIRTIO_DEV_RUNNING)) {
> --
> 2.26.2

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>