From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: "Hu, Jiayu" <jiayu.hu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v4 3/3] vhost: add thread unsafe async registeration functions
Date: Fri, 16 Jul 2021 06:54:11 +0000 [thread overview]
Message-ID: <MN2PR11MB40636F9EB834D8108B69504F9C119@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1626162383-89674-4-git-send-email-jiayu.hu@intel.com>
Hi Jiayu,
> -----Original Message-----
> From: Hu, Jiayu <jiayu.hu@intel.com>
> Sent: Tuesday, July 13, 2021 3:46 PM
> To: dev@dpdk.org
> Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>; Hu, Jiayu
> <jiayu.hu@intel.com>
> Subject: [PATCH v4 3/3] vhost: add thread unsafe async registeration functions
>
> This patch adds thread unsafe version for async register and
> unregister functions.
>
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> ---
> doc/guides/prog_guide/vhost_lib.rst | 12 +++
> lib/vhost/rte_vhost_async.h | 39 ++++++++++
> lib/vhost/version.map | 4 +
> lib/vhost/vhost.c | 146 +++++++++++++++++++++++++++--------
> -
> 4 files changed, 167 insertions(+), 34 deletions(-)
>
> diff --git a/doc/guides/prog_guide/vhost_lib.rst
> b/doc/guides/prog_guide/vhost_lib.rst
> index affdc57..ffe09a3 100644
> --- a/doc/guides/prog_guide/vhost_lib.rst
> +++ b/doc/guides/prog_guide/vhost_lib.rst
> @@ -256,6 +256,12 @@ The following is an overview of some key Vhost API
> functions:
> vhost invokes this function to get the copy data completed by async
> devices.
>
> +* ``rte_vhost_async_channel_register_thread_unsafe(vid, queue_id, config,
> ops)``
> + Register a vhost queue with async copy device channel without
'Register an async copy device channel for a vhost queue' sounds better
> + performing any locking.
> +
> + This function is only safe to call from within vhost callback functions.
call in vhost callback functions?
> +
> * ``rte_vhost_async_channel_unregister(vid, queue_id)``
>
> Unregister the async copy device channel from a vhost queue.
> @@ -268,6 +274,12 @@ The following is an overview of some key Vhost API
> functions:
> devices for all vhost queues in destroy_device(), when a
> virtio device is paused or shut down.
>
> +* ``rte_vhost_async_channel_unregister_thread_unsafe(vid, queue_id)``
> + Unregister the async copy device channel from a vhost queue without
for a vhost queue?
> + performing any locking.
> +
> + This function is only safe to call from within vhost callback functions.
Call in vhost callback functions?
And let's make it clearer. Add this: (i.e., struct vhost_device_ops)
> +
> * ``rte_vhost_submit_enqueue_burst(vid, queue_id, pkts, count, comp_pkts,
> comp_count)``
>
> Submit an enqueue request to transmit ``count`` packets from host to guest
> diff --git a/lib/vhost/rte_vhost_async.h b/lib/vhost/rte_vhost_async.h
> index c93490d..e4d20a3 100644
> --- a/lib/vhost/rte_vhost_async.h
> +++ b/lib/vhost/rte_vhost_async.h
> @@ -142,6 +142,45 @@ __rte_experimental
> int rte_vhost_async_channel_unregister(int vid, uint16_t queue_id);
>
> /**
> + * register an async channel for vhost without performing any locking
register -> Register
for vhost -> for a vhost queue
> + *
> + * @note This function does not perform any locking, and is only safe to call
> + * from within vhost callback functions.
From within -> in ?
> + *
> + * @param vid
> + * vhost device id async channel to be attached to
> + * @param queue_id
> + * vhost queue id async channel to be attached to
> + * @param config
> + * DMA channel configuration
DMA -> async?
> + * @param ops
> + * DMA operation callbacks
Async channel operation callbacks?
> + * @return
> + * 0 on success, -1 on failures
> + */
> +__rte_experimental
> +int rte_vhost_async_channel_register_thread_unsafe(int vid, uint16_t queue_id,
According to DPDK coding style. Return value should not be in the same line
of the function name. Just make a new line for it. Please check other functions like
unregister.
> + struct rte_vhost_async_config config,
> + struct rte_vhost_async_channel_ops *ops);
> +
> +/**
> + * unregister a dma channel for vhost without performing any lock
Unregister an async channel for a vhost queue
> + *
> + * @note This function does not perform any locking, and is only safe to call
> + * from within vhost callback functions.
in vhost callback functions
> + *
> + * @param vid
> + * vhost device id DMA channel to be detached
Vhost device id Async channel to be detached from
> + * @param queue_id
> + * vhost queue id DMA channel to be detached
Ditto
> + * @return
> + * 0 on success, -1 on failures
> + */
> --
> 2.7.4
next prev parent reply other threads:[~2021-07-16 6:54 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 8:11 [dpdk-dev] [PATCH 0/2] provide thread unsafe async registration functions Jiayu Hu
2021-05-28 8:11 ` [dpdk-dev] [PATCH 1/2] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-02 7:36 ` Maxime Coquelin
2021-07-07 11:18 ` [dpdk-dev] [PATCH v2 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-07 11:18 ` [dpdk-dev] [PATCH v2 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-09 9:43 ` [dpdk-dev] [PATCH v3 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-09 9:43 ` [dpdk-dev] [PATCH v3 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-13 7:46 ` [dpdk-dev] [PATCH v4 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-13 7:46 ` [dpdk-dev] [PATCH v4 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-16 19:51 ` [dpdk-dev] [PATCH v5 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-16 19:51 ` [dpdk-dev] [PATCH v5 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-19 15:00 ` [dpdk-dev] [PATCH v6 0/3] provide thread unsafe async registration functions Jiayu Hu
2021-07-19 15:00 ` [dpdk-dev] [PATCH v6 1/3] vhost: fix lock on device readiness notification Jiayu Hu
2021-07-19 15:00 ` [dpdk-dev] [PATCH v6 2/3] vhost: rework async configuration structure Jiayu Hu
2021-07-20 7:18 ` Maxime Coquelin
2021-07-20 7:45 ` Hu, Jiayu
2021-07-19 15:00 ` [dpdk-dev] [PATCH v6 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-07-20 7:25 ` Maxime Coquelin
2021-07-21 6:16 ` [dpdk-dev] [PATCH v6 0/3] provide thread unsafe async registration functions Xia, Chenbo
2021-07-16 19:51 ` [dpdk-dev] [PATCH v5 2/3] vhost: rework async configuration structure Jiayu Hu
2021-07-19 2:25 ` Xia, Chenbo
2021-07-19 7:20 ` Maxime Coquelin
2021-07-16 19:51 ` [dpdk-dev] [PATCH v5 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-07-19 2:27 ` Xia, Chenbo
2021-07-13 7:46 ` [dpdk-dev] [PATCH v4 2/3] vhost: rework async configuration struct Jiayu Hu
2021-07-16 6:03 ` Xia, Chenbo
2021-07-16 6:18 ` Hu, Jiayu
2021-07-16 6:27 ` Xia, Chenbo
2021-07-16 6:34 ` Hu, Jiayu
2021-07-13 7:46 ` [dpdk-dev] [PATCH v4 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-07-16 6:54 ` Xia, Chenbo [this message]
2021-07-09 9:43 ` [dpdk-dev] [PATCH v3 2/3] vhost: rework async configuration struct Jiayu Hu
2021-07-09 9:43 ` [dpdk-dev] [PATCH v3 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-07-07 11:18 ` [dpdk-dev] [PATCH v2 2/3] vhost: rework async feature struct Jiayu Hu
2021-07-07 6:39 ` Maxime Coquelin
2021-07-07 11:18 ` [dpdk-dev] [PATCH v2 3/3] vhost: add thread unsafe async registeration functions Jiayu Hu
2021-05-28 8:11 ` [dpdk-dev] [PATCH 2/2] vhost: add thread unsafe async registration functions Jiayu Hu
2021-07-02 7:40 ` Maxime Coquelin
2021-07-05 1:35 ` Hu, Jiayu
2021-07-05 8:58 ` Maxime Coquelin
2021-07-06 8:36 ` Hu, Jiayu
2021-06-04 7:18 ` [dpdk-dev] [PATCH 0/2] provide " Maxime Coquelin
2021-06-04 7:24 ` Maxime Coquelin
2021-06-07 8:07 ` Hu, Jiayu
2021-06-07 13:20 ` Maxime Coquelin
2021-06-08 6:36 ` Hu, Jiayu
2021-06-29 5:36 ` Hu, Jiayu
2021-07-01 15:42 ` Maxime Coquelin
2021-07-02 0:53 ` Hu, Jiayu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB40636F9EB834D8108B69504F9C119@MN2PR11MB4063.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=jiayu.hu@intel.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).