DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v3 0/3] vhost: make virtqueue cache-friendly
@ 2021-03-17 17:09 Maxime Coquelin
  2021-03-17 17:09 ` [dpdk-dev] [PATCH v3 1/3] vhost: remove unused Vhost virtqueue field Maxime Coquelin
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Maxime Coquelin @ 2021-03-17 17:09 UTC (permalink / raw)
  To: dev, chenbo.xia, amorenoz, david.marchand, olivier.matz, bnemeth
  Cc: Maxime Coquelin

As done for Virtio PMD, this series improves cache utilization
of the vhost_virtqueue struct by removing unused field,
make the live-migration cache dynamically allocated at
live-migration setup time and by moving fields
around so that hot fields are on the first cachelines.

With this series, The struct vhost_virtqueue size goes
from 832B (13 cachelines) down to 320B (5 cachelines).

With this series and the virtio one, I measure a gain
of up to 8% in IO loop micro-benchmark with packed
ring, and 5% with split ring.

I don't have a setup at hand to run PVP testing, but
it might be interresting to get the numbers as I
suspect the cache pressure is higher in this test as
in real use-cases.

Changes in v3:
==============
- Don't check pointer validity before freeing (David)
- Don't use deprecated rte_smp_wmb() (David, Checkpatch)
- Handle booleans properly (David)
- Prevent VQ size field overflow (David)
- Fix typo and indent (David)

Changes in v2:
==============
- Add log_cache freeing in free_vq (Chenbo)

Maxime Coquelin (3):
  vhost: remove unused Vhost virtqueue field
  vhost: move dirty logging cache out of the virtqueue
  vhost: optimize vhost virtqueue struct

 lib/librte_vhost/vhost.c      | 21 +++++++++----
 lib/librte_vhost/vhost.h      | 56 +++++++++++++++++------------------
 lib/librte_vhost/vhost_user.c | 40 ++++++++++++++++++-------
 lib/librte_vhost/virtio_net.c | 12 ++++----
 4 files changed, 80 insertions(+), 49 deletions(-)

-- 
2.30.2


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-03-23  8:52 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17 17:09 [dpdk-dev] [PATCH v3 0/3] vhost: make virtqueue cache-friendly Maxime Coquelin
2021-03-17 17:09 ` [dpdk-dev] [PATCH v3 1/3] vhost: remove unused Vhost virtqueue field Maxime Coquelin
2021-03-17 17:09 ` [dpdk-dev] [PATCH v3 2/3] vhost: move dirty logging cache out of the virtqueue Maxime Coquelin
2021-03-18  3:24   ` Xia, Chenbo
2021-03-17 17:09 ` [dpdk-dev] [PATCH v3 3/3] vhost: optimize vhost virtqueue struct Maxime Coquelin
2021-03-18  3:23   ` Xia, Chenbo
2021-03-23  8:51     ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).