From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Adrian Moreno <amorenoz@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>,
"Li, Miao" <miao.li@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit
Date: Thu, 16 Jul 2020 08:14:19 +0000 [thread overview]
Message-ID: <MN2PR11MB4063EEF1BB046762630A9C1D9C7F0@MN2PR11MB4063.namprd11.prod.outlook.com> (raw)
In-Reply-To: <40eae877-1b4a-2eb4-52d5-de115b2811e1@redhat.com>
Hi Adrian,
> -----Original Message-----
> From: Adrian Moreno <amorenoz@redhat.com>
> Sent: Thursday, July 16, 2020 3:34 PM
> To: Xia, Chenbo <chenbo.xia@intel.com>; dev@dpdk.org
> Cc: maxime.coquelin@redhat.com; Wang, Zhihong <zhihong.wang@intel.com>;
> Li, Miao <miao.li@intel.com>
> Subject: Re: [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit
>
> Hi,
>
> On 7/16/20 4:26 AM, Xia, Chenbo wrote:
> > Hi Adrian,
> >
> >> -----Original Message-----
> >> From: Adrian Moreno <amorenoz@redhat.com>
> >> Sent: Thursday, July 16, 2020 1:18 AM
> >> To: dev@dpdk.org
> >> Cc: maxime.coquelin@redhat.com; Wang, Zhihong
> >> <zhihong.wang@intel.com>; amorenoz@redhat.com; Xia, Chenbo
> >> <chenbo.xia@intel.com>
> >> Subject: [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit
> >>
> >> For the sake of completeness, add the definition of the missing
> >> status bit in accordance with the virtio spec
> >>
> >> Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
> >> ---
> >> drivers/net/virtio/virtio_pci.h | 13 +++++++------
> >> 1 file changed, 7 insertions(+), 6 deletions(-)
> >>
> >> diff --git a/drivers/net/virtio/virtio_pci.h
> >> b/drivers/net/virtio/virtio_pci.h index 74ed77e33..ab61e911b 100644
> >> --- a/drivers/net/virtio/virtio_pci.h
> >> +++ b/drivers/net/virtio/virtio_pci.h
> >> @@ -57,12 +57,13 @@ struct virtnet_ctl;
> >> #define VIRTIO_ID_9P 0x09
> >>
> >> /* Status byte for guest to report progress. */
> >> -#define VIRTIO_CONFIG_STATUS_RESET 0x00
> >> -#define VIRTIO_CONFIG_STATUS_ACK 0x01
> >> -#define VIRTIO_CONFIG_STATUS_DRIVER 0x02
> >> -#define VIRTIO_CONFIG_STATUS_DRIVER_OK 0x04 -#define
> >> VIRTIO_CONFIG_STATUS_FEATURES_OK 0x08
> >> -#define VIRTIO_CONFIG_STATUS_FAILED 0x80
> >> +#define VIRTIO_CONFIG_STATUS_RESET 0x00
> >> +#define VIRTIO_CONFIG_STATUS_ACK 0x01
> >> +#define VIRTIO_CONFIG_STATUS_DRIVER 0x02
> >> +#define VIRTIO_CONFIG_STATUS_DRIVER_OK 0x04
> >> +#define VIRTIO_CONFIG_STATUS_FEATURES_OK 0x08
> >> +#define VIRTIO_CONFIG_STATUS_DEV_NEED_RESET 0x40
> >> +#define VIRTIO_CONFIG_STATUS_FAILED 0x80
> >
> > Do we need to delete ' VIRTIO_CONFIG_STATUS_RESET'? I see vhost lib
> > does not have it now. And I read virtio 1.1 spec and find the
> > description of writing 0 to reset device is deleted. I think virtio 1.1 spec is not
> very clear about reset status.
> > Does 'DEV_NEED_RESET' equal old 'RESET'?
> >
> In virtio 1.1
> "2.1.2 Device Requirements: Device Status Field
>
> The device MUST initialize device status to 0 upon reset.
> ...
> "
> So I think having "#define VIRTIO_CONFIG_STATUS_RESET 0x00" is still useful to
> understand what is going on in:
>
> void
> vtpci_reset(struct virtio_hw *hw)
> {
> VTPCI_OPS(hw)->set_status(hw, VIRTIO_CONFIG_STATUS_RESET);
> /* flush status write */
> VTPCI_OPS(hw)->get_status(hw);
> }
>
> DEV_NEED_RESET is used for the device to notify that it has encountered an
> unrecoverable error. Therefore, the driver would never
> "set_status(VIRTIO_CONFIG_STATUS_DEV_NEED_RESET)"; instead, it should
> read the status and if this bit is set, reset the device.
Yes, you are correct! I missed that part. Btw, should we add STATUS_RESET to
Vhost lib? I see there's no reset status now.
Thanks!
Chenbo
>
>
> > Thanks!
> > Chenbo
> >
> >>
> >> /*
> >> * Each virtqueue indirect descriptor list must be physically contiguous.
> >> --
> >> 2.26.2
> >
>
> --
> Adrián Moreno
next prev parent reply other threads:[~2020-07-16 8:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 17:18 [dpdk-dev] [PATCH 0/5] Add support for GET/SET_STATUS on virtio-user pmd Adrian Moreno
2020-07-15 17:18 ` [dpdk-dev] [PATCH 1/5] net/virtio: split virtio-net and virtio status Adrian Moreno
2020-07-15 17:18 ` [dpdk-dev] [PATCH 2/5] net/virtio: add DEVICE_NEEDS_RESET status bit Adrian Moreno
2020-07-16 2:26 ` Xia, Chenbo
2020-07-16 7:34 ` Adrian Moreno
2020-07-16 8:14 ` Xia, Chenbo [this message]
2020-07-15 17:18 ` [dpdk-dev] [PATCH 3/5] net/virtio: add VIRTIO_SET_STATUS support to Virtio-user Adrian Moreno
2020-07-16 3:15 ` Xia, Chenbo
2020-07-16 7:43 ` Adrian Moreno
2020-07-16 8:58 ` Xia, Chenbo
2020-07-16 9:51 ` Adrian Moreno
2020-07-16 11:18 ` Xia, Chenbo
2020-07-15 17:18 ` [dpdk-dev] [PATCH 4/5] net/virtio: add GET_STATUS support to virtio-user Adrian Moreno
2020-07-16 3:31 ` Xia, Chenbo
2020-07-16 7:53 ` Adrian Moreno
2020-07-16 8:18 ` David Marchand
2020-07-16 8:28 ` Adrian Moreno
2020-07-15 17:18 ` [dpdk-dev] [PATCH 5/5] net/virtio: enable feature checking on virtio-user Adrian Moreno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB4063EEF1BB046762630A9C1D9C7F0@MN2PR11MB4063.namprd11.prod.outlook.com \
--to=chenbo.xia@intel.com \
--cc=amorenoz@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=miao.li@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).