From: "Chen, Mike Ximing" <mike.ximing.chen@intel.com> To: "Power, Ciara" <ciara.power@intel.com>, Jerin Jacob <jerinj@marvell.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "Eads, Gage" <gage.eads@intel.com>, "Vedantham, Sundar" <sundar.vedantham@intel.com>, "Richardson, Bruce" <bruce.richardson@intel.com> Subject: Re: [dpdk-dev] [PATCH] eventdev: support telemetry with xstats info Date: Thu, 17 Sep 2020 14:18:31 +0000 Message-ID: <MN2PR11MB4431EC2466750E9C440A5C03D93E0@MN2PR11MB4431.namprd11.prod.outlook.com> (raw) In-Reply-To: <DM6PR11MB255535CBE425C7CD161B9AC6E63E0@DM6PR11MB2555.namprd11.prod.outlook.com> Hi Ciara, Thanks for identifying the issue. For some reasons, the problem did not show up in my previous tests with telemetry and eventdev. I will fix the bug as we discussed and upload a v2 patch. Best Regards, Mike -----Original Message----- From: Power, Ciara <ciara.power@intel.com> Sent: Thursday, September 17, 2020 5:05 AM To: Chen, Mike Ximing <mike.ximing.chen@intel.com>; Jerin Jacob <jerinj@marvell.com> Cc: dev@dpdk.org; Eads, Gage <gage.eads@intel.com>; Vedantham, Sundar <sundar.vedantham@intel.com>; Richardson, Bruce <bruce.richardson@intel.com> Subject: RE: [PATCH] eventdev: support telemetry with xstats info Hi Mike, See comment inline. Asides from that comment, overall the change looks good from a Telemetry usage point of view, in my opinion. Thanks, Ciara >-----Original Message----- >From: Chen, Mike Ximing <mike.ximing.chen@intel.com> >Sent: Wednesday 9 September 2020 21:55 >To: Jerin Jacob <jerinj@marvell.com> >Cc: dev@dpdk.org; Eads, Gage <gage.eads@intel.com>; Vedantham, Sundar ><sundar.vedantham@intel.com>; Power, Ciara <ciara.power@intel.com>; >Richardson, Bruce <bruce.richardson@intel.com>; Chen, Mike Ximing ><mike.ximing.chen@intel.com> >Subject: [PATCH] eventdev: support telemetry with xstats info > >The telemetry library is connected with eventdev xstats and port link >info. The following new telemetry commands are added: > >/eventdev/dev_list >/eventdev/port_list,DevID >/eventdev/queue_list,DevID >/eventdev/dev_xstats,DevID >/eventdev/port_xstats,DevID,PortID >/eventdev/queue_xstats,DevID,PortID >/eventdev/queue_links,DevID,PortID > >queue_links command displays a list of queues linked with a specified >eventdev port and a service priority associated with each link. > >Signed-off-by: Mike Ximing Chen <mike.ximing.chen@intel.com> >--- >Depends-on: patch-76075 ("lib/telemetry: fix passing full params string >to >command") >--- > lib/librte_eventdev/meson.build | 1 + > lib/librte_eventdev/rte_eventdev.c | 304 +++++++++++++++++++++++++++++ > 2 files changed, 305 insertions(+) <snip> >+ >+static int >+handle_queue_links(const char *cmd __rte_unused, >+ const char *params, >+ struct rte_tel_data *d) >+{ >+ int i, ret, port_id = 0; >+ char *end_param; >+ uint8_t dev_id; >+ uint8_t queues[RTE_EVENT_MAX_QUEUES_PER_DEV]; >+ uint8_t priorities[RTE_EVENT_MAX_QUEUES_PER_DEV]; >+ const char *p_param; >+ >+ if (params == NULL || strlen(params) == 0 || !isdigit(*params)) >+ return -1; >+ >+ /* Get dev ID from parameter string */ >+ dev_id = strtoul(params, &end_param, 10); >+ RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); >+ >+ p_param = strtok(end_param, ","); >+ if (p_param == NULL || strlen(p_param) == 0 || !isdigit(*p_param)) >+ return -1; >+ >+ port_id = strtoul(p_param, &end_param, 10); >+ p_param = strtok(NULL, "\0"); >+ if (*p_param != '\0') >+ RTE_EDEV_LOG_DEBUG( >+ "Extra parameters passed to eventdev telemetry >command, ignoring"); The code above to parse the parameters doesn't look right to me - I think in the case of valid parameters being passed (e.g. "0,2"), there would be a seg fault at this condition check on p_param. This applies to the other handler functions here that follow similar steps also. >+ >+ ret = rte_event_port_links_get(dev_id, port_id, queues, priorities); >+ if (ret < 0) >+ return -1; >+ >+ rte_tel_data_start_dict(d); >+ for (i = 0; i < ret; i++) { >+ char qid_name[32]; >+ >+ snprintf(qid_name, 31, "qid_%u", queues[i]); >+ rte_tel_data_add_dict_u64(d, qid_name, priorities[i]); >+ } >+ >+ return 0; >+} <snip>
next prev parent reply other threads:[~2020-09-17 14:24 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-09 20:54 Chen, Mike Ximing 2020-09-17 9:04 ` Power, Ciara 2020-09-17 14:18 ` Chen, Mike Ximing [this message] 2020-09-18 17:39 ` [dpdk-dev] [PATCH v3] " Mike Ximing Chen 2020-09-21 10:16 ` Power, Ciara 2020-09-22 19:04 ` Eads, Gage 2020-10-04 9:32 ` Jerin Jacob
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MN2PR11MB4431EC2466750E9C440A5C03D93E0@MN2PR11MB4431.namprd11.prod.outlook.com \ --to=mike.ximing.chen@intel.com \ --cc=bruce.richardson@intel.com \ --cc=ciara.power@intel.com \ --cc=dev@dpdk.org \ --cc=gage.eads@intel.com \ --cc=jerinj@marvell.com \ --cc=sundar.vedantham@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git