DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Power, Ciara" <ciara.power@intel.com>
To: "Chen, Mike Ximing" <mike.ximing.chen@intel.com>,
	Jerin Jacob <jerinj@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Eads, Gage" <gage.eads@intel.com>,
	"Vedantham, Sundar" <sundar.vedantham@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] eventdev: support telemetry with xstats info
Date: Mon, 21 Sep 2020 10:16:49 +0000
Message-ID: <DM6PR11MB25557DDA8D875C5E07F1527FE63A0@DM6PR11MB2555.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200918173922.25495-1-mike.ximing.chen@intel.com>

>-----Original Message-----
>From: Chen, Mike Ximing <mike.ximing.chen@intel.com>
>Sent: Friday 18 September 2020 18:39
>To: Jerin Jacob <jerinj@marvell.com>
>Cc: dev@dpdk.org; Eads, Gage <gage.eads@intel.com>; Vedantham, Sundar
><sundar.vedantham@intel.com>; Power, Ciara <ciara.power@intel.com>;
>Richardson, Bruce <bruce.richardson@intel.com>
>Subject: [PATCH v3] eventdev: support telemetry with xstats info
>
>The telemetry library is connected with eventdev xstats and port link info. The
>following new telemetry commands are added:
>
>/eventdev/dev_list
>/eventdev/port_list,DevID
>/eventdev/queue_list,DevID
>/eventdev/dev_xstats,DevID
>/eventdev/port_xstats,DevID,PortID
>/eventdev/queue_xstats,DevID,PortID
>/eventdev/queue_links,DevID,PortID
>
>queue_links command displays a list of queues linked with a specified
>eventdev port and a service priority associated with each link.
>
>Signed-off-by: Mike Ximing Chen <mike.ximing.chen@intel.com>
>---
>Depends-on: patch-76075 ("lib/telemetry: fix passing full params string to
>command")
>---
>v2:
>* Fixed an issue with p_param in handles.
>
>v3:
>* No code change.
>* Add --in-reply-to v1 patch.
>---
> lib/librte_eventdev/meson.build    |   1 +
> lib/librte_eventdev/rte_eventdev.c | 304 +++++++++++++++++++++++++++++
> 2 files changed, 305 insertions(+)
>

<snip>

>+static int
>+handle_queue_links(const char *cmd __rte_unused,
>+		   const char *params,
>+		   struct rte_tel_data *d)
>+{
>+	int i, ret, port_id = 0;
>+	char *end_param;
>+	uint8_t dev_id;
>+	uint8_t queues[RTE_EVENT_MAX_QUEUES_PER_DEV];
>+	uint8_t priorities[RTE_EVENT_MAX_QUEUES_PER_DEV];
>+	const char *p_param;
>+
>+	if (params == NULL || strlen(params) == 0 || !isdigit(*params))
>+		return -1;
>+
>+	/* Get dev ID from parameter string */
>+	dev_id = strtoul(params, &end_param, 10);
>+	RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
>+
>+	p_param = strtok(end_param, ",");
>+	if (p_param == NULL || strlen(p_param) == 0 || !isdigit(*p_param))
>+		return -1;
>+
>+	port_id = strtoul(p_param, &end_param, 10);
>+	p_param = strtok(NULL, "\0");
>+	if (p_param != NULL)
>+		RTE_EDEV_LOG_DEBUG(
>+			"Extra parameters passed to eventdev telemetry
>command, ignoring");
>+

<snip>

This fix avoids the seg fault I previously mentioned, looks fine to me.

Reviewed-by: Ciara Power <ciara.power@intel.com>

  reply	other threads:[~2020-09-21 10:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 20:54 [dpdk-dev] [PATCH] " Chen, Mike Ximing
2020-09-17  9:04 ` Power, Ciara
2020-09-17 14:18   ` Chen, Mike Ximing
2020-09-18 17:39 ` [dpdk-dev] [PATCH v3] " Mike Ximing Chen
2020-09-21 10:16   ` Power, Ciara [this message]
2020-09-22 19:04   ` Eads, Gage
2020-10-04  9:32     ` Jerin Jacob
2020-09-29 19:12 Bruni, Jesse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB25557DDA8D875C5E07F1527FE63A0@DM6PR11MB2555.namprd11.prod.outlook.com \
    --to=ciara.power@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=jerinj@marvell.com \
    --cc=mike.ximing.chen@intel.com \
    --cc=sundar.vedantham@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git