From: Bing Zhao <bingz@nvidia.com> To: Ferruh Yigit <ferruh.yigit@intel.com>, Ori Kam <orika@nvidia.com>, NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>, Matan Azrad <matan@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com> Cc: "dev@dpdk.org" <dev@dpdk.org>, "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>, Gregory Etelson <getelson@nvidia.com>, Andrey Vesnovaty <andreyv@nvidia.com> Subject: Re: [dpdk-dev] [PATCH v2 0/4] Change shared action API to action handle API Date: Tue, 13 Apr 2021 01:22:53 +0000 Message-ID: <MN2PR12MB2909D15251F6D23227D2EF9FD04F9@MN2PR12MB2909.namprd12.prod.outlook.com> (raw) In-Reply-To: <6a3f87b5-2b30-3f8c-7a31-c55eeaa0a834@intel.com> Hi Ferruh, Thanks for your comments. > -----Original Message----- > From: Ferruh Yigit <ferruh.yigit@intel.com> > Sent: Tuesday, April 13, 2021 3:40 AM > To: Bing Zhao <bingz@nvidia.com>; Ori Kam <orika@nvidia.com>; NBU- > Contact-Thomas Monjalon <thomas@monjalon.net>; > andrew.rybchenko@oktetlabs.ru; Matan Azrad <matan@nvidia.com>; Slava > Ovsiienko <viacheslavo@nvidia.com> > Cc: dev@dpdk.org; ajit.khaparde@broadcom.com; Gregory Etelson > <getelson@nvidia.com>; Andrey Vesnovaty <andreyv@nvidia.com> > Subject: Re: [PATCH v2 0/4] Change shared action API to action > handle API > > External email: Use caution opening links or attachments > > > On 4/10/2021 3:03 PM, Bing Zhao wrote: > > The patch set includes: > > 1. API changes > > 2. testpmd adaption and guide update > > 3. driver update (only net/mlx5 impacted) > > > > --- > > v2: add adaptions of testpmd and driver part > > --- > > > > Bing Zhao (4): > > ethdev: introduce indirect action APIs > > app/test-pmd: change to indirect action command > > doc: update user guide for indirect action > > net/mlx5: adaption to indirect action API > > > > Hi Bing, > > How the patchset constructed will cause build error in patch by > patch build, since first patch removes some struct/functions that > are in use. > > One way to handle this is: > - first add new function/structs > - switch app & pmd to new function/structs > - remove old function/structs > Sure, I will reorganize the patch set in this way. Thanks for this. > > And another issue is this support has been added on 20.11, and we > are changing it in the second release after it. > Of course it is OK to change the API by time, that is why we have > experimental APIs, but the concern is if the development is driven > by single vendor without a consensus or enough reviews, and my worry > is if same thing happening again. The change itself is not big, most of them are the naming convention. The most important change is one input parameter of the "update" interface. Yes, I agree with your concern. Are there any other reviewers suggested for this change? (I got the name list from the script) It would be very helpful if they could give some comments or some suggestions. > > The author and reviewers of the original patch is already cc'ed, I > think it would be good to have their ack to the change. Yes, I will ping them. > > Thanks, > ferruh
next prev parent reply other threads:[~2021-04-13 1:23 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <1615967952-228321-1-git-send-email-bingz@nvidia.com> 2021-03-17 8:28 ` [dpdk-dev] [RFC] ethdev: introduce action context APIs Thomas Monjalon 2021-03-17 16:10 ` Bing Zhao 2021-03-22 14:59 ` Andrew Rybchenko 2021-04-06 9:05 ` Bing Zhao 2021-03-22 14:54 ` Andrew Rybchenko 2021-04-06 9:07 ` Bing Zhao 2021-04-06 9:48 ` Thomas Monjalon 2021-04-06 11:02 ` Bing Zhao 2021-04-06 12:18 ` Thomas Monjalon 2021-04-07 3:16 ` Ajit Khaparde 2021-04-07 6:11 ` Bing Zhao 2021-04-08 14:46 ` [dpdk-dev] [RFC PATCH v2] ethdev: introduce indirect action APIs Bing Zhao 2021-04-09 3:54 ` [dpdk-dev] [PATCH] " Bing Zhao 2021-04-10 14:03 ` [dpdk-dev] [PATCH v2 0/4] Change shared action API to action handle API Bing Zhao 2021-04-10 14:03 ` [dpdk-dev] [PATCH v2 1/4] ethdev: introduce indirect action APIs Bing Zhao 2021-04-12 19:42 ` Ferruh Yigit 2021-04-13 1:26 ` Bing Zhao 2021-04-13 14:00 ` Ori Kam 2021-04-13 12:36 ` Andrey Vesnovaty 2021-04-15 13:55 ` Andrew Rybchenko 2021-04-15 14:10 ` Thomas Monjalon 2021-04-15 16:02 ` Andrew Rybchenko 2021-04-10 14:03 ` [dpdk-dev] [PATCH v2 2/4] app/test-pmd: change to indirect action command Bing Zhao 2021-04-10 14:03 ` [dpdk-dev] [PATCH v2 3/4] doc: update user guide for indirect action Bing Zhao 2021-04-10 14:03 ` [dpdk-dev] [PATCH v2 4/4] net/mlx5: adaption to indirect action API Bing Zhao 2021-04-12 19:40 ` [dpdk-dev] [PATCH v2 0/4] Change shared action API to action handle API Ferruh Yigit 2021-04-13 1:22 ` Bing Zhao [this message] 2021-04-13 7:23 ` Thomas Monjalon 2021-04-13 7:24 ` Bing Zhao 2021-04-15 15:51 ` [dpdk-dev] [PATCH v3 0/1] " Bing Zhao 2021-04-15 15:51 ` [dpdk-dev] [PATCH v3 1/1] ethdev: introduce indirect action APIs Bing Zhao 2021-04-15 15:56 ` Ori Kam 2021-04-15 17:59 ` Ajit Khaparde 2021-04-16 6:58 ` Bing Zhao 2021-04-16 7:03 ` Thomas Monjalon 2021-04-16 15:00 ` Ajit Khaparde 2021-04-16 17:33 ` [dpdk-dev] [PATCH v4 0/1] Change shared action API to action handle API Bing Zhao 2021-04-16 17:33 ` [dpdk-dev] [PATCH v4 1/1] ethdev: introduce indirect action APIs Bing Zhao 2021-04-19 12:26 ` Thomas Monjalon 2021-04-19 15:05 ` Bing Zhao 2021-04-19 14:28 ` [dpdk-dev] [PATCH v5] Change shared action API to action handle API Bing Zhao 2021-04-19 14:28 ` [dpdk-dev] [PATCH v5] ethdev: introduce indirect action APIs Bing Zhao 2021-04-19 14:38 ` [dpdk-dev] [PATCH v5 0/1] Change shared action API to action handle API Bing Zhao 2021-04-19 14:38 ` [dpdk-dev] [PATCH v5 1/1] ethdev: introduce indirect action APIs Bing Zhao 2021-04-19 14:50 ` Thomas Monjalon 2021-04-19 15:09 ` Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=MN2PR12MB2909D15251F6D23227D2EF9FD04F9@MN2PR12MB2909.namprd12.prod.outlook.com \ --to=bingz@nvidia.com \ --cc=ajit.khaparde@broadcom.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=andreyv@nvidia.com \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=getelson@nvidia.com \ --cc=matan@nvidia.com \ --cc=orika@nvidia.com \ --cc=thomas@monjalon.net \ --cc=viacheslavo@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git