From: Raslan Darawsheh <rasland@nvidia.com>
To: Shun Hao <shunh@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
Matan Azrad <matan@nvidia.com>, Ori Kam <orika@nvidia.com>,
Bing Zhao <bingz@nvidia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v1] net/mlx5: fix action flag data type
Date: Thu, 3 Nov 2022 11:41:16 +0000 [thread overview]
Message-ID: <MN2PR12MB308680D479E69FEDD3284B74CF389@MN2PR12MB3086.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20221101100724.3190709-1-shunh@nvidia.com>
Hi,
> -----Original Message-----
> From: Shun Hao <shunh@nvidia.com>
> Sent: Tuesday, November 1, 2022 12:07 PM
> To: Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; Bing Zhao
> <bingz@nvidia.com>
> Cc: dev@dpdk.org; Raslan Darawsheh <rasland@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH v1] net/mlx5: fix action flag data type
>
> MLX5_FLOW_ACTION flags are used as uint64_t now, but some old flags
> are not defined as 64 bits. So if they are type casted to uint64 after
> bitwise operations, the high 32-bit data might be incorrect.
>
> E.g. Currently MLX5_FLOW_ACTION_DROP is defined as 0x1u, when it is
> used
> like:
> (action_flags & ~MLX5_FLOW_ACTION_DROP)
> action_flags is uint64_t so (~MLX5_FLOW_ACTION_DROP) will be casted to
> uint64_t as well, but its high 32 bits will be all 0s. This will make the
> result not as expected.
>
> This patch fixes this by making all action flags definition as 64-bit
> data type.
>
> Fixes: 4b7bf3ff ("net/mlx5: support yellow in meter policy validation")
> Cc: stable@dpdk.org
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
next prev parent reply other threads:[~2022-11-03 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 10:07 Shun Hao
2022-11-03 11:41 ` Raslan Darawsheh [this message]
2022-11-14 11:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR12MB308680D479E69FEDD3284B74CF389@MN2PR12MB3086.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=shunh@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).