[dpdk-dev] [PATCH] doc: add deprecation notice for security session create API

[dpdk-dev] [PATCH] doc: add deprecation notice for security session create API

[Akhil Goyal]

The API ``rte_security_session_create`` takes only single mempool
for session and session private data. So the application need to create
mempool for twice the number of sessions needed and will also lead to
wastage of memory as session private data need more memory compared to session.
Hence the API will be modified to take two mempool pointers - one for session
and one for private data. This is very similar to crypto based session
create APIs.

Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ea4cfa7a4..9ed7b55e6 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -126,6 +126,13 @@ Deprecation Notices
   to one it means it represents IV, when is set to zero it means J0 is used
   directly, in this case 16 bytes of J0 need to be passed.
 
+* security: The API ``rte_security_session_create`` takes only single mempool
+  for session and session private data. So the application need to create
+  mempool for twice the number of sessions needed and will also lead to
+  wastage of memory as session private data need more memory compared to session.
+  Hence the API will be modified to take two mempool pointers - one for session
+  and one for private data.
+
 * sched: To allow more traffic classes, flexible mapping of pipe queues to
   traffic classes, and subport level configuration of pipes and queues
   changes will be made to macros, data structures and API functions defined
-- 
2.17.1

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API

[Hemant Agrawal]

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Re: [dpdk-dev] [EXT] [PATCH] doc: add deprecation notice for security session create API

[Anoob Joseph]

> The API ``rte_security_session_create`` takes only single mempool for session
> and session private data. So the application need to create mempool for twice
> the number of sessions needed and will also lead to wastage of memory as
> session private data need more memory compared to session.
> Hence the API will be modified to take two mempool pointers - one for session
> and one for private data. This is very similar to crypto based session create APIs.
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>  1 file changed, 7 insertions(+)

Acked-by: Anoob Joseph <anoobj@marvell.com>

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API

[Ananyev, Konstantin]

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Thursday, July 30, 2020 8:14 PM
> To: dev@dpdk.org; anoobj@marvell.com; Nicolau, Radu <radu.nicolau@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>; Doherty, Declan <declan.doherty@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: thomas@monjalon.net; Trahe, Fiona <fiona.trahe@intel.com>; adwivedi@marvell.com; hemant.agrawal@nxp.com; Akhil Goyal
> <akhil.goyal@nxp.com>
> Subject: [PATCH] doc: add deprecation notice for security session create API
> 
> The API ``rte_security_session_create`` takes only single mempool
> for session and session private data. So the application need to create
> mempool for twice the number of sessions needed and will also lead to
> wastage of memory as session private data need more memory compared to session.
> Hence the API will be modified to take two mempool pointers - one for session
> and one for private data. This is very similar to crypto based session
> create APIs.
> 
> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index ea4cfa7a4..9ed7b55e6 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -126,6 +126,13 @@ Deprecation Notices
>    to one it means it represents IV, when is set to zero it means J0 is used
>    directly, in this case 16 bytes of J0 need to be passed.
> 
> +* security: The API ``rte_security_session_create`` takes only single mempool
> +  for session and session private data. So the application need to create
> +  mempool for twice the number of sessions needed and will also lead to
> +  wastage of memory as session private data need more memory compared to session.
> +  Hence the API will be modified to take two mempool pointers - one for session
> +  and one for private data.
> +
>  * sched: To allow more traffic classes, flexible mapping of pipe queues to
>    traffic classes, and subport level configuration of pipes and queues
>    changes will be made to macros, data structures and API functions defined
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.17.1

Re: [dpdk-dev] [PATCH] doc: add deprecation notice for security session create API

[Thomas Monjalon]

> > The API ``rte_security_session_create`` takes only single mempool
> > for session and session private data. So the application need to create
> > mempool for twice the number of sessions needed and will also lead to
> > wastage of memory as session private data need more memory compared to session.
> > Hence the API will be modified to take two mempool pointers - one for session
> > and one for private data. This is very similar to crypto based session
> > create APIs.
> > 
> > Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
> > ---
> > +* security: The API ``rte_security_session_create`` takes only single mempool
> > +  for session and session private data. So the application need to create
> > +  mempool for twice the number of sessions needed and will also lead to
> > +  wastage of memory as session private data need more memory compared to session.
> > +  Hence the API will be modified to take two mempool pointers - one for session
> > +  and one for private data.
> > +
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Applied