DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH 1/3] test/test_ipsec: compilation fix for GCC-12
@ 2022-08-04 13:40 Amit Prakash Shukla
  2022-08-04 13:40 ` [PATCH 2/3] ipsec: " Amit Prakash Shukla
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Amit Prakash Shukla @ 2022-08-04 13:40 UTC (permalink / raw)
  To: Konstantin Ananyev, Bernard Iremonger, Vladimir Medvedkin
  Cc: dev, jerinj, Amit Prakash Shukla

GCC-12 raises following warning:

p/test/dpdk-test.p/test_ipsec.c.o -c ../app/test/test_ipsec.c
In file included from ../lib/eal/x86/include/rte_atomic.h:15,
                 from ../lib/eal/include/generic/rte_pause.h:19,
                 from ../lib/eal/x86/include/rte_pause.h:12,
                 from ../lib/eal/include/generic/rte_spinlock.h:25,
                 from ../lib/eal/x86/include/rte_spinlock.h:12,
                 from ../lib/mempool/rte_mempool.h:43,
                 from ../lib/mbuf/rte_mbuf.h:38,
                 from ../app/test/test_ipsec.c:9:
In function '_mm_loadu_si128',
    inlined from 'rte_mov16' at
	../lib/eal/x86/include/rte_memcpy.h:507:9,
    inlined from 'rte_mov128' at
	../lib/eal/x86/include/rte_memcpy.h:549:2,
    inlined from 'rte_memcpy_generic' at
	../lib/eal/x86/include/rte_memcpy.h:732:4,
    inlined from 'rte_memcpy' at
	../lib/eal/x86/include/rte_memcpy.h:882:10,
    inlined from 'setup_test_string_tunneled' at
	../app/test/test_ipsec.c:617:3:
/usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/include/emmintrin.h:703:10: error:
    array subscript '__m128i_u[15]' is partly outside array bounds of
    'const uint8_t[255]' {aka 'const unsigned char[255]'}
    [-Werror=array-bounds]
  703 |   return *__P;
      |          ^~~~
../app/test/test_ipsec.c: In function 'setup_test_string_tunneled':
../app/test/test_ipsec.c:491:22: note: at offset 240 into object
     'esp_pad_bytes' of size 255
  491 | static const uint8_t esp_pad_bytes[IPSEC_MAX_PAD_SIZE] = {

Restrict copy to minimum size.

Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
 app/test/test_ipsec.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c
index bc2a3dbc2e..8fad093dee 100644
--- a/app/test/test_ipsec.c
+++ b/app/test/test_ipsec.c
@@ -614,7 +614,8 @@ setup_test_string_tunneled(struct rte_mempool *mpool, const char *string,
 		rte_memcpy(dst, string, len);
 		dst += len;
 		/* copy pad bytes */
-		rte_memcpy(dst, esp_pad_bytes, padlen);
+		rte_memcpy(dst, esp_pad_bytes, RTE_MIN(padlen,
+			sizeof(esp_pad_bytes)));
 		dst += padlen;
 		/* copy ESP tail header */
 		rte_memcpy(dst, &espt, sizeof(espt));
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 2/3] ipsec: compilation fix for GCC-12
  2022-08-04 13:40 [PATCH 1/3] test/test_ipsec: compilation fix for GCC-12 Amit Prakash Shukla
@ 2022-08-04 13:40 ` Amit Prakash Shukla
  2022-08-07 13:17   ` Konstantin Ananyev
  2022-08-04 13:40 ` [PATCH 3/3] crypto/qat: " Amit Prakash Shukla
  2022-08-28 12:01 ` [EXT] [PATCH 1/3] test/test_ipsec: " Akhil Goyal
  2 siblings, 1 reply; 6+ messages in thread
From: Amit Prakash Shukla @ 2022-08-04 13:40 UTC (permalink / raw)
  To: Konstantin Ananyev, Bernard Iremonger, Vladimir Medvedkin
  Cc: dev, jerinj, Amit Prakash Shukla, stable

GCC 12 raises the following warning:

In file included from ../lib/eal/x86/include/rte_atomic.h:15,
                 from ../lib/eal/include/generic/rte_pause.h:19,
                 from ../lib/eal/x86/include/rte_pause.h:12,
                 from ../lib/eal/include/generic/rte_spinlock.h:25,
                 from ../lib/eal/x86/include/rte_spinlock.h:12,
                 from ../lib/mempool/rte_mempool.h:43,
                 from ../lib/mbuf/rte_mbuf.h:38,
                 from ../lib/cryptodev/rte_crypto.h:20,
                 from ../lib/cryptodev/rte_cryptodev.h:22,
                 from ../lib/ipsec/rte_ipsec_sa.h:15,
                 from ../lib/ipsec/rte_ipsec.h:17,
                 from ../lib/ipsec/esp_outb.c:5:
In function '_mm_loadu_si128',
    inlined from 'rte_mov16' at
	../lib/eal/x86/include/rte_memcpy.h:507:9,
    inlined from 'rte_mov128' at
	../lib/eal/x86/include/rte_memcpy.h:549:2,
    inlined from 'rte_memcpy_generic' at
	../lib/eal/x86/include/rte_memcpy.h:732:4,
    inlined from 'rte_memcpy' at
	../lib/eal/x86/include/rte_memcpy.h:882:10,
    inlined from 'outb_tun_pkt_prepare' at
	../lib/ipsec/esp_outb.c:224:2:
/usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/include/emmintrin.h:703:10: error:
	array subscript '__m128i_u[15]' is partly outside array bounds of
	'const uint8_t[255]' {aka 'const unsigned char[255]'}
	[-Werror=array-bounds]
  703 |   return *__P;
      |          ^~~~
In file included from ../lib/ipsec/esp_outb.c:17:
../lib/ipsec/pad.h: In function 'outb_tun_pkt_prepare':
../lib/ipsec/pad.h:10:22: note: at offset 240 into object 'esp_pad_bytes'
	of size 255
   10 | static const uint8_t esp_pad_bytes[IPSEC_MAX_PAD_SIZE] = {
      |                      ^~~~~~~~~~~~~
In function '_mm_loadu_si128',
    inlined from 'rte_mov16' at
	../lib/eal/x86/include/rte_memcpy.h:507:9,
    inlined from 'rte_mov128' at
	../lib/eal/x86/include/rte_memcpy.h:549:2,
    inlined from 'rte_memcpy_generic' at
	../lib/eal/x86/include/rte_memcpy.h:732:4,
    inlined from 'rte_memcpy' at
	../lib/eal/x86/include/rte_memcpy.h:882:10,
    inlined from 'outb_trs_pkt_prepare' at
	../lib/ipsec/esp_outb.c:421:2:
/usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/include/emmintrin.h:703:10: error:
	array subscript '__m128i_u[15]' is partly outside array bounds of
	'const uint8_t[255]' {aka 'const unsigned char[255]'}
	[-Werror=array-bounds]
  703 |   return *__P;
      |          ^~~~
../lib/ipsec/pad.h: In function 'outb_trs_pkt_prepare':
../lib/ipsec/pad.h:10:22: note: at offset 240 into object 'esp_pad_bytes'
	of size 255
   10 | static const uint8_t esp_pad_bytes[IPSEC_MAX_PAD_SIZE] = {
      |                      ^~~~~~~~~~~~~

Restrict copy to minimum size.

Bugzilla ID: 1060
Fixes: 6015e6a13398 ("ipsec: move inbound and outbound code")
Cc: stable@dpdk.org

Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
 lib/ipsec/esp_outb.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/ipsec/esp_outb.c b/lib/ipsec/esp_outb.c
index 672e56aba0..aa18c89468 100644
--- a/lib/ipsec/esp_outb.c
+++ b/lib/ipsec/esp_outb.c
@@ -220,8 +220,10 @@ outb_tun_pkt_prepare(struct rte_ipsec_sa *sa, rte_be64_t sqc,
 	/* pad length */
 	pdlen -= sizeof(*espt);
 
+	RTE_ASSERT(pdlen <= sizeof(esp_pad_bytes));
+
 	/* copy padding data */
-	rte_memcpy(pt, esp_pad_bytes, pdlen);
+	rte_memcpy(pt, esp_pad_bytes, RTE_MIN(pdlen, sizeof(esp_pad_bytes)));
 
 	/* update esp trailer */
 	espt = (struct rte_esp_tail *)(pt + pdlen);
@@ -417,8 +419,10 @@ outb_trs_pkt_prepare(struct rte_ipsec_sa *sa, rte_be64_t sqc,
 	/* pad length */
 	pdlen -= sizeof(*espt);
 
+	RTE_ASSERT(pdlen <= sizeof(esp_pad_bytes));
+
 	/* copy padding data */
-	rte_memcpy(pt, esp_pad_bytes, pdlen);
+	rte_memcpy(pt, esp_pad_bytes, RTE_MIN(pdlen, sizeof(esp_pad_bytes)));
 
 	/* update esp trailer */
 	espt = (struct rte_esp_tail *)(pt + pdlen);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 3/3] crypto/qat: compilation fix for GCC-12
  2022-08-04 13:40 [PATCH 1/3] test/test_ipsec: compilation fix for GCC-12 Amit Prakash Shukla
  2022-08-04 13:40 ` [PATCH 2/3] ipsec: " Amit Prakash Shukla
@ 2022-08-04 13:40 ` Amit Prakash Shukla
  2022-08-05  8:12   ` Zhang, Roy Fan
  2022-08-28 12:01 ` [EXT] [PATCH 1/3] test/test_ipsec: " Akhil Goyal
  2 siblings, 1 reply; 6+ messages in thread
From: Amit Prakash Shukla @ 2022-08-04 13:40 UTC (permalink / raw)
  To: Fan Zhang; +Cc: dev, jerinj, Amit Prakash Shukla

GCC 12 raises the following warning:

                 from ../lib/eal/x86/include/rte_vect.h:31,
                 from ../lib/eal/x86/include/rte_memcpy.h:17,
                 from ../drivers/crypto/qat/qat_sym_session.c:10:
In function '_mm_storeu_si128',
    inlined from 'rte_mov16' at
	../lib/eal/x86/include/rte_memcpy.h:508:2,
    inlined from 'rte_mov128' at
	../lib/eal/x86/include/rte_memcpy.h:542:2,
    inlined from 'rte_memcpy_generic' at
	../lib/eal/x86/include/rte_memcpy.h:732:4,
    inlined from 'rte_memcpy' at
	../lib/eal/x86/include/rte_memcpy.h:882:10,
    inlined from 'qat_sym_do_precomputes.constprop' at
	../drivers/crypto/qat/qat_sym_session.c:1434:2:
/usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/include/emmintrin.h:739:8: error:
	array subscript 8 is outside array bounds of 'unsigned char[128]'
	[-Werror=array-bounds]
  739 |   *__P = __B;
      |   ~~~~~^~~~~

../drivers/crypto/qat/qat_sym_session.c:
	In function 'qat_sym_do_precomputes.constprop':
../drivers/crypto/qat/qat_sym_session.c:1305:17: note:
	at offset 192 into object 'opad.750' of size 128
 1305 | uint8_t
	  opad[qat_hash_get_block_size(ICP_QAT_HW_AUTH_ALGO_DELIMITER)];
      |           ^~~~

../drivers/crypto/qat/qat_sym_session.c:
	In function 'qat_sym_do_precomputes.constprop':
../drivers/crypto/qat/qat_sym_session.c:1304:17: note:
	at offset 128 into object 'ipad.749' of size 128
 1304 | uint8_t
	  ipad[qat_hash_get_block_size(ICP_QAT_HW_AUTH_ALGO_DELIMITER)];
      |           ^~~~

Added a check to prevent compiler warnings.

Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
 drivers/crypto/qat/qat_sym_session.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c
index 8ca475ca8b..4c513186d4 100644
--- a/drivers/crypto/qat/qat_sym_session.c
+++ b/drivers/crypto/qat/qat_sym_session.c
@@ -1431,6 +1431,10 @@ static int qat_sym_do_precomputes(enum icp_qat_hw_auth_algo hash_alg,
 		QAT_LOG(ERR, "invalid keylen %u", auth_keylen);
 		return -EFAULT;
 	}
+
+	RTE_VERIFY(auth_keylen <= sizeof(ipad));
+	RTE_VERIFY(auth_keylen <= sizeof(opad));
+
 	rte_memcpy(ipad, auth_key, auth_keylen);
 	rte_memcpy(opad, auth_key, auth_keylen);
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH 3/3] crypto/qat: compilation fix for GCC-12
  2022-08-04 13:40 ` [PATCH 3/3] crypto/qat: " Amit Prakash Shukla
@ 2022-08-05  8:12   ` Zhang, Roy Fan
  0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Roy Fan @ 2022-08-05  8:12 UTC (permalink / raw)
  To: Amit Prakash Shukla, Zhang, Roy Fan; +Cc: dev, jerinj

> -----Original Message-----
> From: Amit Prakash Shukla <amitprakashs@marvell.com>
> Sent: Thursday, August 4, 2022 2:41 PM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; jerinj@marvell.com; Amit Prakash Shukla
> <amitprakashs@marvell.com>
> Subject: [PATCH 3/3] crypto/qat: compilation fix for GCC-12
> 
> GCC 12 raises the following warning:
> 
>                  from ../lib/eal/x86/include/rte_vect.h:31,
>                  from ../lib/eal/x86/include/rte_memcpy.h:17,
>                  from ../drivers/crypto/qat/qat_sym_session.c:10:
> In function '_mm_storeu_si128',
>     inlined from 'rte_mov16' at
> 	../lib/eal/x86/include/rte_memcpy.h:508:2,
>     inlined from 'rte_mov128' at
> 	../lib/eal/x86/include/rte_memcpy.h:542:2,
>     inlined from 'rte_memcpy_generic' at
> 	../lib/eal/x86/include/rte_memcpy.h:732:4,
>     inlined from 'rte_memcpy' at
> 	../lib/eal/x86/include/rte_memcpy.h:882:10,
>     inlined from 'qat_sym_do_precomputes.constprop' at
> 	../drivers/crypto/qat/qat_sym_session.c:1434:2:
> /usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/include/emmintrin.h:739:8: error:
> 	array subscript 8 is outside array bounds of 'unsigned char[128]'
> 	[-Werror=array-bounds]
>   739 |   *__P = __B;
>       |   ~~~~~^~~~~
> 
> ../drivers/crypto/qat/qat_sym_session.c:
> 	In function 'qat_sym_do_precomputes.constprop':
> ../drivers/crypto/qat/qat_sym_session.c:1305:17: note:
> 	at offset 192 into object 'opad.750' of size 128
>  1305 | uint8_t
> 
> opad[qat_hash_get_block_size(ICP_QAT_HW_AUTH_ALGO_DELIMITER)];
>       |           ^~~~
> 
> ../drivers/crypto/qat/qat_sym_session.c:
> 	In function 'qat_sym_do_precomputes.constprop':
> ../drivers/crypto/qat/qat_sym_session.c:1304:17: note:
> 	at offset 128 into object 'ipad.749' of size 128
>  1304 | uint8_t
> 
> ipad[qat_hash_get_block_size(ICP_QAT_HW_AUTH_ALGO_DELIMITER)];
>       |           ^~~~
> 
> Added a check to prevent compiler warnings.
> 
> Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> ---
Thanks for the help!
The commit log could be shorter. Could you provide a V3 for that?
Apart from that
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/3] ipsec: compilation fix for GCC-12
  2022-08-04 13:40 ` [PATCH 2/3] ipsec: " Amit Prakash Shukla
@ 2022-08-07 13:17   ` Konstantin Ananyev
  0 siblings, 0 replies; 6+ messages in thread
From: Konstantin Ananyev @ 2022-08-07 13:17 UTC (permalink / raw)
  To: Amit Prakash Shukla, Bernard Iremonger, Vladimir Medvedkin
  Cc: dev, jerinj, stable

04/08/2022 14:40, Amit Prakash Shukla пишет:
> GCC 12 raises the following warning:
> 
> In file included from ../lib/eal/x86/include/rte_atomic.h:15,
>                   from ../lib/eal/include/generic/rte_pause.h:19,
>                   from ../lib/eal/x86/include/rte_pause.h:12,
>                   from ../lib/eal/include/generic/rte_spinlock.h:25,
>                   from ../lib/eal/x86/include/rte_spinlock.h:12,
>                   from ../lib/mempool/rte_mempool.h:43,
>                   from ../lib/mbuf/rte_mbuf.h:38,
>                   from ../lib/cryptodev/rte_crypto.h:20,
>                   from ../lib/cryptodev/rte_cryptodev.h:22,
>                   from ../lib/ipsec/rte_ipsec_sa.h:15,
>                   from ../lib/ipsec/rte_ipsec.h:17,
>                   from ../lib/ipsec/esp_outb.c:5:
> In function '_mm_loadu_si128',
>      inlined from 'rte_mov16' at
> 	../lib/eal/x86/include/rte_memcpy.h:507:9,
>      inlined from 'rte_mov128' at
> 	../lib/eal/x86/include/rte_memcpy.h:549:2,
>      inlined from 'rte_memcpy_generic' at
> 	../lib/eal/x86/include/rte_memcpy.h:732:4,
>      inlined from 'rte_memcpy' at
> 	../lib/eal/x86/include/rte_memcpy.h:882:10,
>      inlined from 'outb_tun_pkt_prepare' at
> 	../lib/ipsec/esp_outb.c:224:2:
> /usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/include/emmintrin.h:703:10: error:
> 	array subscript '__m128i_u[15]' is partly outside array bounds of
> 	'const uint8_t[255]' {aka 'const unsigned char[255]'}
> 	[-Werror=array-bounds]
>    703 |   return *__P;
>        |          ^~~~
> In file included from ../lib/ipsec/esp_outb.c:17:
> ../lib/ipsec/pad.h: In function 'outb_tun_pkt_prepare':
> ../lib/ipsec/pad.h:10:22: note: at offset 240 into object 'esp_pad_bytes'
> 	of size 255
>     10 | static const uint8_t esp_pad_bytes[IPSEC_MAX_PAD_SIZE] = {
>        |                      ^~~~~~~~~~~~~
> In function '_mm_loadu_si128',
>      inlined from 'rte_mov16' at
> 	../lib/eal/x86/include/rte_memcpy.h:507:9,
>      inlined from 'rte_mov128' at
> 	../lib/eal/x86/include/rte_memcpy.h:549:2,
>      inlined from 'rte_memcpy_generic' at
> 	../lib/eal/x86/include/rte_memcpy.h:732:4,
>      inlined from 'rte_memcpy' at
> 	../lib/eal/x86/include/rte_memcpy.h:882:10,
>      inlined from 'outb_trs_pkt_prepare' at
> 	../lib/ipsec/esp_outb.c:421:2:
> /usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/include/emmintrin.h:703:10: error:
> 	array subscript '__m128i_u[15]' is partly outside array bounds of
> 	'const uint8_t[255]' {aka 'const unsigned char[255]'}
> 	[-Werror=array-bounds]
>    703 |   return *__P;
>        |          ^~~~
> ../lib/ipsec/pad.h: In function 'outb_trs_pkt_prepare':
> ../lib/ipsec/pad.h:10:22: note: at offset 240 into object 'esp_pad_bytes'
> 	of size 255
>     10 | static const uint8_t esp_pad_bytes[IPSEC_MAX_PAD_SIZE] = {
>        |                      ^~~~~~~~~~~~~
> 
> Restrict copy to minimum size.
> 
> Bugzilla ID: 1060
> Fixes: 6015e6a13398 ("ipsec: move inbound and outbound code")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> ---
>   lib/ipsec/esp_outb.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/ipsec/esp_outb.c b/lib/ipsec/esp_outb.c
> index 672e56aba0..aa18c89468 100644
> --- a/lib/ipsec/esp_outb.c
> +++ b/lib/ipsec/esp_outb.c
> @@ -220,8 +220,10 @@ outb_tun_pkt_prepare(struct rte_ipsec_sa *sa, rte_be64_t sqc,
>   	/* pad length */
>   	pdlen -= sizeof(*espt);
>   
> +	RTE_ASSERT(pdlen <= sizeof(esp_pad_bytes));
> +
>   	/* copy padding data */
> -	rte_memcpy(pt, esp_pad_bytes, pdlen);
> +	rte_memcpy(pt, esp_pad_bytes, RTE_MIN(pdlen, sizeof(esp_pad_bytes)));
>   
>   	/* update esp trailer */
>   	espt = (struct rte_esp_tail *)(pt + pdlen);
> @@ -417,8 +419,10 @@ outb_trs_pkt_prepare(struct rte_ipsec_sa *sa, rte_be64_t sqc,
>   	/* pad length */
>   	pdlen -= sizeof(*espt);
>   
> +	RTE_ASSERT(pdlen <= sizeof(esp_pad_bytes));
> +
>   	/* copy padding data */
> -	rte_memcpy(pt, esp_pad_bytes, pdlen);
> +	rte_memcpy(pt, esp_pad_bytes, RTE_MIN(pdlen, sizeof(esp_pad_bytes)));
>   
>   	/* update esp trailer */
>   	espt = (struct rte_esp_tail *)(pt + pdlen);


Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [EXT] [PATCH 1/3] test/test_ipsec: compilation fix for GCC-12
  2022-08-04 13:40 [PATCH 1/3] test/test_ipsec: compilation fix for GCC-12 Amit Prakash Shukla
  2022-08-04 13:40 ` [PATCH 2/3] ipsec: " Amit Prakash Shukla
  2022-08-04 13:40 ` [PATCH 3/3] crypto/qat: " Amit Prakash Shukla
@ 2022-08-28 12:01 ` Akhil Goyal
  2 siblings, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2022-08-28 12:01 UTC (permalink / raw)
  To: Amit Prakash Shukla, Konstantin Ananyev, Bernard Iremonger,
	Vladimir Medvedkin
  Cc: dev, Jerin Jacob Kollanukkaran, Amit Prakash Shukla

> GCC-12 raises following warning:
> 
> p/test/dpdk-test.p/test_ipsec.c.o -c ../app/test/test_ipsec.c
> In file included from ../lib/eal/x86/include/rte_atomic.h:15,
>                  from ../lib/eal/include/generic/rte_pause.h:19,
>                  from ../lib/eal/x86/include/rte_pause.h:12,
>                  from ../lib/eal/include/generic/rte_spinlock.h:25,
>                  from ../lib/eal/x86/include/rte_spinlock.h:12,
>                  from ../lib/mempool/rte_mempool.h:43,
>                  from ../lib/mbuf/rte_mbuf.h:38,
>                  from ../app/test/test_ipsec.c:9:
> In function '_mm_loadu_si128',
>     inlined from 'rte_mov16' at
> 	../lib/eal/x86/include/rte_memcpy.h:507:9,
>     inlined from 'rte_mov128' at
> 	../lib/eal/x86/include/rte_memcpy.h:549:2,
>     inlined from 'rte_memcpy_generic' at
> 	../lib/eal/x86/include/rte_memcpy.h:732:4,
>     inlined from 'rte_memcpy' at
> 	../lib/eal/x86/include/rte_memcpy.h:882:10,
>     inlined from 'setup_test_string_tunneled' at
> 	../app/test/test_ipsec.c:617:3:
> /usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/include/emmintrin.h:703:10: error:
>     array subscript '__m128i_u[15]' is partly outside array bounds of
>     'const uint8_t[255]' {aka 'const unsigned char[255]'}
>     [-Werror=array-bounds]
>   703 |   return *__P;
>       |          ^~~~
> ../app/test/test_ipsec.c: In function 'setup_test_string_tunneled':
> ../app/test/test_ipsec.c:491:22: note: at offset 240 into object
>      'esp_pad_bytes' of size 255
>   491 | static const uint8_t esp_pad_bytes[IPSEC_MAX_PAD_SIZE] = {
> 
> Restrict copy to minimum size.
> 
> Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> ---
Acked-by: Akhil Goyal <gakhil@marvell.com>

Series applied to dpdk-next-crypto

Thanks

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-08-28 12:01 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-04 13:40 [PATCH 1/3] test/test_ipsec: compilation fix for GCC-12 Amit Prakash Shukla
2022-08-04 13:40 ` [PATCH 2/3] ipsec: " Amit Prakash Shukla
2022-08-07 13:17   ` Konstantin Ananyev
2022-08-04 13:40 ` [PATCH 3/3] crypto/qat: " Amit Prakash Shukla
2022-08-05  8:12   ` Zhang, Roy Fan
2022-08-28 12:01 ` [EXT] [PATCH 1/3] test/test_ipsec: " Akhil Goyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).