From: "Xu, Wei1" <wei1.xu@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"bernard.iremonger@inel.com" <bernard.iremonger@inel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: [PATCH] app/testpmd: fix parameters order when calling rte_ether_addr_copy()
Date: Wed, 10 Nov 2021 08:17:59 +0000 [thread overview]
Message-ID: <PH0PR11MB5159C100715402B318E8B086A6939@PH0PR11MB5159.namprd11.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1729 bytes --]
Running in 'csum' mode, the 'from' and 'to' parameters are not in correct
order when calling rte_ether_addr_copy() which means the src/dst mac addresses
will be overwriten.
As a result, the packets will not be recognized and received by the receiver(s).
Test CLI:
./app/dpdk-testpmd -n 1 -l 1-2 -a 09:00.0 -- -i --forward-mode=csum
Fixes: 10f4620(app/testpmd: modify mac in csum forwarding)
Signed-off-by: Wei Xu wei1.xu@intel.com<mailto:wei1.xu@intel.com>
---
app/test-pmd/csumonly.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index 8526d9158a..08484fcda2 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -872,10 +872,10 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
* and inner headers */
eth_hdr = rte_pktmbuf_mtod(m, struct rte_ether_hdr *);
- rte_ether_addr_copy(&peer_eth_addrs[fs->peer_addr],
- ð_hdr->dst_addr);
- rte_ether_addr_copy(&ports[fs->tx_port].eth_addr,
- ð_hdr->src_addr);
+ rte_ether_addr_copy(ð_hdr->dst_addr,
+ &peer_eth_addrs[fs->peer_addr]);
+ rte_ether_addr_copy(ð_hdr->src_addr,
+ &ports[fs->tx_port].eth_addr);
parse_ethernet(eth_hdr, &info);
l3_hdr = (char *)eth_hdr + info.l2_len;
[-- Attachment #2: Type: text/html, Size: 7021 bytes --]
next reply other threads:[~2021-11-10 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 8:17 Xu, Wei1 [this message]
2021-11-10 16:03 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB5159C100715402B318E8B086A6939@PH0PR11MB5159.namprd11.prod.outlook.com \
--to=wei1.xu@intel.com \
--cc=bernard.iremonger@inel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).