DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <gakhil@marvell.com>
To: Changsheng Wu <wuchangsheng2@huawei.com>,
	"fiona.trahe@intel.com" <fiona.trahe@intel.com>,
	Ashish Gupta <ashishg@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"rose.chen@huawei.com" <rose.chen@huawei.com>
Subject: RE: [EXT] [dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init
Date: Thu, 11 Nov 2021 11:32:56 +0000	[thread overview]
Message-ID: <PH0PR18MB44913AFAD0A813553B1A2559D8949@PH0PR18MB4491.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20211108123542.404239-1-wuchangsheng2@huawei.com>

> The testsuite_setup function in the compressdev_autotest test case,
> the rte_compressdev_count() return 0 due to the lack of device init.
> It is considered that there is no equitment to skip execution.
> So add rte_vdev_init init compress_zlib device.

Why? Devices can be added as command line argument.
* Use ``--vdev="compress_isal"`` in the EAL options, which will call ``rte_vdev_init()`` internally.
See documentation of compressdevs.

And if at all it is required, why only the zlib, there are other devices as well.


> 
> Signed-off-by: Changsheng Wu <wuchangsheng2@huawei.com>
> ---
>  app/test/test_compressdev.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c
> index a1b9f06250..f15fbe7f2d 100644
> --- a/app/test/test_compressdev.c
> +++ b/app/test/test_compressdev.c
> @@ -14,6 +14,7 @@
>  #include <rte_mbuf.h>
>  #include <rte_compressdev.h>
>  #include <rte_string_fns.h>
> +#include <rte_bus_vdev.h>
> 
>  #include "test_compressdev_test_buffer.h"
>  #include "test.h"
> @@ -197,6 +198,11 @@ testsuite_setup(void)
>  	uint32_t max_buf_size = 0;
>  	unsigned int i;
> 
> +	if (rte_vdev_init("compress_zlib", NULL) != 0) {
> +		RTE_LOG(WARNING, USER1, "not find compress_zlib
> device\n");
> +		return TEST_SKIPPED;
> +	}
> +
>  	if (rte_compressdev_count() == 0) {
>  		RTE_LOG(WARNING, USER1, "Need at least one compress
> device\n");
>  		return TEST_SKIPPED;
> --
> 2.27.0


  reply	other threads:[~2021-11-11 11:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-08 12:35 Changsheng Wu
2021-11-11 11:32 ` Akhil Goyal [this message]
2021-11-11 11:42   ` [EXT] " Akhil Goyal
2021-11-11 11:54 wuchangsheng (C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=PH0PR18MB44913AFAD0A813553B1A2559D8949@PH0PR18MB4491.namprd18.prod.outlook.com \
    --to=gakhil@marvell.com \
    --cc=ashishg@marvell.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=rose.chen@huawei.com \
    --cc=wuchangsheng2@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).