From: Anoob Joseph <anoobj@marvell.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <gakhil@marvell.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [EXT] Re: [PATCH 2/2] examples/ipsec-secgw: update stats when freeing packets
Date: Wed, 20 Dec 2023 13:10:36 +0000 [thread overview]
Message-ID: <PH0PR18MB46728EDB4E16227176AAEECFDF96A@PH0PR18MB4672.namprd18.prod.outlook.com> (raw)
In-Reply-To: <20231219091858.4812ecb9@hermes.local>
Hi Stephen,
Please see inline.
Thanks,
Anoob
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Tuesday, December 19, 2023 10:49 PM
> To: Anoob Joseph <anoobj@marvell.com>
> Cc: Radu Nicolau <radu.nicolau@intel.com>; Akhil Goyal
> <gakhil@marvell.com>; Konstantin Ananyev
> <konstantin.v.ananyev@yandex.ru>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; dev@dpdk.org
> Subject: [EXT] Re: [PATCH 2/2] examples/ipsec-secgw: update stats when
> freeing packets
>
> External Email
>
> ----------------------------------------------------------------------
> On Tue, 19 Dec 2023 10:59:23 +0530
> Anoob Joseph <anoobj@marvell.com> wrote:
>
> > Instead of freeing directly, use commonly used function which also
> > updates stats.
> >
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> > ---
> > examples/ipsec-secgw/ipsec_process.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/examples/ipsec-secgw/ipsec_process.c
> > b/examples/ipsec-secgw/ipsec_process.c
> > index b0cece3ad1..ddbe30745b 100644
> > --- a/examples/ipsec-secgw/ipsec_process.c
> > +++ b/examples/ipsec-secgw/ipsec_process.c
> > @@ -22,7 +22,7 @@ free_cops(struct rte_crypto_op *cop[], uint32_t n)
> > uint32_t i;
> >
> > for (i = 0; i != n; i++)
> > - rte_pktmbuf_free(cop[i]->sym->m_src);
> > + free_pkts(&cop[i]->sym->m_src, 1);
>
> Also, free_pkts is using a loop and should be using rte_pktmbuf_free_bulk()
> instead.
[Anoob] Indeed. Will push a separate patch for addressing the same. Thanks for pointing out.
next prev parent reply other threads:[~2023-12-20 13:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-19 5:29 [PATCH 1/2] examples/ipsec-secgw: fix width of variables Anoob Joseph
2023-12-19 5:29 ` [PATCH 2/2] examples/ipsec-secgw: update stats when freeing packets Anoob Joseph
2023-12-19 17:18 ` Stephen Hemminger
2023-12-20 13:10 ` Anoob Joseph [this message]
2023-12-19 9:51 ` [PATCH 1/2] examples/ipsec-secgw: fix width of variables Konstantin Ananyev
2024-01-09 17:38 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR18MB46728EDB4E16227176AAEECFDF96A@PH0PR18MB4672.namprd18.prod.outlook.com \
--to=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=jerinj@marvell.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=radu.nicolau@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).