* [PATCH] crypto/scheduler: fix qp_id in scheduler failover
@ 2022-06-15 13:13 Jakub Wysocki
2022-06-16 8:54 ` Zhang, Roy Fan
2022-06-20 9:12 ` Zhang, Roy Fan
0 siblings, 2 replies; 6+ messages in thread
From: Jakub Wysocki @ 2022-06-15 13:13 UTC (permalink / raw)
To: dev; +Cc: kai.ji, roy.fan.zhang, Jakub Wysocki
This commit fixes wrong qp_id value in cryptodev scheduler in failover
mode.
Fixes: 37f075dad1e9 ("crypto/scheduler: add fail-over scheduling mode")
Cc: roy.fan.zhang@intel.com
Signed-off-by: Jakub Wysocki <jakubx.wysocki@intel.com>
---
drivers/crypto/scheduler/scheduler_failover.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/scheduler/scheduler_failover.c b/drivers/crypto/scheduler/scheduler_failover.c
index 5023577ef8..247aeb2f22 100644
--- a/drivers/crypto/scheduler/scheduler_failover.c
+++ b/drivers/crypto/scheduler/scheduler_failover.c
@@ -157,6 +157,9 @@ scheduler_start(struct rte_cryptodev *dev)
((struct scheduler_qp_ctx *)
dev->data->queue_pairs[i])->private_qp_ctx;
+ sched_ctx->workers[PRIMARY_WORKER_IDX].qp_id = i;
+ sched_ctx->workers[SECONDARY_WORKER_IDX].qp_id = i;
+
rte_memcpy(&qp_ctx->primary_worker,
&sched_ctx->workers[PRIMARY_WORKER_IDX],
sizeof(struct scheduler_worker));
--
2.17.1
--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] crypto/scheduler: fix qp_id in scheduler failover
2022-06-15 13:13 [PATCH] crypto/scheduler: fix qp_id in scheduler failover Jakub Wysocki
@ 2022-06-16 8:54 ` Zhang, Roy Fan
2022-06-20 9:12 ` Zhang, Roy Fan
1 sibling, 0 replies; 6+ messages in thread
From: Zhang, Roy Fan @ 2022-06-16 8:54 UTC (permalink / raw)
To: Wysocki, JakubX, dev; +Cc: Ji, Kai
> -----Original Message-----
> From: Wysocki, JakubX <jakubx.wysocki@intel.com>
> Sent: Wednesday, June 15, 2022 2:14 PM
> To: dev@dpdk.org
> Cc: Ji, Kai <kai.ji@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> Wysocki, JakubX <jakubx.wysocki@intel.com>
> Subject: [PATCH] crypto/scheduler: fix qp_id in scheduler failover
>
> This commit fixes wrong qp_id value in cryptodev scheduler in failover
> mode.
>
> Fixes: 37f075dad1e9 ("crypto/scheduler: add fail-over scheduling mode")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Jakub Wysocki <jakubx.wysocki@intel.com>
> ---
> drivers/crypto/scheduler/scheduler_failover.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/crypto/scheduler/scheduler_failover.c
> b/drivers/crypto/scheduler/scheduler_failover.c
> index 5023577ef8..247aeb2f22 100644
> --- a/drivers/crypto/scheduler/scheduler_failover.c
> +++ b/drivers/crypto/scheduler/scheduler_failover.c
> @@ -157,6 +157,9 @@ scheduler_start(struct rte_cryptodev *dev)
> ((struct scheduler_qp_ctx *)
> dev->data->queue_pairs[i])->private_qp_ctx;
>
> + sched_ctx->workers[PRIMARY_WORKER_IDX].qp_id = i;
> + sched_ctx->workers[SECONDARY_WORKER_IDX].qp_id = i;
> +
> rte_memcpy(&qp_ctx->primary_worker,
> &sched_ctx->workers[PRIMARY_WORKER_IDX],
> sizeof(struct scheduler_worker));
> --
> 2.17.1
Thanks Jakub!
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] crypto/scheduler: fix qp_id in scheduler failover
2022-06-15 13:13 [PATCH] crypto/scheduler: fix qp_id in scheduler failover Jakub Wysocki
2022-06-16 8:54 ` Zhang, Roy Fan
@ 2022-06-20 9:12 ` Zhang, Roy Fan
1 sibling, 0 replies; 6+ messages in thread
From: Zhang, Roy Fan @ 2022-06-20 9:12 UTC (permalink / raw)
To: Wysocki, JakubX, dev; +Cc: Ji, Kai
> -----Original Message-----
> From: Wysocki, JakubX <jakubx.wysocki@intel.com>
> Sent: Wednesday, June 15, 2022 2:14 PM
> To: dev@dpdk.org
> Cc: Ji, Kai <kai.ji@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> Wysocki, JakubX <jakubx.wysocki@intel.com>
> Subject: [PATCH] crypto/scheduler: fix qp_id in scheduler failover
>
> This commit fixes wrong qp_id value in cryptodev scheduler in failover
> mode.
>
> Fixes: 37f075dad1e9 ("crypto/scheduler: add fail-over scheduling mode")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Jakub Wysocki <jakubx.wysocki@intel.com>
> ---
> drivers/crypto/scheduler/scheduler_failover.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/crypto/scheduler/scheduler_failover.c
> b/drivers/crypto/scheduler/scheduler_failover.c
> index 5023577ef8..247aeb2f22 100644
> --- a/drivers/crypto/scheduler/scheduler_failover.c
> +++ b/drivers/crypto/scheduler/scheduler_failover.c
> @@ -157,6 +157,9 @@ scheduler_start(struct rte_cryptodev *dev)
> ((struct scheduler_qp_ctx *)
> dev->data->queue_pairs[i])->private_qp_ctx;
>
> + sched_ctx->workers[PRIMARY_WORKER_IDX].qp_id = i;
> + sched_ctx->workers[SECONDARY_WORKER_IDX].qp_id = i;
> +
> rte_memcpy(&qp_ctx->primary_worker,
> &sched_ctx->workers[PRIMARY_WORKER_IDX],
> sizeof(struct scheduler_worker));
> --
> 2.17.1
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] crypto/scheduler: fix qp_id in scheduler failover
2022-06-20 22:12 ` Ji, Kai
@ 2022-06-21 10:34 ` Akhil Goyal
0 siblings, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2022-06-21 10:34 UTC (permalink / raw)
To: Ji, Kai, Wysocki, JakubX, dev; +Cc: Zhang, Roy Fan
> > Subject: [PATCH] crypto/scheduler: fix qp_id in scheduler failover
> >
> > This commit fixes wrong qp_id value in cryptodev scheduler in failover mode.
> >
> > Fixes: 37f075dad1e9 ("crypto/scheduler: add fail-over scheduling mode")
> > Cc: roy.fan.zhang@intel.com
> >
> > Signed-off-by: Jakub Wysocki <jakubx.wysocki@intel.com>
> > ---
> Acked-by: Ji, Kai <kai.ji@intel.com>
Fixed checkpatch errors while applying.
Please make sure to fix it next time.
Applied to dpdk-next-crypto
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] crypto/scheduler: fix qp_id in scheduler failover
2022-06-20 17:51 Jakub Wysocki
@ 2022-06-20 22:12 ` Ji, Kai
2022-06-21 10:34 ` Akhil Goyal
0 siblings, 1 reply; 6+ messages in thread
From: Ji, Kai @ 2022-06-20 22:12 UTC (permalink / raw)
To: Wysocki, JakubX, dev; +Cc: Zhang, Roy Fan, Ji, Kai
> -----Original Message-----
> From: Wysocki, JakubX <jakubx.wysocki@intel.com>
> Sent: Monday, June 20, 2022 6:52 PM
> To: dev@dpdk.org
> Cc: Ji, Kai <kai.ji@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> Wysocki, JakubX <jakubx.wysocki@intel.com>
> Subject: [PATCH] crypto/scheduler: fix qp_id in scheduler failover
>
> This commit fixes wrong qp_id value in cryptodev scheduler in failover mode.
>
> Fixes: 37f075dad1e9 ("crypto/scheduler: add fail-over scheduling mode")
> Cc: roy.fan.zhang@intel.com
>
> Signed-off-by: Jakub Wysocki <jakubx.wysocki@intel.com>
> ---
Acked-by: Ji, Kai <kai.ji@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] crypto/scheduler: fix qp_id in scheduler failover
@ 2022-06-20 17:51 Jakub Wysocki
2022-06-20 22:12 ` Ji, Kai
0 siblings, 1 reply; 6+ messages in thread
From: Jakub Wysocki @ 2022-06-20 17:51 UTC (permalink / raw)
To: dev; +Cc: kai.ji, roy.fan.zhang, Jakub Wysocki
This commit fixes wrong qp_id value in cryptodev scheduler in failover
mode.
Fixes: 37f075dad1e9 ("crypto/scheduler: add fail-over scheduling mode")
Cc: roy.fan.zhang@intel.com
Signed-off-by: Jakub Wysocki <jakubx.wysocki@intel.com>
---
drivers/crypto/scheduler/scheduler_failover.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/crypto/scheduler/scheduler_failover.c b/drivers/crypto/scheduler/scheduler_failover.c
index 5023577ef8..0855adc841 100644
--- a/drivers/crypto/scheduler/scheduler_failover.c
+++ b/drivers/crypto/scheduler/scheduler_failover.c
@@ -157,6 +157,9 @@ scheduler_start(struct rte_cryptodev *dev)
((struct scheduler_qp_ctx *)
dev->data->queue_pairs[i])->private_qp_ctx;
+sched_ctx->workers[PRIMARY_WORKER_IDX].qp_id = i;
+sched_ctx->workers[SECONDARY_WORKER_IDX].qp_id = i;
+
rte_memcpy(&qp_ctx->primary_worker,
&sched_ctx->workers[PRIMARY_WORKER_IDX],
sizeof(struct scheduler_worker));
--
2.17.1
--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-21 10:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-15 13:13 [PATCH] crypto/scheduler: fix qp_id in scheduler failover Jakub Wysocki
2022-06-16 8:54 ` Zhang, Roy Fan
2022-06-20 9:12 ` Zhang, Roy Fan
2022-06-20 17:51 Jakub Wysocki
2022-06-20 22:12 ` Ji, Kai
2022-06-21 10:34 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).