RE: [Patch v6 06/18] net/mana: add device info

[Long Li <longli@microsoft.com>]

> Subject: Re: [Patch v6 06/18] net/mana: add device info
> 
> On 2022/8/31 6:51, longli@linuxonhyperv.com wrote:
> > From: Long Li <longli@microsoft.com>
> >
> > Add the function to get device info.
> >
> > Signed-off-by: Long Li <longli@microsoft.com>
> > ---
> >  doc/guides/nics/features/mana.ini |  1 +
> >  drivers/net/mana/mana.c           | 82 +++++++++++++++++++++++++++++++
> >  2 files changed, 83 insertions(+)
> >
> > diff --git a/doc/guides/nics/features/mana.ini
> > b/doc/guides/nics/features/mana.ini
> > index 8043e11f99..566b3e8770 100644
> > --- a/doc/guides/nics/features/mana.ini
> > +++ b/doc/guides/nics/features/mana.ini
> > @@ -8,5 +8,6 @@ Link status          = P
> >  Linux                = Y
> >  Multiprocess aware   = Y
> >  Removal event        = Y
> > +Speed capabilities   = P
> >  Usage doc            = Y
> >  x86-64               = Y
> > diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c index
> > c9591035ac..e1550b3c08 100644
> > --- a/drivers/net/mana/mana.c
> > +++ b/drivers/net/mana/mana.c
> > @@ -116,6 +116,86 @@ mana_dev_close(struct rte_eth_dev *dev)
> >  	return 0;
> >  }
> >
> > +static int mana_dev_info_get(struct rte_eth_dev *dev,
> > +			     struct rte_eth_dev_info *dev_info) {
> > +	struct mana_priv *priv = dev->data->dev_private;
> > +
> > +	dev_info->max_mtu = RTE_ETHER_MTU;
> 
> ...
> 
> > +	dev_info->tx_desc_lim.nb_max = priv->max_tx_desc;
> > +	dev_info->tx_desc_lim.nb_align = MIN_BUFFERS_PER_QUEUE;
> > +	dev_info->tx_desc_lim.nb_seg_max = priv->max_send_sge;
> > +	dev_info->rx_desc_lim.nb_mtu_seg_max = priv->max_recv_sge;
> > +
> > +	/* Speed */
> > +	dev_info->speed_capa = ETH_LINK_SPEED_100G;
> 
> I notice "[Patch v6 04/18] net/mana: add link update" report always 200G, why
> here is 100G?

Thanks for pointing this out. I will fix patch 04.

> 
> > +
> > +	/* RX params */
> > +	dev_info->default_rxportconf.burst_size = 1;
> > +	dev_info->default_rxportconf.ring_size =
> MAX_RECEIVE_BUFFERS_PER_QUEUE;
> > +	dev_info->default_rxportconf.nb_queues = 1;
> > +
> > +	/* TX params */
> > +	dev_info->default_txportconf.burst_size = 1;
> > +	dev_info->default_txportconf.ring_size =
> MAX_SEND_BUFFERS_PER_QUEUE;
> > +	dev_info->default_txportconf.nb_queues = 1;
> > +
> > +	return 0;
> > +}
> > +
> 
> ...