RE: [PATCH v2 2/2] net/bonding: add command to set dedicated queue size

[Chaoyong He <chaoyong.he@corigine.com>]

> On Fri, 11 Oct 2024 11:24:12 +0800
> Chaoyong He <chaoyong.he@corigine.com> wrote:
> 
> > From: Long Wu <long.wu@corigine.com>
> >
> > The testpmd application can not modify the value of dedicated hardware
> > Rx/Tx queue size, and hardcoded them as (128/512). This will cause the
> > bonding port start fail if some NIC requires more Rx/Tx descriptors
> > than the hardcoded number.
> >
> > Therefore, add a command into testpmd application to support the
> > modification of the size of the dedicated hardware Rx/Tx queue. Also
> > export an external interface to also let other applications can change
> > it.
> >
> > Signed-off-by: Long Wu <long.wu@corigine.com>
> > Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
> > Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> 
> 24.11 is released, this patch if still of interest will need to be rebased.

Okay, we will send new version patch later.

> 
> The definition of what a "dedicated queue" is a bit confusing.
> If it is only for LACP packets, it should never need to be very big.
> Only under a mis-configuration and DoS kind of flood should there ever be
> many packets.

Yes, the dedicated queue is only for LACP packets now and it doesn't need be set very big.

But if we use a hardware queue as the "dedicated queue", we must consider the hardware
capability. The minimum queue size of some NICs may be larger than the hardcode dedicated
queue size. In this case, I think it is better to add an interface to set the dedicated queue size.