DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Rong, Leyi" <leyi.rong@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "talshn@nvidia.com" <talshn@nvidia.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Kadam, Pallavi" <pallavi.kadam@intel.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Menon, Ranjit" <ranjit.menon@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix mingw build error
Date: Wed, 27 Jan 2021 12:18:59 +0000
Message-ID: <SN6PR11MB262106912FABEF2AB6613A69ECBB9@SN6PR11MB2621.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210127104031.GA1626@bricha3-MOBL.ger.corp.intel.com>


> -----Original Message-----
> From: Bruce Richardson <bruce.richardson@intel.com>
> Sent: Wednesday, January 27, 2021 6:41 PM
> To: Rong, Leyi <leyi.rong@intel.com>
> Cc: talshn@nvidia.com; Zhang, Qi Z <qi.z.zhang@intel.com>; Kadam, Pallavi
> <pallavi.kadam@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; Menon,
> Ranjit <ranjit.menon@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/i40e: fix mingw build error
> 
> On Wed, Jan 27, 2021 at 04:47:45PM +0800, Leyi Rong wrote:
> > Disable i40e avx512 code path for windows build to avoid the mingw
> > build error.
> >
> > Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path")
> >
> > Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> > ---
> >  drivers/net/i40e/meson.build | 26 ++++++++++++++------------
> >  1 file changed, 14 insertions(+), 12 deletions(-)
> >
> > diff --git a/drivers/net/i40e/meson.build
> > b/drivers/net/i40e/meson.build index c0acdf4fd4..34c9dfa681 100644
> > --- a/drivers/net/i40e/meson.build
> > +++ b/drivers/net/i40e/meson.build
> > @@ -54,19 +54,21 @@ if arch_subdir == 'x86'
> >  		cc.has_argument('-mavx512f') and
> >  		cc.has_argument('-mavx512bw'))
> >
> > -	if i40e_avx512_cpu_support == true or i40e_avx512_cc_support == true
> > -		cflags += ['-DCC_AVX512_SUPPORT']
> > -		avx512_args = [cflags, '-mavx512f', '-mavx512bw']
> > -		if cc.has_argument('-march=skylake-avx512')
> > -			avx512_args += '-march=skylake-avx512'
> > +	if not is_windows or cc.get_id() == 'clang'
> > +		if i40e_avx512_cpu_support == true or i40e_avx512_cc_support
> ==
> > +true
> 
> Rather than changing this whole block to indent it further following the new
> condition check, I think a simpler fix might be to insert:
> 
> if is_windows and cc.get_id() != 'clang'
> 	i40e_avx512_cc_support = false
> endif
> 
> just after the initial assignment to i40e_avx512_cc_support. [Alternatively, you
> can include those conditions in the assignment itself, but it's probably more
> readable done separately as I show above.]
> 
> /Bruce

Agree, seems clear to put the logic block separately. Thanks~

  reply	other threads:[~2021-01-27 12:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26 15:38 [dpdk-dev] [PATCH] " Leyi Rong
2021-01-26 16:18 ` Kadam, Pallavi
2021-01-26 17:04 ` Tal Shnaiderman
2021-01-27  8:30   ` Rong, Leyi
2021-01-27  8:47 ` [dpdk-dev] [PATCH v2 0/2] " Leyi Rong
2021-01-27  8:47   ` [dpdk-dev] [PATCH v2 1/2] config: disable avx512 on mingw cross build Leyi Rong
2021-01-27  8:47   ` [dpdk-dev] [PATCH v2 2/2] net/i40e: fix mingw build error Leyi Rong
2021-01-27 10:40     ` Bruce Richardson
2021-01-27 12:18       ` Rong, Leyi [this message]
2021-01-27 14:27 ` [dpdk-dev] [PATCH v3 0/2] " Leyi Rong
2021-01-27 14:27   ` [dpdk-dev] [PATCH v3 1/2] config: disable avx512 on mingw cross build Leyi Rong
2021-01-27 14:27   ` [dpdk-dev] [PATCH v3 2/2] net/i40e: fix mingw build error Leyi Rong
2021-01-27 19:15   ` [dpdk-dev] [PATCH v3 0/2] " Kadam, Pallavi
2021-01-28 12:28   ` David Marchand
2021-01-28 21:26     ` Thomas Monjalon
2021-02-02  8:36       ` David Marchand
2021-02-02  9:09         ` Rong, Leyi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB262106912FABEF2AB6613A69ECBB9@SN6PR11MB2621.namprd11.prod.outlook.com \
    --to=leyi.rong@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=pallavi.kadam@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=ranjit.menon@intel.com \
    --cc=talshn@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git