DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	"Dybkowski, AdamX" <adamx.dybkowski@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	 "stephen@networkplumber.org" <stephen@networkplumber.org>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"bluca@debian.org" <bluca@debian.org>,
	"Akhil Goyal" <akhil.goyal@nxp.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	"Trahe, Fiona" <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
Date: Mon, 10 Aug 2020 11:49:32 +0000	[thread overview]
Message-ID: <SN6PR11MB2880D4F36FB171F52E5E2AB1E4440@SN6PR11MB2880.namprd11.prod.outlook.com> (raw)
In-Reply-To: <5056132.gDXpgoo2J5@thomas>

Sorry about that Thomas, Akhil, we should have chased up acks sooner. 

Given the proposed content of the patch, and the similar changes that are recommended and agreed
throughout DPDK do you think an exception can be made and that this change can get into 20.11 even
without the deprecation notice being in 20.08?
 

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, August 10, 2020 11:19 AM
> To: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Cc: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> stephen@networkplumber.org; Burakov, Anatoly <anatoly.burakov@intel.com>; bluca@debian.org;
> Akhil Goyal <akhil.goyal@nxp.com>; Richardson, Bruce <bruce.richardson@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] doc: scheduler API deprecation notice
> 
> 10/08/2020 11:47, Dybkowski, AdamX:
> > I see there are 3 ACKs: original (see the commit message) from Fan, then Thomas and Akhil.
> > This page: http://patches.dpdk.org/project/dpdk/list/?series=11317
> > also shows it has 3 ACKs.
> 
> Sorry I missed initial ack.
> 
> > Can I ask why it didn't go into 20.08 then?
> 
> Because it was completed late, I missed and nobody replied.
> 
> In general, I would like more support in last days of release,
> to avoid such miss.
> 
> 
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 06/08/2020 19:18, Akhil Goyal:
> > > > > 27/07/2020 11:41, Adam Dybkowski:
> > > > > > This patch adds a deprecation notice about upcoming changes in
> > > > > > public API of the Scheduler PMD.
> > > > > >
> > > > > > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> > > > > > Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
> > > > > > ---
> > > > > > +* scheduler: The functions
> > > > > > +``rte_cryptodev_scheduler_slave_attach``,
> > > > > > +  ``rte_cryptodev_scheduler_slave_detach`` and
> > > > > > +  ``rte_cryptodev_scheduler_slaves_get`` will be replaced in
> > > > > > +20.11 by
> > > > > > +  ``rte_cryptodev_scheduler_worker_attach``,
> > > > > > +  ``rte_cryptodev_scheduler_worker_detach`` and
> > > > > > +  ``rte_cryptodev_scheduler_workers_get`` accordingly.
> > > > >
> > > > > Acked-by: Thomas Monjalon <thomas@monjalon.net>
> > > > >
> > > > I wonder how this patch got missed.
> > > >
> > > > Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> > >
> > > Sorry it is missing an ack.
> 
> 


  reply	other threads:[~2020-08-10 11:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27  9:41 Adam Dybkowski
2020-08-06 14:21 ` Thomas Monjalon
2020-08-06 17:18   ` Akhil Goyal
2020-08-07 22:05     ` Thomas Monjalon
2020-08-10  9:47       ` Dybkowski, AdamX
2020-08-10 10:19         ` Thomas Monjalon
2020-08-10 11:49           ` Trahe, Fiona [this message]
2020-08-10 12:50             ` Thomas Monjalon
2020-08-12  9:52               ` Bruce Richardson
2020-08-12 10:22                 ` Thomas Monjalon
2020-08-12 10:49                   ` [dpdk-dev] [dpdk-techboard] " Maxime Coquelin
2020-08-12 10:57                     ` Hemant Agrawal
2020-08-12 12:23                       ` Thomas Monjalon
2020-08-12 15:25                         ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB2880D4F36FB171F52E5E2AB1E4440@SN6PR11MB2880.namprd11.prod.outlook.com \
    --to=fiona.trahe@intel.com \
    --cc=adamx.dybkowski@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).