DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Trahe, Fiona" <fiona.trahe@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"stephen@networkplumber.org" <stephen@networkplumber.org>,
	"ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
	"jerinj@marvell.com" <jerinj@marvell.com>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>,
	"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
	"bluca@debian.org" <bluca@debian.org>,
	"ktraynor@redhat.com" <ktraynor@redhat.com>,
	"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup	script
Date: Wed, 5 Aug 2020 17:46:21 +0000
Message-ID: <SN6PR11MB2880E967AF6686E9C6470508E44B0@SN6PR11MB2880.namprd11.prod.outlook.com> (raw)
In-Reply-To: <8050069.tTueApQPhr@thomas>

+1 for keeping at least the huge-page setup  part - I use this all the time.

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Wednesday, August 5, 2020 5:27 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; david.marchand@redhat.com; arybchenko@solarflare.com; Richardson, Bruce
> <bruce.richardson@intel.com>; stephen@networkplumber.org; ajit.khaparde@broadcom.com;
> jerinj@marvell.com; maxime.coquelin@redhat.com; akhil.goyal@nxp.com; bluca@debian.org;
> ktraynor@redhat.com; honnappa.nagarahalli@arm.com
> Subject: Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script
> 
> 05/08/2020 18:19, Ferruh Yigit:
> > On 8/4/2020 11:26 AM, Thomas Monjalon wrote:
> > > Environment configuration is the responsibility of distributions
> > > or upper-level frameworks.
> > > DPDK focus on documenting the requirements and some recommendations.
> > >
> > > Maintaining a good adaptative deployment setup is a project by itself.
> > > Anyway this script was interactive, useful only for experimenters.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> > >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > > index ea4cfa7a48..7ce9fc3e4f 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -151,3 +151,7 @@ Deprecation Notices
> > >    Python 2 support will be completely removed in 20.11.
> > >    In 20.08, explicit deprecation warnings will be displayed when running
> > >    scripts with Python 2.
> > > +
> > > +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> > > +  ``make``. Given environments are too much variables for such a simple script,
> > > +  it will be removed in DPDK 20.11.
> > >
> >
> > Personally I use script as a shortcut to allocate hugemaps, and find that bit
> > useful.
> >
> > Agree that the environment configuration or deployment script is something else,
> > and not sure if this script ever claimed to be one, it is more a user helper
> > script I think.
> >
> > What do you think remove the build part, which depends to Make build system as
> > mentioned above, and keep the rest as a helper script (and perhaps rename to
> > highlight the intention), so basically keep only below part:
> >
> > ----------------------------------------------------------
> >  Step 2: Setup linux environment
> > ----------------------------------------------------------
> > [45] Insert IGB UIO module
> > [46] Insert VFIO module
> 
> It does not cover other kernel modules.
> 
> > [47] Insert KNI module
> > [48] Setup hugepage mappings for non-NUMA systems
> > [49] Setup hugepage mappings for NUMA systems
> 
> It does not use the standard hugepage directory.
> 
> > [50] Display current Ethernet/Baseband/Crypto device settings
> > [51] Bind Ethernet/Baseband/Crypto device to IGB UIO module
> > [52] Bind Ethernet/Baseband/Crypto device to VFIO module
> 
> These are just calling another script in usertools.
> 
> > [53] Setup VFIO permissions
> >
> > ----------------------------------------------------------
> >  Step 4: Other tools
> > ----------------------------------------------------------
> > [56] List hugepage info from /proc/meminfo
> >
> > ----------------------------------------------------------
> >  Step 5: Uninstall and system cleanup
> > ----------------------------------------------------------
> > [57] Unbind devices from IGB UIO or VFIO driver
> > [58] Remove IGB UIO module
> > [59] Remove VFIO module
> > [60] Remove KNI module
> > [61] Remove hugepage mappings
> 
> This script has bad quality and is very partial.
> Are we sure we want to keep above parts?
> What about adding separate scripts for VFIO permissions
> or hugepage mapping and info?
> 


  reply	other threads:[~2020-08-05 17:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-04 10:26 Thomas Monjalon
2020-08-04 10:30 ` Maxime Coquelin
2020-08-04 10:33   ` Jerin Jacob
2020-08-05 16:19 ` Ferruh Yigit
2020-08-05 16:26   ` Thomas Monjalon
2020-08-05 17:46     ` Trahe, Fiona [this message]
2020-08-05 18:26       ` Stephen Hemminger
2020-08-06  9:35         ` Bruce Richardson
2020-08-06 13:51           ` Kinsella, Ray
2020-08-06 14:43             ` Thomas Monjalon
2020-08-06 14:51 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-08-06 16:23   ` Stephen Hemminger
2020-08-06 16:25     ` Thomas Monjalon
2020-08-06 16:56       ` Stephen Hemminger
2020-08-06 17:02         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB2880E967AF6686E9C6470508E44B0@SN6PR11MB2880.namprd11.prod.outlook.com \
    --to=fiona.trahe@intel.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=akhil.goyal@nxp.com \
    --cc=arybchenko@solarflare.com \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=jerinj@marvell.com \
    --cc=ktraynor@redhat.com \
    --cc=maxime.coquelin@redhat.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git