DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xia, Chenbo" <chenbo.xia@intel.com>
To: Nobuhiro MIKI <nmiki@yahoo-corp.jp>,
	"maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH 1/2] vhost: fix constants to follow new naming convension
Date: Thu, 9 Mar 2023 03:06:02 +0000	[thread overview]
Message-ID: <SN6PR11MB3504175BFFB5392E5B1942339CB59@SN6PR11MB3504.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230309020721.22164-2-nmiki@yahoo-corp.jp>

> -----Original Message-----
> From: Nobuhiro MIKI <nmiki@yahoo-corp.jp>
> Sent: Thursday, March 9, 2023 10:07 AM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Nobuhiro MIKI <nmiki@yahoo-corp.jp>
> Subject: [PATCH 1/2] vhost: fix constants to follow new naming convension
> 
> DPDK apps (e.g. dpdk-skeleton) output this name
> during negotiation. But, it is not consistent when
> debugging using QEMU as a front-end, for example.
> This is because QEMU already follows new naming convention [1].
> 
> Some type names and variable names, such as VhostUserSlaveRequest,
> are still in old naming convension. But, in this patch we
> only focus on constants.
> 
> [1] https://qemu-project.gitlab.io/qemu/interop/vhost-user.html
> 
> Signed-off-by: Nobuhiro MIKI <nmiki@yahoo-corp.jp>
> ---
>  drivers/vdpa/ifc/ifcvf_vdpa.c   |  4 ++--
>  drivers/vdpa/mlx5/mlx5_vdpa.c   |  4 ++--
>  drivers/vdpa/sfc/sfc_vdpa_ops.c |  4 ++--
>  lib/vhost/rte_vhost.h           |  8 ++++----
>  lib/vhost/vhost_user.c          | 14 +++++++-------
>  lib/vhost/vhost_user.h          | 14 +++++++-------
>  6 files changed, 24 insertions(+), 24 deletions(-)
> 

As I said in patch 2, it's better to update the mailmap file in this patch 1.

Thanks,
Chenbo

  reply	other threads:[~2023-03-09  3:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09  2:07 [PATCH 0/2] vhost: fix names to follow new naming convention Nobuhiro MIKI
2023-03-09  2:07 ` [PATCH 1/2] vhost: fix constants to follow new naming convension Nobuhiro MIKI
2023-03-09  3:06   ` Xia, Chenbo [this message]
2023-03-09  2:07 ` [PATCH 2/2] vhost: refactor to follow new naming convention Nobuhiro MIKI
2023-03-09  3:03   ` Xia, Chenbo
2023-03-09  4:51     ` Nobuhiro MIKI
2023-03-09  2:40 ` [PATCH 0/2] vhost: fix names " Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB3504175BFFB5392E5B1942339CB59@SN6PR11MB3504.namprd11.prod.outlook.com \
    --to=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=nmiki@yahoo-corp.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).