From: "Sebastian, Selwin" <Selwin.Sebastian@amd.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for Scattered Rx
Date: Fri, 28 Feb 2020 09:00:05 +0000 [thread overview]
Message-ID: <SN6PR12MB2704EDA7920F2E1B64FF7F528DE80@SN6PR12MB2704.namprd12.prod.outlook.com> (raw)
In-Reply-To: <0a7146b3-7bd5-fda6-34b2-cd293fdf3ca3@intel.com>
Thanks and Regards
Selwin Sebastian
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com>
Sent: Thursday, February 27, 2020 8:08 PM
To: Sebastian, Selwin <Selwin.Sebastian@amd.com>; dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for Scattered Rx
[CAUTION: External Email]
On 2/27/2020 2:35 PM, Sebastian, Selwin wrote:
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi Ferruh,
> For validation of scatter using the testpmd method mentioned in dpdk docs, we need to have these Tx offloads also enabled.
[Please don't top post, it makes conversation hard to follow.]
Can you point where there testpmd requirement in the code?
https://doc.dpdk.org/dts/test_plans/scatter_test_plan.html talks about DEV_TX_OFFLOAD_MULTI_SEGS as a prerequisites for scatter . When I add DEV_TX_OFFLOAD_MULTI_SEGS for tx capability , I was forced to add " DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM , DEV_TX_OFFLOAD_UDP_TSO , DEV_TX_OFFLOAD_SCTP_CKSUM" for the mentioned testpmd to run.
Also these offloads should be enabled when HW/Driver supports it, not for it is required by testpmd.
I am able to test scatter without adding "DEV_TX_OFFLOAD_MULTI_SEGS" tx capability. Shall I submit version2 of the patch after removing " DEV_TX_OFFLOAD_MULTI_SEGS, DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM , DEV_TX_OFFLOAD_UDP_TSO, DEV_TX_OFFLOAD_SCTP_CKSUM" capabilities. ?
>
> Thanks and Regards
> Selwin Sebastian
>
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Thursday, February 27, 2020 7:59 PM
> To: Sebastian, Selwin <Selwin.Sebastian@amd.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for
> Scattered Rx
>
> [CAUTION: External Email]
>
> On 2/27/2020 6:33 AM, ssebasti@amd.com wrote:
>> From: Selwin Sebastian <selwin.sebastian@amd.com>
>>
>> Enable scattered rx support and add jumbo packet transmit capability
>>
>> Signed-off-by: Selwin Sebastian <selwin.sebastian@amd.com>
>
> <...>
>
>> @@ -789,11 +789,17 @@ axgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>> DEV_RX_OFFLOAD_IPV4_CKSUM |
>> DEV_RX_OFFLOAD_UDP_CKSUM |
>> DEV_RX_OFFLOAD_TCP_CKSUM |
>> + DEV_RX_OFFLOAD_JUMBO_FRAME |
>> + DEV_RX_OFFLOAD_SCATTER |
>> DEV_RX_OFFLOAD_KEEP_CRC;
>>
>> dev_info->tx_offload_capa =
>> DEV_TX_OFFLOAD_IPV4_CKSUM |
>> DEV_TX_OFFLOAD_UDP_CKSUM |
>> + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM |
>> + DEV_TX_OFFLOAD_UDP_TSO |
>> + DEV_TX_OFFLOAD_SCTP_CKSUM |
>> + DEV_TX_OFFLOAD_MULTI_SEGS |
>> DEV_TX_OFFLOAD_TCP_CKSUM;
>
> Is the Tx offload capability update related to the this change? If it is not can you please send these updates as a separate patch, and a send new version of this patch without this bit?
>
> Thanks,
> ferruh
>
next prev parent reply other threads:[~2020-02-28 9:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 6:33 ssebasti
2020-02-27 14:28 ` Ferruh Yigit
2020-02-27 14:35 ` Sebastian, Selwin
2020-02-27 14:38 ` Ferruh Yigit
2020-02-28 9:00 ` Sebastian, Selwin [this message]
2020-02-28 13:08 ` Ferruh Yigit
2020-02-28 13:09 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2020-02-25 12:40 ssebasti
2020-02-26 5:47 ` Kumar, Ravi1
2020-03-05 10:20 ` Kumar, Ravi1
2020-03-05 10:27 ` Kumar, Ravi1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR12MB2704EDA7920F2E1B64FF7F528DE80@SN6PR12MB2704.namprd12.prod.outlook.com \
--to=selwin.sebastian@amd.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).