DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "reshma.pattan@intel.com" <reshma.pattan@intel.com>,
	"jananeex.m.parthasarathy@intel.com"
	<jananeex.m.parthasarathy@intel.com>,
	"marko.kovacevic@intel.com" <marko.kovacevic@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/fips_validation: fix null pointer	dereferences
Date: Mon, 30 Sep 2019 20:21:31 +0000	[thread overview]
Message-ID: <VE1PR04MB663924964CC4E609BDF26DF3E6820@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1569393094-26761-1-git-send-email-tallurix.chaitanya.babu@intel.com>



> 
> One issue caught by Coverity 343408
> *deref_parm: Directly dereferencing parameter val->val.
> 
> In writeback_tdes_hex_str(), tmp_val is initialised to null.
> tmp_val.val is updated only if keys are found.
> If keys are not found,it doesn't fails but continues
> to invoke writeback_hex_str(),where val->val is accessed
> without null check.
> 
> The fix is to return the error,
> if keys are not found in writeback_tdes_hex_str().
> 
> Coverity issue: 343408
> Fixes: 527cbf3d5e ("examples/fips_validation: support TDES parsing")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied to dpdk-next-crypto

Thanks.

      reply	other threads:[~2019-09-30 20:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-25  6:31 Chaitanya Babu Talluri
2019-09-30 20:21 ` Akhil Goyal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VE1PR04MB663924964CC4E609BDF26DF3E6820@VE1PR04MB6639.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=jananeex.m.parthasarathy@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=reshma.pattan@intel.com \
    --cc=stable@dpdk.org \
    --cc=tallurix.chaitanya.babu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).