From: Akhil Goyal <akhil.goyal@nxp.com>
To: Shally Verma <shallyv@marvell.com>,
Anoob Joseph <anoobj@marvell.com>,
Ayuj Verma <ayverma@marvell.com>
Cc: "arkadiuszx.kusztal@intel.com" <arkadiuszx.kusztal@intel.com>,
Sunila Sahu <ssahu@marvell.com>,
Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Fiona Trahe <fiona.trahe@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable
Date: Thu, 25 Jul 2019 11:42:33 +0000 [thread overview]
Message-ID: <VE1PR04MB663975E68252359D3AF4A8E0E6C10@VE1PR04MB6639.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <BN6PR1801MB205250F038CE71F1B559F965ADC10@BN6PR1801MB2052.namprd18.prod.outlook.com>
>
> Hi Akhil
>
> >
> > Hi Anoob/Shally
> >
> > > >
> > > > Hi Ayuj,
> > > >
> > > > I believe there are couple of issues with this patch.
> > > >
> > > > Are these experimental APIs? I believe they were made stable this
> > > > release and I'm not sure if it is a right practice to edit an API
> > > > without deprecation notice after it is made stable. Especially now
> > > > that RC2 is done. @Akhil, what is your take on this?
> > > > [Shally] These are experimental still, hence no deprecation notice.
> > > > We checked about it with Fiona, Akhil before.
> > >
> > > [Anoob] In the patch, the edited APIs doesn't have experimental tag. I
> > > leave it to Akhil's judgement on this.
> > >
> > The API is experimental. Check the .map file.
> >
> > But these kind of patches cannot go in 1908 release, as we have already
> > tagged it for RC2.
> > We need to defer this change for 19.11 release.
> >
> [Shally] Well. Cant do anything if we have missed deadline here. Right now its up
> for feedback.
> Meanwhile if we get any agreement and window gets open for nearest release,
> then please consider it.
library changes cannot go beyond RC2 unless it is a fix for some issue.
>
> > One more issue that I see in this patch. QAT also uses these APIs, so it shall
> > also be modified along with openssl.
> >
> [Shally] We assume QAT changes will be done by QAT maintainer, once they
> review and approve this change.
>
Patch 1/2 will break the compilation for QAT and openssl.
All changes should be part of a single patch (both for QAT and openssl).
If somebody is modifying the common code, then it should not atleast break the compilation.
Check the following commit.
http://git.dpdk.org/next/dpdk-next-crypto/commit/?id=186b14d6850654eb84a8ae9ea29b736f0ba5e093
-Akhil
next prev parent reply other threads:[~2019-07-25 11:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 8:51 Ayuj Verma
2019-07-24 8:51 ` [dpdk-dev] [PATCH v1 1/2] lib/crypto: " Ayuj Verma
2019-07-24 8:51 ` [dpdk-dev] [PATCH v1 2/2] crypto/openssl: mark asym xform constant Ayuj Verma
2019-07-24 8:52 ` [dpdk-dev] [PATCH v1 0/2] declare crypto asym xform immutable Ayuj Verma
2019-07-25 4:15 ` Anoob Joseph
2019-07-25 5:21 ` Shally Verma
2019-07-25 5:26 ` Anoob Joseph
2019-07-25 6:37 ` Anoob Joseph
2019-07-25 7:58 ` Shally Verma
2019-07-25 14:27 ` Kusztal, ArkadiuszX
2019-07-29 11:38 ` Ayuj Verma
2019-09-05 9:22 ` Kusztal, ArkadiuszX
2019-09-05 14:22 ` Shally Verma
2019-09-06 6:08 ` Anoob Joseph
2019-09-06 11:25 ` Trahe, Fiona
2019-09-13 14:02 ` Sunila Sahu
2019-09-13 14:59 ` Kusztal, ArkadiuszX
2019-07-25 11:27 ` Akhil Goyal
2019-07-25 11:35 ` Shally Verma
2019-07-25 11:42 ` Akhil Goyal [this message]
2019-07-25 11:46 ` Shally Verma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VE1PR04MB663975E68252359D3AF4A8E0E6C10@VE1PR04MB6639.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=ayverma@marvell.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=kkotamarthy@marvell.com \
--cc=shallyv@marvell.com \
--cc=ssahu@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).