From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Trahe, Fiona" <fiona.trahe@intel.com>,
"ruifeng.wang@arm.com" <ruifeng.wang@arm.com>,
"michaelsh@marvell.com" <michaelsh@marvell.com>
Subject: Re: [dpdk-dev] [PATCH v2 3/5] cryptodev: remove crypto list end enumerators
Date: Mon, 12 Oct 2020 11:46:04 +0000 [thread overview]
Message-ID: <VI1PR04MB3168237B6E62068D7763CBCAE6070@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CY4PR11MB18303B9DAC11D2FB166B22819F070@CY4PR11MB1830.namprd11.prod.outlook.com>
Hi Arek,
> Hi Akhil,
>
> > -----Original Message-----
> > From: Akhil Goyal <akhil.goyal@nxp.com>
> > Sent: czwartek, 8 października 2020 21:58
> > To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> > Cc: Trahe, Fiona <fiona.trahe@intel.com>; ruifeng.wang@arm.com;
> > michaelsh@marvell.com
> > Subject: RE: [PATCH v2 3/5] cryptodev: remove crypto list end enumerators
> >
> > > diff --git a/lib/librte_cryptodev/rte_crypto_sym.h
> > > b/lib/librte_cryptodev/rte_crypto_sym.h
> > > index f29c98051..7a2556a9e 100644
> > > --- a/lib/librte_cryptodev/rte_crypto_sym.h
> > > +++ b/lib/librte_cryptodev/rte_crypto_sym.h
> > > @@ -132,15 +132,12 @@ enum rte_crypto_cipher_algorithm {
> > > * for m_src and m_dst in the rte_crypto_sym_op must be NULL.
> > > */
> > >
> > > - RTE_CRYPTO_CIPHER_DES_DOCSISBPI,
> > > + RTE_CRYPTO_CIPHER_DES_DOCSISBPI
> > > /**< DES algorithm using modes required by
> > > * DOCSIS Baseline Privacy Plus Spec.
> > > * Chained mbufs are not supported in this mode, i.e. rte_mbuf.next
> > > * for m_src and m_dst in the rte_crypto_sym_op must be NULL.
> > > */
> > > -
> > > - RTE_CRYPTO_CIPHER_LIST_END
> > > -
> > > };
> >
> > Probably we should add a comment for each of the enums that we change,
> that
> > the user can define its own LIST_END = last item in the enum +1.
> > LIST_END is not added to avoid ABI breakage across releases when new algos
> > are added.
> [Arek] - I do not now if necessary, should it be some kind of guarantee that
> order and number of enumerators will not change across the releases?
Yes we should make sure in the future that the order of enums are not changed
In future. This can be mentioned in the comments. We will be adding the new algos
In the end only. Please add a comment.
next prev parent reply other threads:[~2020-10-12 11:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 17:32 [dpdk-dev] [PATCH v2 0/5] cryptodev: remove " Arek Kusztal
2020-09-30 17:32 ` [dpdk-dev] [PATCH v2 1/5] app/test: remove list end references from asym crypto Arek Kusztal
2020-09-30 17:32 ` [dpdk-dev] [PATCH v2 2/5] crypto/qat: remove asym list end references Arek Kusztal
2020-09-30 17:32 ` [dpdk-dev] [PATCH v2 3/5] cryptodev: remove crypto list end enumerators Arek Kusztal
2020-10-08 19:58 ` Akhil Goyal
2020-10-12 5:15 ` Kusztal, ArkadiuszX
2020-10-12 11:46 ` Akhil Goyal [this message]
2020-09-30 17:32 ` [dpdk-dev] [PATCH v2 4/5] cryptodev: remove list ends from asymmetric crypto api Arek Kusztal
2020-10-08 19:51 ` Akhil Goyal
2020-10-09 7:02 ` Kusztal, ArkadiuszX
2020-09-30 17:32 ` [dpdk-dev] [PATCH v2 5/5] doc: remove crypto list end deprecation notice Arek Kusztal
2020-10-01 9:49 ` [dpdk-dev] [PATCH v2 0/5] cryptodev: remove list end enumerators Trahe, Fiona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=VI1PR04MB3168237B6E62068D7763CBCAE6070@VI1PR04MB3168.eurprd04.prod.outlook.com \
--to=akhil.goyal@nxp.com \
--cc=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=michaelsh@marvell.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).