DPDK patches and discussions
 help / color / mirror / Atom feed
From: Akhil Goyal <akhil.goyal@nxp.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>,
	David Marchand <david.marchand@redhat.com>,
	"Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>,
	Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Anoob Joseph <anoobj@marvell.com>,
	"shallyv@marvell.com" <shallyv@marvell.com>,
	"Doherty, Declan" <declan.doherty@intel.com>,
	"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [dpdk-dev] [PATCH] [RFC] doc: announce removal of crypto list end enumerators
Date: Fri, 31 Jul 2020 09:38:27 +0000	[thread overview]
Message-ID: <VI1PR04MB31687BF53B2106212A8BD640E64E0@VI1PR04MB3168.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <SN6PR11MB28808412C9B2EE2F8C858FC5E4700@SN6PR11MB2880.namprd11.prod.outlook.com>

Hi David,

> Hi David,
> 
> >
> > On Wed, Jul 29, 2020 at 4:47 PM Arek Kusztal
> > <arkadiuszx.kusztal@intel.com> wrote:
> > >
> > > Enumerators RTE_CRYPTO_CIPHER_LIST_END,
> RTE_CRYPTO_AUTH_LIST_END,
> > > RTE_CRYPTO_AEAD_LIST_END will be removed to prevent some problems
> > > that may arise when adding new algorithms.
> >
> > How does it cohabitate with Ferruh notice?
> > Is it a complement? or redundant?
> >
> >
> https://git.dpdk.org/dpdk/commit/doc/guides/rel_notes/deprecation.rst?id=58245da070289f4b248f15
> >
> Thanks for drawing attention to this.
> It's complementary as far as I can see.
> Ferruh's doesn't list all enums - but doesn’t appear to cover these crypto ones.

I feel we can have this deprecation notice as well for crypto specific enums.
Though I don’t want to push it if somebody has objections on this.
I am OK if Ferruh's notice looks enough to cover crypto enums as well.

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
If no objections, Thomas or you can pick this directly on master.

Regards,
Akhil

  reply	other threads:[~2020-07-31  9:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-29 14:46 Arek Kusztal
2020-07-29 14:54 ` Kusztal, ArkadiuszX
2020-07-29 15:18 ` Bruce Richardson
2020-07-29 15:22 ` Trahe, Fiona
2020-07-29 15:24 ` David Marchand
2020-07-29 15:32   ` Trahe, Fiona
2020-07-31  9:38     ` Akhil Goyal [this message]
2020-08-06 16:09       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=VI1PR04MB31687BF53B2106212A8BD640E64E0@VI1PR04MB3168.eurprd04.prod.outlook.com \
    --to=akhil.goyal@nxp.com \
    --cc=anoobj@marvell.com \
    --cc=arkadiuszx.kusztal@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=shallyv@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).